From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org,
Andreas Gruenbacher <agruenba@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/3] fs: use ->is_partially_uptodate in page_cache_seek_hole_data
Date: Thu, 31 May 2018 08:20:55 +0200 [thread overview]
Message-ID: <20180531062055.GA31523@lst.de> (raw)
In-Reply-To: <20180530230038.GY10363@dastard>
On Thu, May 31, 2018 at 09:00:38AM +1000, Dave Chinner wrote:
> > -/*
> > - * Seek for SEEK_DATA / SEEK_HOLE within @page, starting at @lastoff.
> > - *
> > - * Returns the offset within the file on success, and -ENOENT otherwise.
> > - */
> > -static loff_t
> > -page_seek_hole_data(struct page *page, loff_t lastoff, int whence)
> > +static bool
> > +page_seek_hole_data(struct inode *inode, struct page *page, loff_t *lastoff,
> > + int whence)
>
> Can we keep the comment explaining the return value?
The old comment isn't going to be correct. I've added back a changed
comment, akthough I don't really think it helps.
> > + const struct address_space_operations *ops = inode->i_mapping->a_ops;
> > + unsigned int bsize = i_blocksize(inode), off;
>
> Split this into two lines.
We've got a pattern here - I really like it that way..
next prev parent reply other threads:[~2018-05-31 6:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 10:02 iomap SEEK_HOLE / SEEK_DATA cleanups and generalization Christoph Hellwig
2018-05-30 10:02 ` [PATCH 1/3] fs: move page_cache_seek_hole_data to iomap.c Christoph Hellwig
2018-05-30 22:46 ` Dave Chinner
2018-05-30 10:02 ` [PATCH 2/3] fs: remove the buffer_unwritten check in page_seek_hole_data Christoph Hellwig
2018-05-30 22:47 ` Dave Chinner
2018-05-30 10:02 ` [PATCH 3/3] fs: use ->is_partially_uptodate in page_cache_seek_hole_data Christoph Hellwig
2018-05-30 13:48 ` Andreas Grünbacher
2018-05-30 23:00 ` Dave Chinner
2018-05-31 6:20 ` Christoph Hellwig [this message]
2018-05-30 16:07 ` iomap SEEK_HOLE / SEEK_DATA cleanups and generalization Darrick J. Wong
2018-05-30 16:17 ` Christoph Hellwig
2018-05-30 16:25 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2018-05-31 18:07 iomap SEEK_HOLE / SEEK_DATA cleanups and generalization v2 Christoph Hellwig
2018-05-31 18:07 ` [PATCH 3/3] fs: use ->is_partially_uptodate in page_cache_seek_hole_data Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180531062055.GA31523@lst.de \
--to=hch@lst.de \
--cc=agruenba@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.