From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Clark Williams <williams@redhat.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
YueHaibing <yuehaibing@huawei.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
netdev@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 3/7] perf bpf: Fix NULL return handling in bpf__prepare_load()
Date: Thu, 31 May 2018 07:32:16 -0300 [thread overview]
Message-ID: <20180531103220.24684-4-acme@kernel.org> (raw)
In-Reply-To: <20180531103220.24684-1-acme@kernel.org>
From: YueHaibing <yuehaibing@huawei.com>
bpf_object__open()/bpf_object__open_buffer can return error pointer or
NULL, check the return values with IS_ERR_OR_NULL() in bpf__prepare_load
and bpf__prepare_load_buffer
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: netdev@vger.kernel.org
Link: https://lkml.kernel.org/n/tip-psf4xwc09n62al2cb9s33v9h@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/bpf-loader.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/bpf-loader.c b/tools/perf/util/bpf-loader.c
index af7ad814b2c3..cee658733e2c 100644
--- a/tools/perf/util/bpf-loader.c
+++ b/tools/perf/util/bpf-loader.c
@@ -66,7 +66,7 @@ bpf__prepare_load_buffer(void *obj_buf, size_t obj_buf_sz, const char *name)
}
obj = bpf_object__open_buffer(obj_buf, obj_buf_sz, name);
- if (IS_ERR(obj)) {
+ if (IS_ERR_OR_NULL(obj)) {
pr_debug("bpf: failed to load buffer\n");
return ERR_PTR(-EINVAL);
}
@@ -102,14 +102,14 @@ struct bpf_object *bpf__prepare_load(const char *filename, bool source)
pr_debug("bpf: successfull builtin compilation\n");
obj = bpf_object__open_buffer(obj_buf, obj_buf_sz, filename);
- if (!IS_ERR(obj) && llvm_param.dump_obj)
+ if (!IS_ERR_OR_NULL(obj) && llvm_param.dump_obj)
llvm__dump_obj(filename, obj_buf, obj_buf_sz);
free(obj_buf);
} else
obj = bpf_object__open(filename);
- if (IS_ERR(obj)) {
+ if (IS_ERR_OR_NULL(obj)) {
pr_debug("bpf: failed to load %s\n", filename);
return obj;
}
--
2.14.3
next prev parent reply other threads:[~2018-05-31 10:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 10:32 [GIT PULL 0/7] perf/urgent fixes Arnaldo Carvalho de Melo
2018-05-31 10:32 ` Arnaldo Carvalho de Melo
2018-05-31 10:32 ` Arnaldo Carvalho de Melo
2018-05-31 10:32 ` Arnaldo Carvalho de Melo
2018-05-31 10:32 ` Arnaldo Carvalho de Melo
2018-05-31 10:32 ` [PATCH 1/7] perf parse-events: Handle uncore event aliases in small groups properly Arnaldo Carvalho de Melo
2018-05-31 10:32 ` [PATCH 2/7] perf test: "Session topology" dumps core on s390 Arnaldo Carvalho de Melo
2018-05-31 10:32 ` Arnaldo Carvalho de Melo [this message]
2018-05-31 10:32 ` [PATCH 4/7] perf cs-etm: Fix indexing for decoder packet queue Arnaldo Carvalho de Melo
2018-05-31 10:32 ` Arnaldo Carvalho de Melo
2018-05-31 10:32 ` [PATCH 5/7] perf data: Update documentation section on cpu topology Arnaldo Carvalho de Melo
2018-05-31 10:32 ` [PATCH 6/7] perf script python: Add addr into perf sample dict Arnaldo Carvalho de Melo
2018-05-31 10:32 ` Arnaldo Carvalho de Melo
2018-05-31 10:32 ` Arnaldo Carvalho de Melo
2018-05-31 10:32 ` [PATCH 7/7] perf tools: Fix perf.data format description of NRCPUS header Arnaldo Carvalho de Melo
2018-05-31 10:40 ` [GIT PULL 0/7] perf/urgent fixes Ingo Molnar
2018-05-31 10:40 ` Ingo Molnar
2018-05-31 10:40 ` Ingo Molnar
2018-05-31 10:40 ` Ingo Molnar
2018-05-31 10:40 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180531103220.24684-4-acme@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=williams@redhat.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.