All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 4/4] linux: config.in: add comment for Arm Cortex-M
Date: Thu, 31 May 2018 14:20:28 +0200	[thread overview]
Message-ID: <20180531142028.60408581@windsurf> (raw)
In-Reply-To: <1527768578-1351-4-git-send-email-christophe.priouzeau@st.com>

Hello Christophe,

Thanks for coming up with a patch series for this issue.

On Thu, 31 May 2018 12:09:42 +0000, Christophe PRIOUZEAU wrote:
> When binutils > 2.28 are selected on Arm Cortex-M cpu,
> linux kernel does not boot due to a new implementation
> of 'adr pseudo instruction' on binutils.
> 
> Bugzilla thread: https://bugs.busybox.net/show_bug.cgi?id=11051
> 
> Signed-off-by: Christophe Priouzeau <christophe.priouzeau@st.com>
> ---
> Changes v1 -> v2
>  - correct depends on for comment
> 
>  linux/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/linux/Config.in b/linux/Config.in
> index 73a3299..04d4548 100644
> --- a/linux/Config.in
> +++ b/linux/Config.in
> @@ -8,6 +8,10 @@ config BR2_LINUX_KERNEL
>  
>  if BR2_LINUX_KERNEL
>  
> +comment "Linux kernel will not boot with binutils >= 2.29"
> +	depends on !BR2_ARMV7M

So this comment will never appear on ARMv7M, which is exactly the
opposite of what we want. Did you test this ? Did you verify that the
comment actually appears when expected ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-05-31 12:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31 10:17 [Buildroot] [PATCH 1/4] Revert "configs/stm32f429: force usage of binutils 2.28.x" Christophe PRIOUZEAU
2018-05-31 10:17 ` [Buildroot] [PATCH 2/4] Revert "configs/stm32f469: " Christophe PRIOUZEAU
2018-05-31 10:17 ` [Buildroot] [PATCH 4/4] linux: config.in: add comment for Arm Cortex-M Christophe PRIOUZEAU
2018-05-31 11:39   ` Arnout Vandecappelle
2018-05-31 11:50     ` Christophe PRIOUZEAU
2018-05-31 12:02     ` Christophe PRIOUZEAU
2018-05-31 12:09   ` [Buildroot] [PATCH v2 1/4] Revert "configs/stm32f429: force usage of binutils 2.28.x" Christophe PRIOUZEAU
2018-05-31 12:09     ` [Buildroot] [PATCH v2 2/4] Revert "configs/stm32f469: " Christophe PRIOUZEAU
2018-05-31 12:09     ` [Buildroot] [PATCH v2 3/4] package/binutils: Cortex-M targets require version <2.29 Christophe PRIOUZEAU
2018-05-31 12:09     ` [Buildroot] [PATCH v2 4/4] linux: config.in: add comment for Arm Cortex-M Christophe PRIOUZEAU
2018-05-31 12:20       ` Thomas Petazzoni [this message]
2018-05-31 12:36         ` Christophe PRIOUZEAU
2018-05-31 12:42           ` Thomas Petazzoni
2018-05-31 10:17 ` [Buildroot] [PATCH 3/4] package/binutils: Cortex-M targets require version <2.29 Christophe PRIOUZEAU

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180531142028.60408581@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.