From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 05/25] MIPS: Octeon: refactor swiotlb code Date: Thu, 31 May 2018 18:38:59 +0200 Message-ID: <20180531163859.GA31181@lst.de> References: <20180525092111.18516-1-hch@lst.de> <20180525092111.18516-6-hch@lst.de> <20180530232552.4rqnoo3652mabrqq@pburton-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180530232552.4rqnoo3652mabrqq@pburton-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Paul Burton Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Florian Fainelli , David Daney , James Hogan , Kevin Cernekee , Ralf Baechle , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Tom Bogendoerfer , Jiaxun Yang , Huacai Chen , Christoph Hellwig List-Id: iommu@lists.linux-foundation.org On Wed, May 30, 2018 at 04:25:52PM -0700, Paul Burton wrote: > > +static const struct octeon_dma_map_ops octeon_gen2_ops = { > > + .phys_to_dma = octeon_hole_phys_to_dma, > > + .dma_to_phys = octeon_hole_dma_to_phys, > > +}; > > These are pointers to functions of the wrong type, right? phys_to_dma & > dma_to_phys have the struct device * argument but the octeon_hole_* > functions do not. I'd expect we either need to restore the > octeon_gen2_* wrappers that you remove below or change the definition of > the octeon_hole_* functions. That is true. I have no idea how that passed the buildbot, which reported all kinds of other issues in the original octeon conversion. I'll fix this for the next respin. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 31 May 2018 18:32:36 +0200 (CEST) Received: from verein.lst.de ([213.95.11.211]:57818 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23994685AbeEaQc3pOvhO (ORCPT ); Thu, 31 May 2018 18:32:29 +0200 Received: by newverein.lst.de (Postfix, from userid 2407) id CE8B068CEE; Thu, 31 May 2018 18:38:59 +0200 (CEST) Date: Thu, 31 May 2018 18:38:59 +0200 From: Christoph Hellwig To: Paul Burton Cc: Christoph Hellwig , Ralf Baechle , James Hogan , Kevin Cernekee , Florian Fainelli , Huacai Chen , Jiaxun Yang , David Daney , Tom Bogendoerfer , linux-mips@linux-mips.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH 05/25] MIPS: Octeon: refactor swiotlb code Message-ID: <20180531163859.GA31181@lst.de> References: <20180525092111.18516-1-hch@lst.de> <20180525092111.18516-6-hch@lst.de> <20180530232552.4rqnoo3652mabrqq@pburton-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180530232552.4rqnoo3652mabrqq@pburton-laptop> User-Agent: Mutt/1.5.17 (2007-11-01) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 64135 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: hch@lst.de Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Wed, May 30, 2018 at 04:25:52PM -0700, Paul Burton wrote: > > +static const struct octeon_dma_map_ops octeon_gen2_ops = { > > + .phys_to_dma = octeon_hole_phys_to_dma, > > + .dma_to_phys = octeon_hole_dma_to_phys, > > +}; > > These are pointers to functions of the wrong type, right? phys_to_dma & > dma_to_phys have the struct device * argument but the octeon_hole_* > functions do not. I'd expect we either need to restore the > octeon_gen2_* wrappers that you remove below or change the definition of > the octeon_hole_* functions. That is true. I have no idea how that passed the buildbot, which reported all kinds of other issues in the original octeon conversion. I'll fix this for the next respin.