From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns Date: Fri, 1 Jun 2018 11:26:57 +1000 Message-ID: <20180601012657.GQ10363@dastard> References: <20180529195106.14268-1-ross.zwisler@linux.intel.com> <20180529195106.14268-3-ross.zwisler@linux.intel.com> <20180529212510.GJ30110@magnolia> <20180529220114.GA13948@linux.intel.com> <20180531191332.GB7825@magnolia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180531191332.GB7825@magnolia> Sender: linux-kernel-owner@vger.kernel.org To: "Darrick J. Wong" Cc: Ross Zwisler , Toshi Kani , Mike Snitzer , dm-devel@redhat.com, Dave Jiang , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org List-Id: dm-devel.ids On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote: > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: > > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: > > > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote: > > > > From: Dave Jiang > > > > > > > > The function return values are confusing with the way the function is > > > > named. We expect a true or false return value but it actually returns > > > > 0/-errno. This makes the code very confusing. Changing the return values > > > > to return a bool where if DAX is supported then return true and no DAX > > > > support returns false. > > > > > > > > Signed-off-by: Dave Jiang > > > > Signed-off-by: Ross Zwisler > > > > > > Looks ok, do you want me to pull the first two patches through the xfs > > > tree? > > > > > > Reviewed-by: Darrick J. Wong > > > > Thanks for the review. > > > > I'm not sure what's best. If you do that then Mike will need to have a DM > > branch for the rest of the series based on your stable commits, yea? > > > > Mike what would you prefer? > > I /was/ about to say that I would pull in the first two patches, but now > I can't get xfs to mount with pmem at all, and have no way of testing > this...? I have similar problems, too, but: $ ndctl list [ { "dev":"namespace1.0", "mode":"raw", "size":8589934592, "sector_size":512, "blockdev":"pmem1" }, { "dev":"namespace0.0", "mode":"raw", "size":8589934592, "sector_size":512, "blockdev":"pmem0" } ] $ sudo ndctl create-namespace -f -e namespace0.0 --mode=fsdax Error: operation failed, region0 fsdax mode not available failed to reconfigure namespace: Invalid argument $ I can't make head or tail of what is going wrong here - how am I supposed to debug this and get it working again? FWIW, XFS+DAX used to just work on this setup (I hadn't even installed ndctl until this morning!) but after changing the kernel it no longer works. That would make it a regression, yes? Cheers, Dave. -- Dave Chinner david@fromorbit.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail03.adl2.internode.on.net (ipmail03.adl2.internode.on.net [150.101.137.141]) by ml01.01.org (Postfix) with ESMTP id 999AC20D7B266 for ; Thu, 31 May 2018 18:39:15 -0700 (PDT) Date: Fri, 1 Jun 2018 11:26:57 +1000 From: Dave Chinner Subject: Re: [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns Message-ID: <20180601012657.GQ10363@dastard> References: <20180529195106.14268-1-ross.zwisler@linux.intel.com> <20180529195106.14268-3-ross.zwisler@linux.intel.com> <20180529212510.GJ30110@magnolia> <20180529220114.GA13948@linux.intel.com> <20180531191332.GB7825@magnolia> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180531191332.GB7825@magnolia> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "Darrick J. Wong" Cc: Mike Snitzer , linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org List-ID: On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote: > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: > > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: > > > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote: > > > > From: Dave Jiang > > > > > > > > The function return values are confusing with the way the function is > > > > named. We expect a true or false return value but it actually returns > > > > 0/-errno. This makes the code very confusing. Changing the return values > > > > to return a bool where if DAX is supported then return true and no DAX > > > > support returns false. > > > > > > > > Signed-off-by: Dave Jiang > > > > Signed-off-by: Ross Zwisler > > > > > > Looks ok, do you want me to pull the first two patches through the xfs > > > tree? > > > > > > Reviewed-by: Darrick J. Wong > > > > Thanks for the review. > > > > I'm not sure what's best. If you do that then Mike will need to have a DM > > branch for the rest of the series based on your stable commits, yea? > > > > Mike what would you prefer? > > I /was/ about to say that I would pull in the first two patches, but now > I can't get xfs to mount with pmem at all, and have no way of testing > this...? I have similar problems, too, but: $ ndctl list [ { "dev":"namespace1.0", "mode":"raw", "size":8589934592, "sector_size":512, "blockdev":"pmem1" }, { "dev":"namespace0.0", "mode":"raw", "size":8589934592, "sector_size":512, "blockdev":"pmem0" } ] $ sudo ndctl create-namespace -f -e namespace0.0 --mode=fsdax Error: operation failed, region0 fsdax mode not available failed to reconfigure namespace: Invalid argument $ I can't make head or tail of what is going wrong here - how am I supposed to debug this and get it working again? FWIW, XFS+DAX used to just work on this setup (I hadn't even installed ndctl until this morning!) but after changing the kernel it no longer works. That would make it a regression, yes? Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm