From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@bootlin.com (Maxime Ripard) Date: Fri, 1 Jun 2018 17:17:01 +0200 Subject: [PATCH 06/15] arm: dts: sun: Add missing cooling device properties for CPUs In-Reply-To: <20180528105734.bkplm7tfaqsurdrn@vireshk-i7> References: <20180528084446.g24fphqqac2hi3rr@flea> <20180528105734.bkplm7tfaqsurdrn@vireshk-i7> Message-ID: <20180601151701.sshwfdbflic6mybv@flea> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Mon, May 28, 2018 at 04:27:34PM +0530, Viresh Kumar wrote: > On 28-05-18, 10:44, Maxime Ripard wrote: > > Hi, > > > > On Fri, May 25, 2018 at 04:01:52PM +0530, Viresh Kumar wrote: > > > The cooling device properties, like "#cooling-cells" and > > > "dynamic-power-coefficient", should either be present for all the CPUs > > > of a cluster or none. If these are present only for a subset of CPUs of > > > a cluster then things will start falling apart as soon as the CPUs are > > > brought online in a different order. For example, this will happen > > > because the operating system looks for such properties in the CPU node > > > it is trying to bring up, so that it can register a cooling device. > > > > > > Add such missing properties. > > > > > > Fix other missing properties (clocks, OPP, clock latency) as well to > > > make it all work. > > > > > > Signed-off-by: Viresh Kumar > > > > The prefix should be sunxi and not sun, but it looks good to me > > otherwise. > > > > Let me know what your preferred merge method is. > > Please pick it up directly and send it as part of your pull request. > Do you want me to resend or can you fix the $subject ? I just tried to apply it, and it failed. We have usually two different PR for the H3 SoCs and the others. Could you split the H3 in a separate patch (and fix the subject in the process?) Thanks! Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 06/15] arm: dts: sun: Add missing cooling device properties for CPUs Date: Fri, 1 Jun 2018 17:17:01 +0200 Message-ID: <20180601151701.sshwfdbflic6mybv@flea> References: <20180528084446.g24fphqqac2hi3rr@flea> <20180528105734.bkplm7tfaqsurdrn@vireshk-i7> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kyrkd2ck7f6qrool" Return-path: Content-Disposition: inline In-Reply-To: <20180528105734.bkplm7tfaqsurdrn@vireshk-i7> Sender: linux-kernel-owner@vger.kernel.org To: Viresh Kumar Cc: arm@kernel.org, Rob Herring , Mark Rutland , Chen-Yu Tsai , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org --kyrkd2ck7f6qrool Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, May 28, 2018 at 04:27:34PM +0530, Viresh Kumar wrote: > On 28-05-18, 10:44, Maxime Ripard wrote: > > Hi, > >=20 > > On Fri, May 25, 2018 at 04:01:52PM +0530, Viresh Kumar wrote: > > > The cooling device properties, like "#cooling-cells" and > > > "dynamic-power-coefficient", should either be present for all the CPUs > > > of a cluster or none. If these are present only for a subset of CPUs = of > > > a cluster then things will start falling apart as soon as the CPUs are > > > brought online in a different order. For example, this will happen > > > because the operating system looks for such properties in the CPU node > > > it is trying to bring up, so that it can register a cooling device. > > >=20 > > > Add such missing properties. > > >=20 > > > Fix other missing properties (clocks, OPP, clock latency) as well to > > > make it all work. > > >=20 > > > Signed-off-by: Viresh Kumar > >=20 > > The prefix should be sunxi and not sun, but it looks good to me > > otherwise. > >=20 > > Let me know what your preferred merge method is. >=20 > Please pick it up directly and send it as part of your pull request. > Do you want me to resend or can you fix the $subject ? I just tried to apply it, and it failed. We have usually two different PR for the H3 SoCs and the others. Could you split the H3 in a separate patch (and fix the subject in the process?) Thanks! Maxime --=20 Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --kyrkd2ck7f6qrool Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlsRY2wACgkQ0rTAlCFN r3SrDA/+LL4BAKeV5gwtJH+GbspXsxJ5OqCeswBd20Cuw8XFn89xR/6p+BrYVvZP 24Hv2nd7mhVHW9DjtQ50Gugd6e2wiEk0FaxQPCPki3CViWwEqceWfKJvYzp9iLHT We5xrLzr0+WHuRN1ngC9RIO2M2FR6acEJEIPghb7MlQ1V+cgYjaADjTIm4HQa8Ox 2fkrrrZZmxmICw+eaC1ZTbtVIL49dT0w+J5PtoMtuZwjyxXPUc51nmuHR2YD2JPF QNXFJh12MeDTx5kex6b8FYr2j4EWp/lyjUG0UU4/FYqgCqxjqD8FI6aFNsBy0wVV Nv8Hxt17jYOggl/m/e+bmntQGwl1u/V5v7TSJ3IOp6QqRuX8w1fGUs1d6PQ+6Dfh 0Nj7YwmoypOcBygWR/h6gquDw+YIOceGeq65oVReRFIn8ExMSFY0zms/JyYUDl5u FjswzaJ3mR7n9ATlPvLdTIXHcNzbGLVRT8kjJdx/DGXSEoddCRdzGftlTt/+YXyD 0uG2396xwafRM+8g0PZeotuPJRO7hFi/U0bZmxuYH+ZDbY53o/yybciaSdyDo82L AqZEAy59RKGk5/ZGuVn2am8GognKw8Akbn4YXBHtxmgKt3uIm/POW8V52tUHXzxT QQvkdbME7Im3IoY1yPVoGWjk3/U0OpTMjQO6oOC4an6XAgEWwmU= =6pOi -----END PGP SIGNATURE----- --kyrkd2ck7f6qrool--