From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Simon Horman <horms@verge.net.au>,
Chris Paterson <chris.paterson2@renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
stable@vger.kernel.org,
Ben Hutchings <ben.hutchings@codethink.co.uk>
Subject: Re: [PATCH ] dmaengine: usb-dmac: fix endless loop in usb_dmac_chan_terminate_all()
Date: Sat, 2 Jun 2018 15:19:47 +0200 [thread overview]
Message-ID: <20180602131947.GG31493@kroah.com> (raw)
In-Reply-To: <1527756504-27041-1-git-send-email-biju.das@bp.renesas.com>
On Thu, May 31, 2018 at 09:48:24AM +0100, Biju Das wrote:
> From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> commit d9f5efade2cfd729138a7cafb46d01044da40f5e upstream
>
> This patch fixes an issue that list_for_each_entry() in
> usb_dmac_chan_terminate_all() is possible to cause endless loop because
> this will move own desc to the desc_freed. So, this driver should use
> list_for_each_entry_safe() instead of list_for_each_entry().
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> [biju: cherry-pick to 4.4]
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> ---
> Hello Greg,
>
> I have observed a CPU lock condition with USB DMAC driver on koelsch platform.
> This patch fixes the issue on 4.4 stable. It is reproducible with ethernet(RNDIS/ECM)
> gadget configuration.
Now applied, thanks.
greg k-h
next prev parent reply other threads:[~2018-06-02 13:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 8:48 [PATCH ] dmaengine: usb-dmac: fix endless loop in usb_dmac_chan_terminate_all() Biju Das
2018-06-02 13:19 ` Greg Kroah-Hartman [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-11-12 4:37 [PATCH] " Yoshihiro Shimoda
2015-11-16 3:58 ` Vinod Koul
2015-11-16 7:13 ` Yoshihiro Shimoda
2015-12-05 8:20 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180602131947.GG31493@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ben.hutchings@codethink.co.uk \
--cc=biju.das@bp.renesas.com \
--cc=chris.paterson2@renesas.com \
--cc=fabrizio.castro@bp.renesas.com \
--cc=horms@verge.net.au \
--cc=stable@vger.kernel.org \
--cc=vinod.koul@intel.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.