From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Sat, 2 Jun 2018 18:58:05 +0200 Subject: [Cluster-devel] [PATCH v6 2/9] iomap: Mark newly allocated buffer heads as new In-Reply-To: <20180602095717.31641-3-agruenba@redhat.com> References: <20180602095717.31641-1-agruenba@redhat.com> <20180602095717.31641-3-agruenba@redhat.com> Message-ID: <20180602165805.GA15847@lst.de> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit > case IOMAP_MAPPED: > - if (offset >= i_size_read(inode)) > + if ((iomap->flags & IOMAP_F_NEW) || offset >= i_size_read(inode)) Please split the line to stay withing 80 characters. Otherwise looks fine: Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:48004 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751417AbeFBQvU (ORCPT ); Sat, 2 Jun 2018 12:51:20 -0400 Date: Sat, 2 Jun 2018 18:58:05 +0200 From: Christoph Hellwig To: Andreas Gruenbacher Cc: cluster-devel@redhat.com, Christoph Hellwig , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v6 2/9] iomap: Mark newly allocated buffer heads as new Message-ID: <20180602165805.GA15847@lst.de> References: <20180602095717.31641-1-agruenba@redhat.com> <20180602095717.31641-3-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180602095717.31641-3-agruenba@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > case IOMAP_MAPPED: > - if (offset >= i_size_read(inode)) > + if ((iomap->flags & IOMAP_F_NEW) || offset >= i_size_read(inode)) Please split the line to stay withing 80 characters. Otherwise looks fine: Reviewed-by: Christoph Hellwig