Re: [PATCH] PCI: Check for PCIe downtraining conditions

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

On Thu 2018-05-31 10:05:33, Alexandru Gagniuc wrote:
> PCIe downtraining happens when both the device and PCIe port are
> capable of a larger bus width or higher speed than negotiated.
> Downtraining might be indicative of other problems in the system, and
> identifying this from userspace is neither intuitive, nor straigh
> forward.
> Instead, check for such conditions on device probe, and print an
> appropriate message.
> 

> +	if (dev_cur_width < max_link_width) {
> +		/* Lanes might not be routed, so use info instead of warn. */
> +		pci_info(dev, "PCIe downtrain: Port and device capable of x%d, but link running at x%d",
> +			 max_link_width, dev_cur_width);
> +	}

Would "warn" be right loglevel?
									Pavel
									
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]