All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] support/testing: fix python syntax
Date: Sun, 3 Jun 2018 09:11:57 +0200	[thread overview]
Message-ID: <20180603071157.GA23330@scaer> (raw)
In-Reply-To: <5b136d851dd0e_208c3fee360e65a052968@ultri5.mail>

Ricardo, All,

On 2018-06-03 01:24 -0300, Ricardo Martincoski spake thusly:
> On Sat, Jun 02, 2018 at 07:19 PM, Yann E. MORIN wrote:
> > We're about to switch to using the flake8 from the distro, and that one
> > uncovers two more issues that the previously used pip-provided one did
> > not catch:
> 
> See my comments to patch 4. What generates more warnings is the fact that we
> start using Python3 interpreter to call flake8.

Oh, so the interpreter for flake8 has an impact onhow it interprets the
code it scans. Weird...

> We can call this patch a step towards Python 3 support for the test infra.

Yeah, I like this idea! ;-]

> [snip]
> > ---
> >  support/testing/infra/__init__.py | 6 +++---
> >  support/testing/infra/basetest.py | 4 ++--
> >  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> By running one of below commands (after the others from .gitlab-ci.yml) I get:
> $ python3 -m flake8 --statistics --count $(cat files.processed)
> $ flake8 --statistics --count $(cat files.processed)
> 
> support/testing/infra/basetest.py:49:28: E999 SyntaxError: invalid syntax
> support/testing/infra/__init__.py:37:29: E999 SyntaxError: invalid syntax
> support/testing/run-tests:44:29: E999 SyntaxError: invalid syntax

Weird, I didn't have that last one here in the docker image... But
indeed, another case of print-is-a-function-now

> 3     E999 SyntaxError: invalid syntax
> 3
> 
> So it seems support/testing/run-tests also needs to be changed.

I'll do so when I respin the series. Thanks for the reviews! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2018-06-03  7:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-02 22:19 [Buildroot] [PATCH 0/4] support/docker: make the image more reproducible Yann E. MORIN
2018-06-02 22:19 ` [Buildroot] [PATCH 1/4] support/docker: run apt-get update and apt-get install in two RUNs Yann E. MORIN
2018-06-03  4:20   ` Ricardo Martincoski
2018-06-02 22:19 ` [Buildroot] [PATCH 2/4] support/docker: sort the list of installed packages Yann E. MORIN
2018-06-03  4:21   ` Ricardo Martincoski
2018-06-03  7:24     ` Yann E. MORIN
2018-06-02 22:19 ` [Buildroot] [PATCH 3/4] support/testing: fix python syntax Yann E. MORIN
2018-06-03  4:24   ` Ricardo Martincoski
2018-06-03  7:11     ` Yann E. MORIN [this message]
2018-06-02 22:19 ` [Buildroot] [PATCH 4/4] support/docker: use the distro-provided flake8 Yann E. MORIN
2018-06-03  4:50   ` Ricardo Martincoski
2018-06-03  7:36     ` Yann E. MORIN
2018-06-04  3:38       ` Ricardo Martincoski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180603071157.GA23330@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.