From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mikulas Patocka Date: Sun, 03 Jun 2018 14:40:55 +0000 Subject: [PATCH 02/21] udl-kms: change down_interruptible to down Message-Id: <20180603144219.723405624@twibright.com> List-Id: References: <20180603144053.875668929@twibright.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mikulas Patocka , Bartlomiej Zolnierkiewicz , Dave Airlie , Bernie Thompson , Ladislav Michl Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org If we leave urbs around, it causes not only leak, but also memory corruption. This patch fixes the function udl_free_urb_list, so that it always waits for all urbs that are in progress. Signed-off-by: Mikulas Patocka Cc: stable@vger.kernel.org --- drivers/gpu/drm/udl/udl_main.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) Index: linux-4.16.12/drivers/gpu/drm/udl/udl_main.c =================================--- linux-4.16.12.orig/drivers/gpu/drm/udl/udl_main.c 2018-05-31 10:23:42.000000000 +0200 +++ linux-4.16.12/drivers/gpu/drm/udl/udl_main.c 2018-05-31 10:28:11.000000000 +0200 @@ -170,18 +170,13 @@ static void udl_free_urb_list(struct drm struct list_head *node; struct urb_node *unode; struct urb *urb; - int ret; unsigned long flags; DRM_DEBUG("Waiting for completes and freeing all render urbs\n"); /* keep waiting and freeing, until we've got 'em all */ while (count--) { - - /* Getting interrupted means a leak, but ok at shutdown*/ - ret = down_interruptible(&udl->urbs.limit_sem); - if (ret) - break; + down(&udl->urbs.limit_sem); spin_lock_irqsave(&udl->urbs.lock, flags); From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mikulas Patocka Subject: [PATCH 02/21] udl-kms: change down_interruptible to down Date: Sun, 03 Jun 2018 16:40:55 +0200 Message-ID: <20180603144219.723405624@twibright.com> References: <20180603144053.875668929@twibright.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from leontynka.twibright.com (109-183-129-149.tmcz.cz [109.183.129.149]) by gabe.freedesktop.org (Postfix) with ESMTPS id 63BCA6E25F for ; Sun, 3 Jun 2018 15:18:48 +0000 (UTC) Content-Disposition: inline; filename=udlkms-down-interruptible.patch List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mikulas Patocka , Bartlomiej Zolnierkiewicz , Dave Airlie , Bernie Thompson , Ladislav Michl Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SWYgd2UgbGVhdmUgdXJicyBhcm91bmQsIGl0IGNhdXNlcyBub3Qgb25seSBsZWFrLCBidXQgYWxz byBtZW1vcnkKY29ycnVwdGlvbi4gVGhpcyBwYXRjaCBmaXhlcyB0aGUgZnVuY3Rpb24gdWRsX2Zy ZWVfdXJiX2xpc3QsIHNvIHRoYXQgaXQKYWx3YXlzIHdhaXRzIGZvciBhbGwgdXJicyB0aGF0IGFy ZSBpbiBwcm9ncmVzcy4KClNpZ25lZC1vZmYtYnk6IE1pa3VsYXMgUGF0b2NrYSA8bXBhdG9ja2FA cmVkaGF0LmNvbT4KQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcKCi0tLQogZHJpdmVycy9ncHUv ZHJtL3VkbC91ZGxfbWFpbi5jIHwgICAgNyArLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNl cnRpb24oKyksIDYgZGVsZXRpb25zKC0pCgpJbmRleDogbGludXgtNC4xNi4xMi9kcml2ZXJzL2dw dS9kcm0vdWRsL3VkbF9tYWluLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbGludXgtNC4xNi4xMi5vcmlnL2Ry aXZlcnMvZ3B1L2RybS91ZGwvdWRsX21haW4uYwkyMDE4LTA1LTMxIDEwOjIzOjQyLjAwMDAwMDAw MCArMDIwMAorKysgbGludXgtNC4xNi4xMi9kcml2ZXJzL2dwdS9kcm0vdWRsL3VkbF9tYWluLmMJ MjAxOC0wNS0zMSAxMDoyODoxMS4wMDAwMDAwMDAgKzAyMDAKQEAgLTE3MCwxOCArMTcwLDEzIEBA IHN0YXRpYyB2b2lkIHVkbF9mcmVlX3VyYl9saXN0KHN0cnVjdCBkcm0KIAlzdHJ1Y3QgbGlzdF9o ZWFkICpub2RlOwogCXN0cnVjdCB1cmJfbm9kZSAqdW5vZGU7CiAJc3RydWN0IHVyYiAqdXJiOwot CWludCByZXQ7CiAJdW5zaWduZWQgbG9uZyBmbGFnczsKIAogCURSTV9ERUJVRygiV2FpdGluZyBm b3IgY29tcGxldGVzIGFuZCBmcmVlaW5nIGFsbCByZW5kZXIgdXJic1xuIik7CiAKIAkvKiBrZWVw IHdhaXRpbmcgYW5kIGZyZWVpbmcsIHVudGlsIHdlJ3ZlIGdvdCAnZW0gYWxsICovCiAJd2hpbGUg KGNvdW50LS0pIHsKLQotCQkvKiBHZXR0aW5nIGludGVycnVwdGVkIG1lYW5zIGEgbGVhaywgYnV0 IG9rIGF0IHNodXRkb3duKi8KLQkJcmV0ID0gZG93bl9pbnRlcnJ1cHRpYmxlKCZ1ZGwtPnVyYnMu bGltaXRfc2VtKTsKLQkJaWYgKHJldCkKLQkJCWJyZWFrOworCQlkb3duKCZ1ZGwtPnVyYnMubGlt aXRfc2VtKTsKIAogCQlzcGluX2xvY2tfaXJxc2F2ZSgmdWRsLT51cmJzLmxvY2ssIGZsYWdzKTsK IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==