From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mikulas Patocka Date: Sun, 03 Jun 2018 14:40:57 +0000 Subject: [PATCH 04/21] udl-kms: fix crash due to uninitialized memory Message-Id: <20180603144220.475786254@twibright.com> List-Id: References: <20180603144053.875668929@twibright.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mikulas Patocka , Bartlomiej Zolnierkiewicz , Dave Airlie , Bernie Thompson , Ladislav Michl Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org We must use kzalloc when allocating the fb_deferred_io structure. Otherwise, the field first_io is undefined and it causes a crash. Signed-off-by: Mikulas Patocka Cc: stable@vger.kernel.org --- drivers/gpu/drm/udl/udl_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-4.16.12/drivers/gpu/drm/udl/udl_fb.c =================================--- linux-4.16.12.orig/drivers/gpu/drm/udl/udl_fb.c 2018-05-29 17:55:39.000000000 +0200 +++ linux-4.16.12/drivers/gpu/drm/udl/udl_fb.c 2018-05-29 17:55:39.000000000 +0200 @@ -221,7 +221,7 @@ static int udl_fb_open(struct fb_info *i struct fb_deferred_io *fbdefio; - fbdefio = kmalloc(sizeof(struct fb_deferred_io), GFP_KERNEL); + fbdefio = kzalloc(sizeof(struct fb_deferred_io), GFP_KERNEL); if (fbdefio) { fbdefio->delay = DL_DEFIO_WRITE_DELAY; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mikulas Patocka Subject: [PATCH 04/21] udl-kms: fix crash due to uninitialized memory Date: Sun, 03 Jun 2018 16:40:57 +0200 Message-ID: <20180603144220.475786254@twibright.com> References: <20180603144053.875668929@twibright.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from leontynka.twibright.com (109-183-129-149.tmcz.cz [109.183.129.149]) by gabe.freedesktop.org (Postfix) with ESMTPS id F42186E286 for ; Sun, 3 Jun 2018 15:19:12 +0000 (UTC) Content-Disposition: inline; filename=udlkms-defio-kzalloc.patch List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mikulas Patocka , Bartlomiej Zolnierkiewicz , Dave Airlie , Bernie Thompson , Ladislav Michl Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org V2UgbXVzdCB1c2Uga3phbGxvYyB3aGVuIGFsbG9jYXRpbmcgdGhlIGZiX2RlZmVycmVkX2lvIHN0 cnVjdHVyZS4KT3RoZXJ3aXNlLCB0aGUgZmllbGQgZmlyc3RfaW8gaXMgdW5kZWZpbmVkIGFuZCBp dCBjYXVzZXMgYSBjcmFzaC4KClNpZ25lZC1vZmYtYnk6IE1pa3VsYXMgUGF0b2NrYSA8bXBhdG9j a2FAcmVkaGF0LmNvbT4KQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcKCi0tLQogZHJpdmVycy9n cHUvZHJtL3VkbC91ZGxfZmIuYyB8ICAgIDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlv bigrKSwgMSBkZWxldGlvbigtKQoKSW5kZXg6IGxpbnV4LTQuMTYuMTIvZHJpdmVycy9ncHUvZHJt L3VkbC91ZGxfZmIuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBsaW51eC00LjE2LjEyLm9yaWcvZHJpdmVycy9n cHUvZHJtL3VkbC91ZGxfZmIuYwkyMDE4LTA1LTI5IDE3OjU1OjM5LjAwMDAwMDAwMCArMDIwMAor KysgbGludXgtNC4xNi4xMi9kcml2ZXJzL2dwdS9kcm0vdWRsL3VkbF9mYi5jCTIwMTgtMDUtMjkg MTc6NTU6MzkuMDAwMDAwMDAwICswMjAwCkBAIC0yMjEsNyArMjIxLDcgQEAgc3RhdGljIGludCB1 ZGxfZmJfb3BlbihzdHJ1Y3QgZmJfaW5mbyAqaQogCiAJCXN0cnVjdCBmYl9kZWZlcnJlZF9pbyAq ZmJkZWZpbzsKIAotCQlmYmRlZmlvID0ga21hbGxvYyhzaXplb2Yoc3RydWN0IGZiX2RlZmVycmVk X2lvKSwgR0ZQX0tFUk5FTCk7CisJCWZiZGVmaW8gPSBremFsbG9jKHNpemVvZihzdHJ1Y3QgZmJf ZGVmZXJyZWRfaW8pLCBHRlBfS0VSTkVMKTsKIAogCQlpZiAoZmJkZWZpbykgewogCQkJZmJkZWZp by0+ZGVsYXkgPSBETF9ERUZJT19XUklURV9ERUxBWTsKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=