From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mikulas Patocka Date: Sun, 03 Jun 2018 14:41:01 +0000 Subject: [PATCH 08/21] udl-kms: avoid prefetch Message-Id: <20180603144221.959741603@twibright.com> List-Id: References: <20180603144053.875668929@twibright.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mikulas Patocka , Bartlomiej Zolnierkiewicz , Dave Airlie , Bernie Thompson , Ladislav Michl Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Modern processors can detect linear memory accesses and prefetch data automatically, so there's no need to use prefetch. Signed-off-by: Mikulas Patocka --- drivers/gpu/drm/udl/udl_transfer.c | 7 ------- 1 file changed, 7 deletions(-) Index: linux-4.16.12/drivers/gpu/drm/udl/udl_transfer.c =================================--- linux-4.16.12.orig/drivers/gpu/drm/udl/udl_transfer.c 2018-05-31 14:48:12.000000000 +0200 +++ linux-4.16.12/drivers/gpu/drm/udl/udl_transfer.c 2018-05-31 14:48:12.000000000 +0200 @@ -13,7 +13,6 @@ #include #include #include -#include #include #include @@ -51,9 +50,6 @@ static int udl_trim_hline(const u8 *bbac int start = width; int end = width; - prefetch((void *) front); - prefetch((void *) back); - for (j = 0; j < width; j++) { if (back[j] != front[j]) { start = j; @@ -140,8 +136,6 @@ static void udl_compress_hline16( const u8 *cmd_pixel_start, *cmd_pixel_end = NULL; uint16_t pixel_val16; - prefetchw((void *) cmd); /* pull in one cache line at least */ - *cmd++ = 0xaf; *cmd++ = 0x6b; *cmd++ = (uint8_t) ((dev_addr >> 16) & 0xFF); @@ -158,7 +152,6 @@ static void udl_compress_hline16( (unsigned long)(pixel_end - pixel) >> log_bpp, (unsigned long)(cmd_buffer_end - 1 - cmd) / 2) << log_bpp); - prefetch_range((void *) pixel, cmd_pixel_end - pixel); pixel_val16 = get_pixel_val16(pixel, log_bpp); while (pixel < cmd_pixel_end) { From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mikulas Patocka Subject: [PATCH 08/21] udl-kms: avoid prefetch Date: Sun, 03 Jun 2018 16:41:01 +0200 Message-ID: <20180603144221.959741603@twibright.com> References: <20180603144053.875668929@twibright.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from leontynka.twibright.com (109-183-129-149.tmcz.cz [109.183.129.149]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7309389B12 for ; Sun, 3 Jun 2018 15:18:35 +0000 (UTC) Content-Disposition: inline; filename=udlkms-avoid-prefetch.patch List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mikulas Patocka , Bartlomiej Zolnierkiewicz , Dave Airlie , Bernie Thompson , Ladislav Michl Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org TW9kZXJuIHByb2Nlc3NvcnMgY2FuIGRldGVjdCBsaW5lYXIgbWVtb3J5IGFjY2Vzc2VzIGFuZCBw cmVmZXRjaCBkYXRhCmF1dG9tYXRpY2FsbHksIHNvIHRoZXJlJ3Mgbm8gbmVlZCB0byB1c2UgcHJl ZmV0Y2guCgpTaWduZWQtb2ZmLWJ5OiBNaWt1bGFzIFBhdG9ja2EgPG1wYXRvY2thQHJlZGhhdC5j b20+CgotLS0KIGRyaXZlcnMvZ3B1L2RybS91ZGwvdWRsX3RyYW5zZmVyLmMgfCAgICA3IC0tLS0t LS0KIDEgZmlsZSBjaGFuZ2VkLCA3IGRlbGV0aW9ucygtKQoKSW5kZXg6IGxpbnV4LTQuMTYuMTIv ZHJpdmVycy9ncHUvZHJtL3VkbC91ZGxfdHJhbnNmZXIuYwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBsaW51eC00 LjE2LjEyLm9yaWcvZHJpdmVycy9ncHUvZHJtL3VkbC91ZGxfdHJhbnNmZXIuYwkyMDE4LTA1LTMx IDE0OjQ4OjEyLjAwMDAwMDAwMCArMDIwMAorKysgbGludXgtNC4xNi4xMi9kcml2ZXJzL2dwdS9k cm0vdWRsL3VkbF90cmFuc2Zlci5jCTIwMTgtMDUtMzEgMTQ6NDg6MTIuMDAwMDAwMDAwICswMjAw CkBAIC0xMyw3ICsxMyw2IEBACiAjaW5jbHVkZSA8bGludXgvbW9kdWxlLmg+CiAjaW5jbHVkZSA8 bGludXgvc2xhYi5oPgogI2luY2x1ZGUgPGxpbnV4L2ZiLmg+Ci0jaW5jbHVkZSA8bGludXgvcHJl ZmV0Y2guaD4KICNpbmNsdWRlIDxhc20vdW5hbGlnbmVkLmg+CiAKICNpbmNsdWRlIDxkcm0vZHJt UC5oPgpAQCAtNTEsOSArNTAsNiBAQCBzdGF0aWMgaW50IHVkbF90cmltX2hsaW5lKGNvbnN0IHU4 ICpiYmFjCiAJaW50IHN0YXJ0ID0gd2lkdGg7CiAJaW50IGVuZCA9IHdpZHRoOwogCi0JcHJlZmV0 Y2goKHZvaWQgKikgZnJvbnQpOwotCXByZWZldGNoKCh2b2lkICopIGJhY2spOwotCiAJZm9yIChq ID0gMDsgaiA8IHdpZHRoOyBqKyspIHsKIAkJaWYgKGJhY2tbal0gIT0gZnJvbnRbal0pIHsKIAkJ CXN0YXJ0ID0gajsKQEAgLTE0MCw4ICsxMzYsNiBAQCBzdGF0aWMgdm9pZCB1ZGxfY29tcHJlc3Nf aGxpbmUxNigKIAkJY29uc3QgdTggKmNtZF9waXhlbF9zdGFydCwgKmNtZF9waXhlbF9lbmQgPSBO VUxMOwogCQl1aW50MTZfdCBwaXhlbF92YWwxNjsKIAotCQlwcmVmZXRjaHcoKHZvaWQgKikgY21k KTsgLyogcHVsbCBpbiBvbmUgY2FjaGUgbGluZSBhdCBsZWFzdCAqLwotCiAJCSpjbWQrKyA9IDB4 YWY7CiAJCSpjbWQrKyA9IDB4NmI7CiAJCSpjbWQrKyA9ICh1aW50OF90KSAoKGRldl9hZGRyID4+ IDE2KSAmIDB4RkYpOwpAQCAtMTU4LDcgKzE1Miw2IEBAIHN0YXRpYyB2b2lkIHVkbF9jb21wcmVz c19obGluZTE2KAogCQkJCQkodW5zaWduZWQgbG9uZykocGl4ZWxfZW5kIC0gcGl4ZWwpID4+IGxv Z19icHAsCiAJCQkJCSh1bnNpZ25lZCBsb25nKShjbWRfYnVmZmVyX2VuZCAtIDEgLSBjbWQpIC8g MikgPDwgbG9nX2JwcCk7CiAKLQkJcHJlZmV0Y2hfcmFuZ2UoKHZvaWQgKikgcGl4ZWwsIGNtZF9w aXhlbF9lbmQgLSBwaXhlbCk7CiAJCXBpeGVsX3ZhbDE2ID0gZ2V0X3BpeGVsX3ZhbDE2KHBpeGVs LCBsb2dfYnBwKTsKIAogCQl3aGlsZSAocGl4ZWwgPCBjbWRfcGl4ZWxfZW5kKSB7CgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK