From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mikulas Patocka Date: Sun, 03 Jun 2018 14:41:08 +0000 Subject: [PATCH 15/21] udlfb: set optimal write delay Message-Id: <20180603144224.393326799@twibright.com> List-Id: References: <20180603144053.875668929@twibright.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Mikulas Patocka , Bartlomiej Zolnierkiewicz , Dave Airlie , Bernie Thompson , Ladislav Michl Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org The default delay 5 jiffies is too much when the kernel is compiled with HZ0 - it results in jumpy cursor in Xwindow. In order to find out the optimal delay, I benchmarked the driver on 1280x720x30fps video. I found out that with HZ00, 10ms is acceptable, but with HZ%0 or HZ00, we need 4ms, so that the video is played without any frame skips. This patch changes the delay to this value. Signed-off-by: Mikulas Patocka Cc: stable@vger.kernel.org --- include/video/udlfb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-4.17-rc7/include/video/udlfb.h =================================--- linux-4.17-rc7.orig/include/video/udlfb.h 2018-06-03 13:17:37.000000000 +0200 +++ linux-4.17-rc7/include/video/udlfb.h 2018-06-03 13:17:37.000000000 +0200 @@ -88,7 +88,7 @@ struct dlfb_data { #define MIN_RAW_PIX_BYTES 2 #define MIN_RAW_CMD_BYTES (RAW_HEADER_BYTES + MIN_RAW_PIX_BYTES) -#define DL_DEFIO_WRITE_DELAY 5 /* fb_deferred_io.delay in jiffies */ +#define DL_DEFIO_WRITE_DELAY msecs_to_jiffies(HZ <= 300 ? 4 : 10) /* optimal value for 720p video */ #define DL_DEFIO_WRITE_DISABLE (HZ*60) /* "disable" with long delay */ /* remove these once align.h patch is taken into kernel */ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mikulas Patocka Subject: [PATCH 15/21] udlfb: set optimal write delay Date: Sun, 03 Jun 2018 16:41:08 +0200 Message-ID: <20180603144224.393326799@twibright.com> References: <20180603144053.875668929@twibright.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from leontynka.twibright.com (109-183-129-149.tmcz.cz [109.183.129.149]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3DBB96E296 for ; Sun, 3 Jun 2018 15:19:33 +0000 (UTC) Content-Disposition: inline; filename=udl-defio-delay.patch List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mikulas Patocka , Bartlomiej Zolnierkiewicz , Dave Airlie , Bernie Thompson , Ladislav Michl Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org VGhlIGRlZmF1bHQgZGVsYXkgNSBqaWZmaWVzIGlzIHRvbyBtdWNoIHdoZW4gdGhlIGtlcm5lbCBp cyBjb21waWxlZCB3aXRoCkhaPTEwMCAtIGl0IHJlc3VsdHMgaW4ganVtcHkgY3Vyc29yIGluIFh3 aW5kb3cuCgpJbiBvcmRlciB0byBmaW5kIG91dCB0aGUgb3B0aW1hbCBkZWxheSwgSSBiZW5jaG1h cmtlZCB0aGUgZHJpdmVyIG9uCjEyODB4NzIweDMwZnBzIHZpZGVvLiBJIGZvdW5kIG91dCB0aGF0 IHdpdGggSFo9MTAwMCwgMTBtcyBpcyBhY2NlcHRhYmxlLApidXQgd2l0aCBIWj0yNTAgb3IgSFo9 MzAwLCB3ZSBuZWVkIDRtcywgc28gdGhhdCB0aGUgdmlkZW8gaXMgcGxheWVkCndpdGhvdXQgYW55 IGZyYW1lIHNraXBzLgoKVGhpcyBwYXRjaCBjaGFuZ2VzIHRoZSBkZWxheSB0byB0aGlzIHZhbHVl LgoKU2lnbmVkLW9mZi1ieTogTWlrdWxhcyBQYXRvY2thIDxtcGF0b2NrYUByZWRoYXQuY29tPgpD Yzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwoKLS0tCiBpbmNsdWRlL3ZpZGVvL3VkbGZiLmggfCAg ICAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCklu ZGV4OiBsaW51eC00LjE3LXJjNy9pbmNsdWRlL3ZpZGVvL3VkbGZiLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g bGludXgtNC4xNy1yYzcub3JpZy9pbmNsdWRlL3ZpZGVvL3VkbGZiLmgJMjAxOC0wNi0wMyAxMzox NzozNy4wMDAwMDAwMDAgKzAyMDAKKysrIGxpbnV4LTQuMTctcmM3L2luY2x1ZGUvdmlkZW8vdWRs ZmIuaAkyMDE4LTA2LTAzIDEzOjE3OjM3LjAwMDAwMDAwMCArMDIwMApAQCAtODgsNyArODgsNyBA QCBzdHJ1Y3QgZGxmYl9kYXRhIHsKICNkZWZpbmUgTUlOX1JBV19QSVhfQllURVMJMgogI2RlZmlu ZSBNSU5fUkFXX0NNRF9CWVRFUwkoUkFXX0hFQURFUl9CWVRFUyArIE1JTl9SQVdfUElYX0JZVEVT KQogCi0jZGVmaW5lIERMX0RFRklPX1dSSVRFX0RFTEFZICAgIDUgLyogZmJfZGVmZXJyZWRfaW8u ZGVsYXkgaW4gamlmZmllcyAqLworI2RlZmluZSBETF9ERUZJT19XUklURV9ERUxBWSAgICBtc2Vj c190b19qaWZmaWVzKEhaIDw9IDMwMCA/IDQgOiAxMCkgLyogb3B0aW1hbCB2YWx1ZSBmb3IgNzIw cCB2aWRlbyAqLwogI2RlZmluZSBETF9ERUZJT19XUklURV9ESVNBQkxFICAoSFoqNjApIC8qICJk aXNhYmxlIiB3aXRoIGxvbmcgZGVsYXkgKi8KIAogLyogcmVtb3ZlIHRoZXNlIG9uY2UgYWxpZ24u aCBwYXRjaCBpcyB0YWtlbiBpbnRvIGtlcm5lbCAqLwoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg==