From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme: avoid hang on inaccessible paths
Date: Mon, 4 Jun 2018 08:37:53 +0200 [thread overview]
Message-ID: <20180604063753.GA20811@lst.de> (raw)
In-Reply-To: <20180604082455.6369788d@pentland.suse.de>
On Mon, Jun 04, 2018@08:24:55AM +0200, Hannes Reinecke wrote:
> On Thu, 31 May 2018 02:10:35 +0300
> Sagi Grimberg <sagi@grimberg.me> wrote:
>
> > > And I guess this where the real issue starts. We should not do
> > > block I/O under nvmf_dev_mutex.
> > >
> > > James has some work on asynchronous connects pending for FC, so I
> > > guess we could look into generalizing that and always exectute the
> > > real connect work in a different thread.
> >
> > I still need to ramp up on the ANA patches, but I'd prefer moving
> > create_ctrl outside of nvmf_dev_mutex instead of having it async.
>
> We'd need the async patches still, as they provide a way on how we can
> call nvme-cli directly from within udev rules.
> Without those patches nvme-cli might get stuck (as this issue neatly
> proves) and would block udev from processing events.
So just run nvme-cli in the background from udev. Or if udev really
is too stupid for that have an option to fork and run in the background
in nvme-cli itself..
next prev parent reply other threads:[~2018-06-04 6:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 11:16 [PATCH] nvme: avoid hang on inaccessible paths Hannes Reinecke
2018-05-30 12:12 ` Christoph Hellwig
2018-05-30 12:30 ` Hannes Reinecke
2018-05-30 12:54 ` Christoph Hellwig
2018-05-30 23:10 ` Sagi Grimberg
2018-06-04 6:24 ` Hannes Reinecke
2018-06-04 6:37 ` Christoph Hellwig [this message]
2018-06-04 12:17 ` Sagi Grimberg
2018-06-04 12:56 ` Christoph Hellwig
2018-06-06 19:02 ` Popuri, Sriram
2018-06-07 5:54 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180604063753.GA20811@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.