From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fPoDg-0001ky-Bp for ath10k@lists.infradead.org; Mon, 04 Jun 2018 12:04:18 +0000 Received: by mail-lf0-x242.google.com with SMTP id y72-v6so24768575lfd.2 for ; Mon, 04 Jun 2018 05:04:05 -0700 (PDT) Date: Mon, 4 Jun 2018 14:04:00 +0200 From: Niklas Cassel Subject: Re: [PATCH net-next] ath10k: make some functions static Message-ID: <20180604120400.GA6240@centauri.lan> References: <1527733994-149212-1-git-send-email-weiyongjun1@huawei.com> <87a7sazw0w.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87a7sazw0w.fsf@kamboji.qca.qualcomm.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: Govind Singh , kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, bjorn.andersson@linaro.org, Wei Yongjun On Mon, Jun 04, 2018 at 01:27:43PM +0300, Kalle Valo wrote: > Wei Yongjun writes: > > > Fixes the following sparse warnings: > > > > drivers/net/wireless/ath/ath10k/snoc.c:823:5: warning: > > symbol 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be static? > > drivers/net/wireless/ath/ath10k/snoc.c:871:6: warning: > > symbol 'ath10k_snoc_init_napi' was not declared. Should it be static? > > > > Signed-off-by: Wei Yongjun > > BTW this goes to my ath.git tree, not to net-next. > > I had missed these as I can't enable ATH10K_SNOC on x86 and hence I > don't test compile snoc.c at all. Bjorn&Govind, is there a way to solve > that? IIRC we had a similar problem with wcn36xx but I don't remember > anymore how it was fixed. > Perhaps something like: --- a/drivers/net/wireless/ath/ath10k/Kconfig +++ b/drivers/net/wireless/ath/ath10k/Kconfig @@ -42,7 +42,8 @@ config ATH10K_USB config ATH10K_SNOC tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)" - depends on ATH10K && ARCH_QCOM + depends on ATH10K + depends on ARCH_QCOM || COMPILE_TEST ---help--- This module adds support for integrated WCN3990 chip connected to system NOC(SNOC). Currently work in progress and will not Regards, Niklas > -- > Kalle Valo > > _______________________________________________ > ath10k mailing list > ath10k@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/ath10k _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 From: Niklas Cassel Date: Mon, 04 Jun 2018 12:04:00 +0000 Subject: Re: [PATCH net-next] ath10k: make some functions static Message-Id: <20180604120400.GA6240@centauri.lan> List-Id: References: <1527733994-149212-1-git-send-email-weiyongjun1@huawei.com> <87a7sazw0w.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87a7sazw0w.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kalle Valo Cc: Govind Singh , kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, bjorn.andersson@linaro.org, Wei Yongjun On Mon, Jun 04, 2018 at 01:27:43PM +0300, Kalle Valo wrote: > Wei Yongjun writes: > > > Fixes the following sparse warnings: > > > > drivers/net/wireless/ath/ath10k/snoc.c:823:5: warning: > > symbol 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be static? > > drivers/net/wireless/ath/ath10k/snoc.c:871:6: warning: > > symbol 'ath10k_snoc_init_napi' was not declared. Should it be static? > > > > Signed-off-by: Wei Yongjun > > BTW this goes to my ath.git tree, not to net-next. > > I had missed these as I can't enable ATH10K_SNOC on x86 and hence I > don't test compile snoc.c at all. Bjorn&Govind, is there a way to solve > that? IIRC we had a similar problem with wcn36xx but I don't remember > anymore how it was fixed. > Perhaps something like: --- a/drivers/net/wireless/ath/ath10k/Kconfig +++ b/drivers/net/wireless/ath/ath10k/Kconfig @@ -42,7 +42,8 @@ config ATH10K_USB config ATH10K_SNOC tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)" - depends on ATH10K && ARCH_QCOM + depends on ATH10K + depends on ARCH_QCOM || COMPILE_TEST ---help--- This module adds support for integrated WCN3990 chip connected to system NOC(SNOC). Currently work in progress and will not Regards, Niklas > -- > Kalle Valo > > _______________________________________________ > ath10k mailing list > ath10k@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-lf0-f68.google.com ([209.85.215.68]:33924 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751354AbeFDMEF (ORCPT ); Mon, 4 Jun 2018 08:04:05 -0400 Received: by mail-lf0-f68.google.com with SMTP id o9-v6so24779038lfk.1 for ; Mon, 04 Jun 2018 05:04:04 -0700 (PDT) Date: Mon, 4 Jun 2018 14:04:00 +0200 From: Niklas Cassel To: Kalle Valo Cc: Wei Yongjun , kernel-janitors@vger.kernel.org, Govind Singh , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, bjorn.andersson@linaro.org Subject: Re: [PATCH net-next] ath10k: make some functions static Message-ID: <20180604120400.GA6240@centauri.lan> (sfid-20180604_140408_855158_40B34C3A) References: <1527733994-149212-1-git-send-email-weiyongjun1@huawei.com> <87a7sazw0w.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <87a7sazw0w.fsf@kamboji.qca.qualcomm.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Jun 04, 2018 at 01:27:43PM +0300, Kalle Valo wrote: > Wei Yongjun writes: > > > Fixes the following sparse warnings: > > > > drivers/net/wireless/ath/ath10k/snoc.c:823:5: warning: > > symbol 'ath10k_snoc_get_ce_id_from_irq' was not declared. Should it be static? > > drivers/net/wireless/ath/ath10k/snoc.c:871:6: warning: > > symbol 'ath10k_snoc_init_napi' was not declared. Should it be static? > > > > Signed-off-by: Wei Yongjun > > BTW this goes to my ath.git tree, not to net-next. > > I had missed these as I can't enable ATH10K_SNOC on x86 and hence I > don't test compile snoc.c at all. Bjorn&Govind, is there a way to solve > that? IIRC we had a similar problem with wcn36xx but I don't remember > anymore how it was fixed. > Perhaps something like: --- a/drivers/net/wireless/ath/ath10k/Kconfig +++ b/drivers/net/wireless/ath/ath10k/Kconfig @@ -42,7 +42,8 @@ config ATH10K_USB config ATH10K_SNOC tristate "Qualcomm ath10k SNOC support (EXPERIMENTAL)" - depends on ATH10K && ARCH_QCOM + depends on ATH10K + depends on ARCH_QCOM || COMPILE_TEST ---help--- This module adds support for integrated WCN3990 chip connected to system NOC(SNOC). Currently work in progress and will not Regards, Niklas > -- > Kalle Valo > > _______________________________________________ > ath10k mailing list > ath10k@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/ath10k