From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:40016 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753040AbeFDM02 (ORCPT ); Mon, 4 Jun 2018 08:26:28 -0400 Received: by mail-wm0-f66.google.com with SMTP id n5-v6so2538579wmc.5 for ; Mon, 04 Jun 2018 05:26:27 -0700 (PDT) Date: Mon, 4 Jun 2018 13:26:24 +0100 From: Lee Jones To: Marek Vasut Cc: linux-kernel@vger.kernel.org, Marek Vasut , Geert Uytterhoeven , Mark Brown , Steve Twiss , Wolfram Sang , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v3 02/10] mfd: da9063: Use REGMAP_IRQ_REG Message-ID: <20180604122624.GB21163@dell> References: <20180602101155.26375-1-marek.vasut+renesas@gmail.com> <20180602101155.26375-2-marek.vasut+renesas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180602101155.26375-2-marek.vasut+renesas@gmail.com> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Sat, 02 Jun 2018, Marek Vasut wrote: > Convert the regmap_irq table to use REGMAP_IRQ_REG(). > > Signed-off-by: Marek Vasut > Cc: Geert Uytterhoeven > Cc: Lee Jones > Cc: Mark Brown > Cc: Steve Twiss > Cc: Wolfram Sang > Cc: linux-renesas-soc@vger.kernel.org > --- > V3: New patch > Note: A sed oneliner was used: > sed -i "/\[DA9063_IRQ_/ {N;N;N;s/\n//g;s/.*\[\(DA9063_IRQ_[^]]\+\)].*reg_offset = \([^,]\+\),.* = \([^,]\+\),.*/\tREGMAP_IRQ_REG(\1, \2, \3),/}" drivers/mfd/da9063-irq.c > --- > drivers/mfd/da9063-irq.c | 145 ++++++++++------------------------------------- > 1 file changed, 29 insertions(+), 116 deletions(-) > > diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c > index 207bbfe55449..5b406ecfc14a 100644 > --- a/drivers/mfd/da9063-irq.c > +++ b/drivers/mfd/da9063-irq.c > @@ -28,125 +28,38 @@ > > static const struct regmap_irq da9063_irqs[] = { > /* DA9063 event A register */ > - [DA9063_IRQ_ONKEY] = { > - .reg_offset = DA9063_REG_EVENT_A_OFFSET, > - .mask = DA9063_M_ONKEY, > - }, > - [DA9063_IRQ_ALARM] = { > - .reg_offset = DA9063_REG_EVENT_A_OFFSET, > - .mask = DA9063_M_ALARM, > - }, > - [DA9063_IRQ_TICK] = { > - .reg_offset = DA9063_REG_EVENT_A_OFFSET, > - .mask = DA9063_M_TICK, > - }, > - [DA9063_IRQ_ADC_RDY] = { > - .reg_offset = DA9063_REG_EVENT_A_OFFSET, > - .mask = DA9063_M_ADC_RDY, > - }, > - [DA9063_IRQ_SEQ_RDY] = { > - .reg_offset = DA9063_REG_EVENT_A_OFFSET, > - .mask = DA9063_M_SEQ_RDY, > - }, > + REGMAP_IRQ_REG(DA9063_IRQ_ONKEY, DA9063_REG_EVENT_A_OFFSET, DA9063_M_ONKEY), > + REGMAP_IRQ_REG(DA9063_IRQ_ALARM, DA9063_REG_EVENT_A_OFFSET, DA9063_M_ALARM), > + REGMAP_IRQ_REG(DA9063_IRQ_TICK, DA9063_REG_EVENT_A_OFFSET, DA9063_M_TICK), > + REGMAP_IRQ_REG(DA9063_IRQ_ADC_RDY, DA9063_REG_EVENT_A_OFFSET, DA9063_M_ADC_RDY), > + REGMAP_IRQ_REG(DA9063_IRQ_SEQ_RDY, DA9063_REG_EVENT_A_OFFSET, DA9063_M_SEQ_RDY), Nice, but I think checkpatch.pl would complain. Better to break after the first argument I think. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog