All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Disseldorp <ddiss@suse.de>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH] target: fix truncated PR-in ReadKeys response
Date: Mon, 04 Jun 2018 11:36:06 +0000	[thread overview]
Message-ID: <20180604133606.6a9fb71d@suse.de> (raw)
In-Reply-To: <20180531222054.32655-1-ddiss@suse.de>

On Mon, 4 Jun 2018 14:16:45 +0300, Maged Mokhtar wrote:

> This also fixes an issue in Windows server 2016 failover cluster with
> many client connections, the initial allocation length sent in cdb is
> 72 bytes which  limits it to 8 keys, with additional length not affected
> by truncation, it will retry with correct size.

Interesting coincidence :) I only ran into this while looking at the
spec for the enable_pr change. Can you confirm that this fixes Win 2016
PR behaviour with an iblock / ifile backstore? If so I'll respin the
patch with an extra note in the commit message.

Cheers, David

  parent reply	other threads:[~2018-06-04 11:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31 22:20 [PATCH] target: fix truncated PR-in ReadKeys response David Disseldorp
2018-06-01 19:27 ` Mike Christie
2018-06-04 11:16 ` Maged Mokhtar
2018-06-04 11:36 ` David Disseldorp [this message]
2018-06-04 19:42 ` Maged Mokhtar
2018-06-04 20:20 ` David Disseldorp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180604133606.6a9fb71d@suse.de \
    --to=ddiss@suse.de \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.