From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPoNm-0004N4-2w for qemu-devel@nongnu.org; Mon, 04 Jun 2018 08:14:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPoNi-0007AW-SH for qemu-devel@nongnu.org; Mon, 04 Jun 2018 08:14:42 -0400 Date: Mon, 4 Jun 2018 14:14:34 +0200 From: Cornelia Huck Message-ID: <20180604141434.508e2f55.cohuck@redhat.com> In-Reply-To: References: <20180525113708.29856-1-david@redhat.com> <20180525113708.29856-2-david@redhat.com> <20180604133853.7c0f7933.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 1/7] s390x/tod: factor out TOD into separate device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org, Richard Henderson , Alexander Graf , Christian Borntraeger , Thomas Huth , "Jason J . Herne" , "Collin L . Walling" On Mon, 4 Jun 2018 14:00:43 +0200 David Hildenbrand wrote: > On 04.06.2018 13:38, Cornelia Huck wrote: > > On Fri, 25 May 2018 13:37:02 +0200 > > David Hildenbrand wrote: > > > >> Let's treat this like a separate device. TCG will have to store the > >> actual state/time later on. > >> > >> Include cpu-qom.h in kvm_s390x.h (due to S390CPU) to compile tod-kvm.c. > > > > Can't you include it in tod-kvm.c instead? Why was it not needed before? > > Guess I can, kvm_s390x.h looks to me like the right place, as S390CPU is > used in there. > > All other users include "cpu.h" already, so it isn't needed. Hm, and for kvm_s390_irq, this file is using a forward declaration, which would likely be more awkward for this structure. Header dependencies are always fun :)