All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, Suman Anna <s-anna@ti.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	linux-kernel@vger.kernel.org, Ohad Ben-Cohen <ohad@wizery.com>,
	linux-remoteproc@vger.kernel.org,
	Jason Wang <jasowang@redhat.com>,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_ring: switch to dma_XX barriers for rpmsg
Date: Mon, 4 Jun 2018 13:16:37 -0700	[thread overview]
Message-ID: <20180604201637.GB9960@builder> (raw)
In-Reply-To: <524fb400-2325-f60b-7e03-15be01888afc@redhat.com>

On Thu 19 Apr 10:48 PDT 2018, Paolo Bonzini wrote:

> On 19/04/2018 19:46, Michael S. Tsirkin wrote:
> >> This should be okay, but I wonder if there should be a virtio_wmb(...)
> >> or an "if (weak_barriers) wmb()" before the "writel" in vm_notify
> >> (drivers/virtio/virtio_mmio.c).
> >>
> >> Thanks,
> >>
> >> Paolo
> > That one uses weak barriers AFAIK.
> > 
> > IIUC you mean rproc_virtio_notify.
> > 
> > I suspect it works because specific kick callbacks have a barrier internally.
> 
> Yes, that one.  At least keystone_rproc_kick doesn't seem to have a barrier.
> 

Afaict you're correct. My expectation is that the kick ensures write
ordering internally and if I read this correct keystone_rproc_kick()
results in a writel_relaxed() in the gpio driver.

@Suman, can you please have a look at this.

Thanks Paolo,
Bjorn

  parent reply	other threads:[~2018-06-04 20:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19 17:35 [PATCH] virtio_ring: switch to dma_XX barriers for rpmsg Michael S. Tsirkin
2018-04-19 17:39 ` Paolo Bonzini
2018-04-19 17:39   ` Paolo Bonzini
2018-04-19 17:46   ` Michael S. Tsirkin
2018-04-19 17:48     ` Paolo Bonzini
2018-04-19 18:10       ` Michael S. Tsirkin
2018-04-19 18:10       ` Michael S. Tsirkin
2018-05-30 14:10       ` Michael S. Tsirkin
2018-05-30 14:10       ` Michael S. Tsirkin
2018-06-04 20:16       ` Bjorn Andersson [this message]
2018-06-04 20:16       ` Bjorn Andersson
2018-04-19 17:48     ` Paolo Bonzini
2018-04-19 17:46   ` Michael S. Tsirkin
2018-04-20  3:04 ` Jason Wang
2018-04-20  3:04 ` Jason Wang
2018-06-04 20:02 ` Bjorn Andersson
2018-06-04 20:02 ` Bjorn Andersson
  -- strict thread matches above, loose matches on Subject: below --
2018-04-19 17:35 Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180604201637.GB9960@builder \
    --to=bjorn.andersson@linaro.org \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=ohad@wizery.com \
    --cc=pbonzini@redhat.com \
    --cc=s-anna@ti.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.