From: Ido Schimmel <idosch@idosch.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: dsahern@kernel.org, netdev@vger.kernel.org, idosch@mellanox.com,
jiri@mellanox.com, jakub.kicinski@netronome.com,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures?
Date: Tue, 5 Jun 2018 11:05:28 +0300 [thread overview]
Message-ID: <20180605080528.GA2034@splinter.mtl.com> (raw)
In-Reply-To: <20180605075230.GC2164@nanopsycho>
On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote:
> Tue, Jun 05, 2018 at 12:15:03AM CEST, dsahern@kernel.org wrote:
> > if (!mlxsw_sp_port->split) {
> > netdev_err(mlxsw_sp_port->dev, "Port wasn't split\n");
> >+ NL_SET_ERR_MSG_MOD(extack, "Port was not split");
>
> I wonder if we need the dmesg for these as well. Plus it is not the same
> (wasn't/was not) which is maybe confusing. Any objection against the
> original dmesg messages removal?
We had this discussion about three months ago and decided to keep the
existing messages:
https://marc.info/?l=linux-netdev&m=151982813309466&w=2
next prev parent reply other threads:[~2018-06-05 8:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 22:15 [PATCH net-next 0/3] devlink: Add extack messages for reload and port split/unsplit dsahern
2018-06-04 22:15 ` [PATCH net-next 1/3] devlink: Add extack to reload and port_{un,}split operations dsahern
2018-06-05 7:50 ` Jiri Pirko
2018-06-04 22:15 ` [PATCH net-next 2/3] netdevsim: Add extack error message for devlink reload dsahern
2018-06-04 22:47 ` Jakub Kicinski
2018-06-04 22:15 ` [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures dsahern
2018-06-05 5:56 ` Ido Schimmel
2018-06-05 7:52 ` [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures^[ Jiri Pirko
2018-06-05 8:05 ` Ido Schimmel [this message]
2018-06-05 8:18 ` [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures? Jiri Pirko
2018-06-05 14:24 ` David Miller
2018-06-05 14:58 ` David Ahern
2018-06-05 15:05 ` David Miller
2018-06-05 15:05 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605080528.GA2034@splinter.mtl.com \
--to=idosch@idosch.org \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.