From: Thierry Reding <thierry.reding@gmail.com>
To: Thomas Hebb <tommyhebb@gmail.com>
Cc: linux-arm-kernel@vger.kernel.org,
Antoine Tenart <antoine.tenart@free-electrons.com>,
sebastian.hesselbarth@gmail.com, jszhang@marvell.com,
"open list:PWM SUBSYSTEM" <linux-pwm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] pwm: berlin: Don't use broken prescaler values
Date: Tue, 5 Jun 2018 11:10:02 +0200 [thread overview]
Message-ID: <20180605091002.GB20649@ulmo> (raw)
In-Reply-To: <da60a97a0c6f754faa1f996334b3568ddb2f5ed0.1528137144.git.tommyhebb@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 853 bytes --]
On Mon, Jun 04, 2018 at 02:32:41PM -0400, Thomas Hebb wrote:
> Six of the eight prescaler values available for Berlin PWM are not true
> prescalers but rather internal shifts that throw away the high bits of
> TCNT. Currently, we attempt to use those high bits, leading to erratic
> behavior. Restrict the prescaler configurations we select to only the
> two that respect the full range of TCNT.
>
> Tested on BG2CD.
>
> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> ---
> drivers/pwm/pwm-berlin.c | 45 ++++++++++++++++++++++------------------
> 1 file changed, 25 insertions(+), 20 deletions(-)
Antoine, Jisheng,
can you guys review this patch? I'm personally on the fence about this,
even if we can technically do the shift in software, I don't necessarily
see a reason why we can't "offload" to the hardware.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-06-05 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 18:32 [PATCH RESEND] pwm: berlin: Don't use broken prescaler values Thomas Hebb
2018-06-04 18:32 ` Thomas Hebb
2018-06-05 9:10 ` Thierry Reding [this message]
2018-06-05 16:48 ` Tom Hebb
2018-06-06 9:44 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605091002.GB20649@ulmo \
--to=thierry.reding@gmail.com \
--cc=antoine.tenart@free-electrons.com \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tommyhebb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.