From: kys@linuxonhyperv.com
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
jasowang@redhat.com, sthemmin@microsoft.com,
Michael.H.Kelley@microsoft.com, vkuznets@redhat.com
Cc: Dexuan Cui <decui@microsoft.com>,
stable@vger.kernel.org, "K . Y . Srinivasan" <kys@microsoft.com>
Subject: [PATCH 4/8] Drivers: hv: vmbus: Fix the offer_in_progress in vmbus_process_offer()
Date: Tue, 5 Jun 2018 13:37:52 -0700 [thread overview]
Message-ID: <20180605203756.29809-4-kys@linuxonhyperv.com> (raw)
In-Reply-To: <20180605203756.29809-1-kys@linuxonhyperv.com>
From: Dexuan Cui <decui@microsoft.com>
I didn't really hit a real bug, but just happened to spot the bug:
we have decreased the counter at the beginning of vmbus_process_offer(),
so we mustn't decrease it again.
Fixes: 6f3d791f3006 ("Drivers: hv: vmbus: Fix rescind handling issues")
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Cc: stable@vger.kernel.org
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Stable <stable@vger.kernel.org> # 4.14 and above
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
drivers/hv/channel_mgmt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
index ecc2bd275a73..f3b551a50653 100644
--- a/drivers/hv/channel_mgmt.c
+++ b/drivers/hv/channel_mgmt.c
@@ -527,10 +527,8 @@ static void vmbus_process_offer(struct vmbus_channel *newchannel)
struct hv_device *dev
= newchannel->primary_channel->device_obj;
- if (vmbus_add_channel_kobj(dev, newchannel)) {
- atomic_dec(&vmbus_connection.offer_in_progress);
+ if (vmbus_add_channel_kobj(dev, newchannel))
goto err_free_chan;
- }
if (channel->sc_creation_callback != NULL)
channel->sc_creation_callback(newchannel);
--
2.17.1
next prev parent reply other threads:[~2018-06-05 20:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 20:35 [PATCH 0/8] Drivers: hv: Miscellaneous fixes/improvements kys
2018-06-05 20:37 ` [PATCH 1/8] use the new async probing feature for the hyperv drivers kys
2018-06-05 20:37 ` [PATCH 2/8] x86/hyperv: Add interrupt handler annotations kys
2018-06-05 20:37 ` [PATCH 3/8] Drivers: hv: vmbus: Add comments on ring buffer signaling kys
2018-06-05 20:37 ` kys [this message]
2018-06-05 20:37 ` [PATCH 5/8] Drivers: hv: vmbus: Remove x86 MSR refs in arch independent code kys
2018-06-05 20:37 ` [PATCH 6/8] Drivers: hv: vmbus: Make TLFS #define names architecture neutral kys
2018-06-05 20:37 ` [PATCH 7/8] tools: hv: update lsvmbus to be compatible with python3 kys
2018-06-05 20:37 ` [PATCH 8/8] Tools: hv: vss: fix loop device detection kys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180605203756.29809-4-kys@linuxonhyperv.com \
--to=kys@linuxonhyperv.com \
--cc=Michael.H.Kelley@microsoft.com \
--cc=apw@canonical.com \
--cc=decui@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=stable@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.