From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:36364 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752570AbeFGHHT (ORCPT ); Thu, 7 Jun 2018 03:07:19 -0400 Received: by mail-wm0-f66.google.com with SMTP id v131-v6so16626203wma.1 for ; Thu, 07 Jun 2018 00:07:19 -0700 (PDT) Date: Thu, 7 Jun 2018 08:07:16 +0100 From: Lee Jones To: Marek Vasut Cc: linux-kernel@vger.kernel.org, Marek Vasut , Geert Uytterhoeven , Mark Brown , Steve Twiss , Wolfram Sang , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v5 02/14] mfd: da9063: Replace mfd_add_devices with devm counterpart Message-ID: <20180607070715.GC22841@dell> References: <20180606100003.17067-1-marek.vasut+renesas@gmail.com> <20180606100003.17067-2-marek.vasut+renesas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180606100003.17067-2-marek.vasut+renesas@gmail.com> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Wed, 06 Jun 2018, Marek Vasut wrote: > Use devm_mfd_add_devices() instead of plain mfd_add_devices(), which > removes the need for da9063_device_exit() altogether and also for the > .remove callback in da9063-i2c.c . > > Signed-off-by: Marek Vasut > Cc: Geert Uytterhoeven > Cc: Lee Jones > Cc: Mark Brown > Cc: Steve Twiss > Cc: Wolfram Sang > Cc: linux-renesas-soc@vger.kernel.org > --- > V5: New patch > --- > drivers/mfd/da9063-core.c | 11 +++-------- > drivers/mfd/da9063-i2c.c | 10 ---------- > include/linux/mfd/da9063/core.h | 2 -- > 3 files changed, 3 insertions(+), 20 deletions(-) For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog