From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] nvme-core: fix nvme_setup_cmd trace call
Date: Thu, 7 Jun 2018 04:08:36 -0700 [thread overview]
Message-ID: <20180607110836.GA22473@infradead.org> (raw)
In-Reply-To: <20180607072112.pqqp4zvyc5imdoqh@linux-x5ow.site>
On Thu, Jun 07, 2018@09:21:12AM +0200, Johannes Thumshirn wrote:
> On Thu, Jun 07, 2018@02:35:01AM -0400, Chaitanya Kulkarni wrote:
> > This patch fixes the trace_nvme_setup_admin_cmd() call, now we use NULL
> > in place of ns->disk->disk_name when ns variable is NULL.
>
> Oops, good catch,
> Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>
There is no point in ever in the NULL argument to the admin cmd
tracer. I've dropped the original patch from nvme-4.18, let's redo it
properly for 4.19.
next prev parent reply other threads:[~2018-06-07 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 6:35 [PATCH] nvme-core: fix nvme_setup_cmd trace call Chaitanya Kulkarni
2018-06-07 7:21 ` Johannes Thumshirn
2018-06-07 11:08 ` Christoph Hellwig [this message]
2018-06-07 11:12 ` Johannes Thumshirn
2018-06-07 8:49 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607110836.GA22473@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.