All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Oleksandr Andrushchenko <andr2000@gmail.com>
Cc: xen-devel@lists.xenproject.org,
	Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH 2/3] xen/kbdif: Add unique input device identifier
Date: Thu, 7 Jun 2018 09:28:45 -0400	[thread overview]
Message-ID: <20180607132845.GA24186@char.us.oracle.com> (raw)
In-Reply-To: <20180523061923.2036-2-andr2000@gmail.com>

On Wed, May 23, 2018 at 09:19:22AM +0300, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> 
> If frontend is configured to expose multiple input device instances
> then backend may require a way to uniquely identify concrete input
> device within the frontend. This is useful for use-cases where
> virtual input device needs to be matched to physical input device.
> Add XenBus "unique-id" node parameter, so this sort of use-cases can
> be implemented.
> 
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
>  xen/include/public/io/kbdif.h | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/xen/include/public/io/kbdif.h b/xen/include/public/io/kbdif.h
> index a68da0f1a37f..45e4ff5b0a05 100644
> --- a/xen/include/public/io/kbdif.h
> +++ b/xen/include/public/io/kbdif.h
> @@ -82,6 +82,15 @@
>   *      for pointer devices should set this to 1. Raw (unscaled) values have
>   *      a range of [0, 0x7fff].
>   *
> + *-----------------------  Device Instance Parameters ------------------------
> + *
> + * unique-id
> + *      Values:         <uint32_t>

Wouldn't a string be easier? That way you can extend this in the future
to also have an UUID or so?

> + *
> + *      After device instance initialization it is assigned a unique ID
> + *      (within the front driver), so every instance of the frontend can be
> + *      identified by the backend by this ID.
> + *
>   *------------------------- Pointer Device Parameters ------------------------
>   *
>   * width
> @@ -204,6 +213,7 @@
>  #define XENKBD_FIELD_MT_WIDTH          "multi-touch-width"
>  #define XENKBD_FIELD_MT_HEIGHT         "multi-touch-height"
>  #define XENKBD_FIELD_MT_NUM_CONTACTS   "multi-touch-num-contacts"
> +#define XENKBD_FIELD_UNIQUE_ID         "unique-id"
>  
>  /* OBSOLETE, not recommended for use */
>  #define XENKBD_FIELD_RING_REF          "page-ref"
> -- 
> 2.17.0
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-06-07 13:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23  6:19 [PATCH 1/3] xen/kbdif: Move multi-touch device parameters to backend nodes Oleksandr Andrushchenko
2018-05-23  6:19 ` [PATCH 2/3] xen/kbdif: Add unique input device identifier Oleksandr Andrushchenko
2018-06-07 13:28   ` Konrad Rzeszutek Wilk [this message]
2018-06-07 13:40     ` Oleksandr Andrushchenko
2018-06-07 15:47       ` Konrad Rzeszutek Wilk
2018-06-08  5:26         ` Oleksandr Andrushchenko
2018-05-23  6:19 ` [PATCH 3/3] xen/displif: Add unique display connector identifier Oleksandr Andrushchenko
2018-06-07 13:29   ` Konrad Rzeszutek Wilk
2018-06-07 13:41     ` Oleksandr Andrushchenko
2018-06-07 13:29 ` [PATCH 1/3] xen/kbdif: Move multi-touch device parameters to backend nodes Konrad Rzeszutek Wilk
2018-06-07 14:00   ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180607132845.GA24186@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=andr2000@gmail.com \
    --cc=oleksandr_andrushchenko@epam.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.