From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1fQwBk-0000gX-2q for mharc-grub-devel@gnu.org; Thu, 07 Jun 2018 10:46:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQwBf-0000em-La for grub-devel@gnu.org; Thu, 07 Jun 2018 10:46:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQwBc-00080a-IA for grub-devel@gnu.org; Thu, 07 Jun 2018 10:46:51 -0400 Received: from smtp.eu.citrix.com ([185.25.65.24]:29769) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fQwBc-0007ze-6c for grub-devel@gnu.org; Thu, 07 Jun 2018 10:46:48 -0400 X-IronPort-AV: E=Sophos;i="5.49,486,1520899200"; d="scan'208";a="74308099" Date: Thu, 7 Jun 2018 16:46:37 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Daniel Kiper CC: , Subject: Re: [PATCH] multiboot2: clarify usage of the address tag Message-ID: <20180607144637.ux42gt4msgi2vdev@mac> References: <20180605095536.44938-1-roger.pau@citrix.com> <20180606172820.GW20016@olila.local.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180606172820.GW20016@olila.local.net-space.pl> User-Agent: NeoMutt/20180512 X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 185.25.65.24 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jun 2018 14:46:52 -0000 On Wed, Jun 06, 2018 at 07:28:20PM +0200, Daniel Kiper wrote: > On Tue, Jun 05, 2018 at 11:55:36AM +0200, Roger Pau Monne wrote: > > Add a note to spell out that if the address tag is not present the > > file should be loaded using the elf header. > > > > Signed-off-by: Roger Pau Monné > > --- > > Cc: Daniel Kiper > > Cc: xen-devel@lists.xenproject.org > > --- > > doc/multiboot.texi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/doc/multiboot.texi b/doc/multiboot.texi > > index 2e2d7e74a..196f9c17a 100644 > > --- a/doc/multiboot.texi > > +++ b/doc/multiboot.texi > > @@ -509,6 +509,12 @@ assumes that no bss segment is present. > > > > @end table > > > > +Note: This information does not need to be provided if the kernel > > +image is in elf format, but it must be provided if the image is in > > s/elf/@sc{elf}/ > > > +a.out format or in some other format. Compliant boot loaders must be > > +able to load images that are either in elf format or contain the > > Ditto. > > > +address tag embedded in the Multiboot header. > > s/Multiboot/Multiboot2/ > > I think that it is also worth mentioning that the address tag has > preference over relevant data provided in ELF header. > > Additionally, may I ask you to provide similar patch for Multiboot spec? > You can find it in multiboot branch. Please look for "The address fields > of Multiboot header" paragraph. Multiboot1 already has such paragraph in the "3.1.2 The magic fields of Multiboot header" section. Thanks, Roger.