All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/icl: Add warn about unsupported CDCLK rates
@ 2018-06-07 16:13 Imre Deak
  2018-06-07 16:46 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (6 more replies)
  0 siblings, 7 replies; 12+ messages in thread
From: Imre Deak @ 2018-06-07 16:13 UTC (permalink / raw)
  To: intel-gfx

While checking workarounds related to the CDCLK PLL, I noticed that the
DMC firmware bits for WA#1183 are missing for SKL. After that I
clarified with HW people that it's not needed on SKL, since it doesn't
support eDP1.4 which would be the only thing requiring the problematic
CDCLK clock rates. So in theory we shouldn't ever choose these
frequencies, but add an assert in any case for catching such cases and
for documentation.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/intel_cdclk.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_cdclk.c b/drivers/gpu/drm/i915/intel_cdclk.c
index 704ddb4d3ca7..71045c38e233 100644
--- a/drivers/gpu/drm/i915/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/intel_cdclk.c
@@ -2355,6 +2355,16 @@ static int skl_modeset_calc_cdclk(struct drm_atomic_state *state)
 	 */
 	cdclk = skl_calc_cdclk(min_cdclk, vco);
 
+	/*
+	 * The following CDCLK rates are unsupported on SKL. In theory this
+	 * should never happen since only the eDP1.4 2.16 and 4.32Gbps rates
+	 * require it, but eDP1.4 is not supported on SKL, see display
+	 * WA#1183.
+	 */
+	if (IS_SKYLAKE(to_i915(state->dev)) &&
+	    (cdclk == 308571 || cdclk == 617143))
+		DRM_WARN_ONCE("Unsupported CDCLK rate.\n");
+
 	intel_state->cdclk.logical.vco = vco;
 	intel_state->cdclk.logical.cdclk = cdclk;
 	intel_state->cdclk.logical.voltage_level =
-- 
2.13.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2018-06-11 12:58 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-07 16:13 [PATCH] drm/i915/icl: Add warn about unsupported CDCLK rates Imre Deak
2018-06-07 16:46 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-06-07 17:01 ` [PATCH] " Ville Syrjälä
2018-06-07 17:17   ` Imre Deak
2018-06-07 20:07 ` ✓ Fi.CI.IGT: success for " Patchwork
2018-06-08 14:00 ` [PATCH v2] drm/i915/skl: " Imre Deak
2018-06-08 14:36   ` Ville Syrjälä
2018-06-08 14:41   ` [PATCH v3] " Imre Deak
2018-06-08 14:47 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Add warn about unsupported CDCLK rates (rev2) Patchwork
2018-06-08 15:06 ` ✓ Fi.CI.BAT: success for drm/i915/icl: Add warn about unsupported CDCLK rates (rev3) Patchwork
2018-06-08 18:44 ` ✓ Fi.CI.IGT: " Patchwork
2018-06-11 12:57   ` Imre Deak

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.