Re: [RFC] testpmd: use RFC2544 reserved IP addresses

[Stephen Hemminger <stephen@networkplumber.org>]

On Thu, 7 Jun 2018 12:52:59 +0000
"Iremonger, Bernard" <bernard.iremonger@intel.com> wrote:

> Hi Stephen,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> > Sent: Wednesday, March 21, 2018 3:45 AM
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger <stephen@networkplumber.org>
> > Subject: [dpdk-dev] [RFC] testpmd: use RFC2544 reserved IP addresses
> > 
> > Change the transmit only side of testpmd to use the IP addresses that are
> > marked as reserved for benchmarking by RFC2544 192.18.0.0/27; rather than  
> 
> RFC2544 seems to use 198.18.0.0 and 198.19.0.0 ?

The 18 and 19 networks would be used when doing L3fwd type test.
The addresses this patch addresses are those used in the default case
for a transmit only type of test (on same subnet).

> 
> > the commonly used subnet 192.168.0.0/24 which is likely to used for
> > administrative interface.  
> 
> Typo in the commit message "to used" should be "to be used"

yes.

> 
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> >  app/test-pmd/txonly.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index
> > 1f08b6ed37a2..22785bdcbe44 100644
> > --- a/app/test-pmd/txonly.c
> > +++ b/app/test-pmd/txonly.c
> > @@ -43,8 +43,9 @@
> >  #define UDP_SRC_PORT 1024
> >  #define UDP_DST_PORT 1024
> > 
> > -#define IP_SRC_ADDR ((192U << 24) | (168 << 16) | (0 << 8) | 1) -#define
> > IP_DST_ADDR ((192U << 24) | (168 << 16) | (0 << 8) | 2)
> > +/* RFC 2544 reserved IP addresses for benchmarking */ #define
> > +IP_SRC_ADDR ((192U << 24) | (18 << 16) | (0 << 8) | 1) #define
> > +IP_DST_ADDR ((192U << 24) | (18 << 16) | (0 << 8) | 2)
> > 
> >  #define IP_DEFTTL  64   /* from RFC 1340. */
> >  #define IP_VERSION 0x40
> > --
> > 2.16.2  
> 
> From RFC 2544:
> "The single filter case should permit traffic from IP address  198.18.1.2 to IP address 198.19.65.2 and deny all other traffic."
> 
> Should the macros be as follows?
> #define IP_SRC_ADDR ((198U << 24) | (18 << 16) | (0 << 8) | 1)
> #define IP_DST_ADDR ((198U << 24) | (19 << 16) | (0 << 8) | 2)
> 
> Regards,
> 
> Bernard
>