From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.bootlin.com ([62.4.15.54]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fQwlZ-0003Wt-RN for linux-mtd@lists.infradead.org; Thu, 07 Jun 2018 15:23:59 +0000 Date: Thu, 7 Jun 2018 17:23:45 +0200 From: Miquel Raynal To: Boris Brezillon Cc: David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , linux-mtd@lists.infradead.org, Mark Brown , linux-spi@vger.kernel.org, Cyrille Pitchen , Vignesh R , Thomas Petazzoni Subject: Re: [RFC PATCH 2/2] mtd: m25p80: Use the SPI mem direct API to possibly improve performances Message-ID: <20180607172345.507e028e@xps13> In-Reply-To: <20180607171846.462e6639@bbrezillon> References: <20180601143603.4047-1-boris.brezillon@bootlin.com> <20180601143603.4047-3-boris.brezillon@bootlin.com> <20180607170824.6c32bfc3@xps13> <20180607171846.462e6639@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Boris, On Thu, 7 Jun 2018 17:18:46 +0200, Boris Brezillon wrote: > On Thu, 7 Jun 2018 17:08:24 +0200 > Miquel Raynal wrote: >=20 > > Hi Boris, > >=20 > > On Fri, 1 Jun 2018 16:36:03 +0200, Boris Brezillon > > wrote: > > =20 > > > Make use of the SPI mem direct mapping API. > > >=20 > > > Signed-off-by: Boris Brezillon > > > --- > > > drivers/mtd/devices/m25p80.c | 149 ++++++++++++++++++++++++++-------= ---------- > > > 1 file changed, 89 insertions(+), 60 deletions(-) > > >=20 > > > diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p8= 0.c > > > index 1dd5f0420b5a..285fc94118ae 100644 > > > --- a/drivers/mtd/devices/m25p80.c > > > +++ b/drivers/mtd/devices/m25p80.c > > > @@ -31,6 +31,10 @@ > > > struct m25p { > > > struct spi_mem *spimem; > > > struct spi_nor spi_nor; > > > + struct { > > > + struct spi_mem_dirmap_desc *write; > > > + struct spi_mem_dirmap_desc *read; > > > + } dirmap; > > > }; =20 > >=20 > > While reading this patch I was a bit confused with this naming. You > > refer these descriptors as 'flash->dirmap->read/write' which is > > confusing as this is not a function but a descriptor. Passing such > > variable to a function called spi_meme_dirmap_read/write() is also > > confusing IMHO (see below). > >=20 > > Would you mind renaming them with something like "read/write_desc"? =20 >=20 > Sure. How about rdesc and wdesc to keep the names short? >=20 Sure, it's just to avoid having descriptors named after actions . Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [RFC PATCH 2/2] mtd: m25p80: Use the SPI mem direct API to possibly improve performances Date: Thu, 7 Jun 2018 17:23:45 +0200 Message-ID: <20180607172345.507e028e@xps13> References: <20180601143603.4047-1-boris.brezillon@bootlin.com> <20180601143603.4047-3-boris.brezillon@bootlin.com> <20180607170824.6c32bfc3@xps13> <20180607171846.462e6639@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Vignesh R , Richard Weinberger , Cyrille Pitchen , linux-spi@vger.kernel.org, Marek Vasut , Mark Brown , linux-mtd@lists.infradead.org, Thomas Petazzoni , Brian Norris , David Woodhouse To: Boris Brezillon Return-path: In-Reply-To: <20180607171846.462e6639@bbrezillon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org SGkgQm9yaXMsCgpPbiBUaHUsIDcgSnVuIDIwMTggMTc6MTg6NDYgKzAyMDAsIEJvcmlzIEJyZXpp bGxvbgo8Ym9yaXMuYnJlemlsbG9uQGJvb3RsaW4uY29tPiB3cm90ZToKCj4gT24gVGh1LCA3IEp1 biAyMDE4IDE3OjA4OjI0ICswMjAwCj4gTWlxdWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290 bGluLmNvbT4gd3JvdGU6Cj4gCj4gPiBIaSBCb3JpcywKPiA+IAo+ID4gT24gRnJpLCAgMSBKdW4g MjAxOCAxNjozNjowMyArMDIwMCwgQm9yaXMgQnJlemlsbG9uCj4gPiA8Ym9yaXMuYnJlemlsbG9u QGJvb3RsaW4uY29tPiB3cm90ZToKPiA+ICAgCj4gPiA+IE1ha2UgdXNlIG9mIHRoZSBTUEkgbWVt IGRpcmVjdCBtYXBwaW5nIEFQSS4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IEJvcmlzIEJy ZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGJvb3RsaW4uY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRy aXZlcnMvbXRkL2RldmljZXMvbTI1cDgwLmMgfCAxNDkgKysrKysrKysrKysrKysrKysrKysrKysr KystLS0tLS0tLS0tLS0tLS0tLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDg5IGluc2VydGlvbnMo KyksIDYwIGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRk L2RldmljZXMvbTI1cDgwLmMgYi9kcml2ZXJzL210ZC9kZXZpY2VzL20yNXA4MC5jCj4gPiA+IGlu ZGV4IDFkZDVmMDQyMGI1YS4uMjg1ZmM5NDExOGFlIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJz L210ZC9kZXZpY2VzL20yNXA4MC5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvbXRkL2RldmljZXMvbTI1 cDgwLmMKPiA+ID4gQEAgLTMxLDYgKzMxLDEwIEBACj4gPiA+ICBzdHJ1Y3QgbTI1cCB7Cj4gPiA+ ICAJc3RydWN0IHNwaV9tZW0JCSpzcGltZW07Cj4gPiA+ICAJc3RydWN0IHNwaV9ub3IJCXNwaV9u b3I7Cj4gPiA+ICsJc3RydWN0IHsKPiA+ID4gKwkJc3RydWN0IHNwaV9tZW1fZGlybWFwX2Rlc2Mg KndyaXRlOwo+ID4gPiArCQlzdHJ1Y3Qgc3BpX21lbV9kaXJtYXBfZGVzYyAqcmVhZDsKPiA+ID4g Kwl9IGRpcm1hcDsKPiA+ID4gIH07ICAgIAo+ID4gCj4gPiBXaGlsZSByZWFkaW5nIHRoaXMgcGF0 Y2ggSSB3YXMgYSBiaXQgY29uZnVzZWQgd2l0aCB0aGlzIG5hbWluZy4gWW91Cj4gPiByZWZlciB0 aGVzZSBkZXNjcmlwdG9ycyBhcyAnZmxhc2gtPmRpcm1hcC0+cmVhZC93cml0ZScgd2hpY2ggaXMK PiA+IGNvbmZ1c2luZyBhcyB0aGlzIGlzIG5vdCBhIGZ1bmN0aW9uIGJ1dCBhIGRlc2NyaXB0b3Iu IFBhc3Npbmcgc3VjaAo+ID4gdmFyaWFibGUgdG8gYSBmdW5jdGlvbiBjYWxsZWQgc3BpX21lbWVf ZGlybWFwX3JlYWQvd3JpdGUoKSBpcyBhbHNvCj4gPiBjb25mdXNpbmcgSU1ITyAoc2VlIGJlbG93 KS4KPiA+IAo+ID4gV291bGQgeW91IG1pbmQgcmVuYW1pbmcgdGhlbSB3aXRoIHNvbWV0aGluZyBs aWtlICJyZWFkL3dyaXRlX2Rlc2MiPyAgCj4gCj4gU3VyZS4gSG93IGFib3V0IHJkZXNjIGFuZCB3 ZGVzYyB0byBrZWVwIHRoZSBuYW1lcyBzaG9ydD8KPiAKClN1cmUsIGl0J3MganVzdCB0byBhdm9p ZCBoYXZpbmcgZGVzY3JpcHRvcnMgbmFtZWQgYWZ0ZXIgYWN0aW9ucyAuCgpNaXF1w6hsCgoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg==