All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Max Asbock <amax@lenovo.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
	"tytso@mit.edu" <tytso@mit.edu>, Chris McDermott <lcm@lenovo.com>
Subject: Re: [External]  Re: panic at boot time with kernel >= 4.9.98 - uninitialized system_wq in early interrupt
Date: Thu, 7 Jun 2018 20:27:31 +0200	[thread overview]
Message-ID: <20180607182731.GA24167@kroah.com> (raw)
In-Reply-To: <B7F68D8965785B478837F01E8A57F6CE7707F1FE@APMAILMBX06.lenovo.com>

On Thu, Jun 07, 2018 at 05:54:56PM +0000, Max Asbock wrote:
> 
> ________________________________________
> From: Greg KH [greg@kroah.com]
> Sent: Thursday, June 07, 2018 1:37 AM
> To: Max Asbock
> Cc: stable@vger.kernel.org; tytso@mit.edu; Chris McDermott
> Subject: [External]  Re: panic at boot time with kernel >= 4.9.98 - uninitialized system_wq in early interrupt
> 
> > Ick :(
> 
> > I'm guessing you also see these problems on 4.17?  Can you test there to
> > be sure of that?
> 
> We haven't had a chance to test 4.17 on the system where this happens. I am suspecting this won't be a problem on 4.17 as workqueue init has been split up and there is now a workqueue_init_early() in start_kernel():
>     /*
>      * Allow workqueue creation and work item queueing/cancelling
>      * early.  Work item execution depends on kthreads and starts after
>      * workqueue_init().
>      */
>     workqueue_init_early();
> 
> So far we have only seen this with 4.9.x. Also, this only happens when lots of memory is installed (10TB). i am guessing the large memory size changes the timing of the initialization steps and brings out the problem.
> When we get access to the system again we can attempt to boot the latest main-line kernel to verify that the work_init_early indeed fixes the issue there.

Ugh, I forgot about the workqueue rewrite.

How about 4.14, does that work for you?  If so, just use that, you
shouldn't be using the 4.9 kernel tree on x86-based hardware unless you
are somehow forced to due to horrible closed source kernel drivers.  You
want and need the fixes and speedups that are on 4.14.y, it's a
measurable difference.

thanks,

greg k-h

      reply	other threads:[~2018-06-07 18:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-06 23:26 panic at boot time with kernel >= 4.9.98 - uninitialized system_wq in early interrupt Max Asbock
2018-06-07  8:37 ` Greg KH
2018-06-07 17:54   ` [External] " Max Asbock
2018-06-07 18:27     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180607182731.GA24167@kroah.com \
    --to=greg@kroah.com \
    --cc=amax@lenovo.com \
    --cc=lcm@lenovo.com \
    --cc=stable@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.