From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-4310-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id E44665818FAD for ; Fri, 8 Jun 2018 01:00:45 -0700 (PDT) Date: Fri, 8 Jun 2018 16:00:47 +0800 From: Tiwei Bie Message-ID: <20180608080046.GA4818@debian> References: <20180608065928.2456-1-tiwei.bie@intel.com> <20180608093617.3fc9b951.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180608093617.3fc9b951.cohuck@redhat.com> Subject: [virtio-dev] Re: [PATCH] content: enhance device requirements for feature bits To: Cornelia Huck Cc: mst@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, virtio-dev@lists.oasis-open.org, dan.daly@intel.com, cunming.liang@intel.com, zhihong.wang@intel.com List-ID: On Fri, Jun 08, 2018 at 09:36:17AM +0200, Cornelia Huck wrote: > On Fri, 8 Jun 2018 14:59:28 +0800 > Tiwei Bie wrote: > > > Suggested-by: Michael S. Tsirkin > > Signed-off-by: Tiwei Bie > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14 > > --- > > content.tex | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/content.tex b/content.tex > > index f996fad..8374d3f 100644 > > --- a/content.tex > > +++ b/content.tex > > @@ -125,6 +125,13 @@ which was not offered. The device SHOULD accept any valid subset > > of features the driver accepts, otherwise it MUST fail to set the > > FEATURES_OK \field{device status} bit when the driver writes it. > > > > +If a device has successfully negotiated a set of features > > +at least once (by setting the FEATURES_OK \field{device > > +status} bit when the driver writes it), then it SHOULD NOT > > Hm, it's the driver that sets FEATURES_OK, not the device. What about > "by succeeding to set"? Cool. It's much better! > > > +fail re-negotiation of the same set of features after a > > +device or system reset. Failure to do so would interfere > > +with the resuming from suspend and error recovery. > > s/the resuming/resuming/ Got it. Thank you for the review and suggestions! Best regards, Tiwei Bie > > > + > > \subsection{Legacy Interface: A Note on Feature > > Bits}\label{sec:Basic Facilities of a Virtio Device / Feature > > Bits / Legacy Interface: A Note on Feature Bits} > --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org