From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] ethdev: force offloading API rules
Date: Fri, 8 Jun 2018 13:02:14 -0700
Message-ID: <20180608130214.686c79e8@xeon-e3>
References: <20180531124431.13746-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org, Shahaf Shuler
 <shahafs@mellanox.com>, Wei Dai <wei.dai@intel.com>, Qi Zhang
 <qi.z.zhang@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com
 [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id 5E68C1CFFC
 for <dev@dpdk.org>; Fri,  8 Jun 2018 22:02:18 +0200 (CEST)
Received: by mail-pf0-f196.google.com with SMTP id a11-v6so7146500pff.8
 for <dev@dpdk.org>; Fri, 08 Jun 2018 13:02:18 -0700 (PDT)
In-Reply-To: <20180531124431.13746-1-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 31 May 2018 13:44:30 +0100
Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> The error path was disabled in previous release to let apps to be more
> flexible.
> 
> But this release they are enabled, applications have to obey offload API
> rules otherwise they will get errors from following APIs:
> rte_eth_dev_configure
> rte_eth_rx_queue_setup
> rte_eth_tx_queue_setup
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Rather than always returning -EINVAL, why not propagate error code that the driver
returns. This would allow driver to give a more detailed error return.

The problem with that is you probably need to do a review of each drivers
configure and setup routines to see what they return on error (if any).