From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH] phy: mapphone-mdm6600: Fix wrong enum used for status lines Date: Fri, 8 Jun 2018 16:50:55 +0200 Message-ID: <20180608145055.GA11958@amd> References: <20180531170538.32264-1-tony@atomide.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="a8Wt8u1KmwUX3Y2C" Return-path: Content-Disposition: inline In-Reply-To: <20180531170538.32264-1-tony@atomide.com> Sender: linux-kernel-owner@vger.kernel.org To: Tony Lindgren Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org List-Id: linux-omap@vger.kernel.org --a8Wt8u1KmwUX3Y2C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2018-05-31 10:05:38, Tony Lindgren wrote: > Kbuilt test robot reported: >=20 > drivers/phy/motorola/phy-mapphone-mdm6600.c:188:16: warning: is used > uninitialized in this function [-Wuninitialized] > val |=3D values[i] << i; > ~~~~~~^~~ >=20 > Looking at the phy_mdm6600_status() values does get initialized by > gpiod_get_array_value_cansleep(), but we are using wrong enum > in that function. Let's fix the use, both end up being three though > so urgent rush on this one AFAIK. >=20 > Fixes: 5d1ebbda0318 ("phy: mapphone-mdm6600: Add USB PHY driver for > MDM6600 on Droid 4") > Reported-by: kbuild test robot > Signed-off-by: Tony Lindgren Reviewed-by: Pavel Machek --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --a8Wt8u1KmwUX3Y2C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlsal88ACgkQMOfwapXb+vLzEgCgvqK8LCcStxYo3zTSqe09oCIz aV8An1r3vfthMGVK/1RhUuy7byaJ2pKb =uf1Q -----END PGP SIGNATURE----- --a8Wt8u1KmwUX3Y2C-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: phy: mapphone-mdm6600: Fix wrong enum used for status lines From: Pavel Machek Message-Id: <20180608145055.GA11958@amd> Date: Fri, 8 Jun 2018 16:50:55 +0200 To: Tony Lindgren Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org List-ID: T24gVGh1IDIwMTgtMDUtMzEgMTA6MDU6MzgsIFRvbnkgTGluZGdyZW4gd3JvdGU6Cj4gS2J1aWx0 IHRlc3Qgcm9ib3QgcmVwb3J0ZWQ6Cj4gCj4gZHJpdmVycy9waHkvbW90b3JvbGEvcGh5LW1hcHBo b25lLW1kbTY2MDAuYzoxODg6MTY6IHdhcm5pbmc6ICBpcyB1c2VkCj4gdW5pbml0aWFsaXplZCBp biB0aGlzIGZ1bmN0aW9uIFstV3VuaW5pdGlhbGl6ZWRdCj4gICAgICAgICB2YWwgfD0gdmFsdWVz W2ldIDw8IGk7Cj4gICAgICAgICAgICAgICAgfn5+fn5+Xn5+Cj4gCj4gTG9va2luZyBhdCB0aGUg cGh5X21kbTY2MDBfc3RhdHVzKCkgdmFsdWVzIGRvZXMgZ2V0IGluaXRpYWxpemVkIGJ5Cj4gZ3Bp b2RfZ2V0X2FycmF5X3ZhbHVlX2NhbnNsZWVwKCksIGJ1dCB3ZSBhcmUgdXNpbmcgd3JvbmcgZW51 bQo+IGluIHRoYXQgZnVuY3Rpb24uIExldCdzIGZpeCB0aGUgdXNlLCBib3RoIGVuZCB1cCBiZWlu ZyB0aHJlZSB0aG91Z2gKPiBzbyB1cmdlbnQgcnVzaCBvbiB0aGlzIG9uZSBBRkFJSy4KPiAKPiBG aXhlczogNWQxZWJiZGEwMzE4ICgicGh5OiBtYXBwaG9uZS1tZG02NjAwOiBBZGQgVVNCIFBIWSBk cml2ZXIgZm9yCj4gTURNNjYwMCBvbiBEcm9pZCA0IikKPiBSZXBvcnRlZC1ieToga2J1aWxkIHRl c3Qgcm9ib3QgPGxrcEBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogVG9ueSBMaW5kZ3JlbiA8 dG9ueUBhdG9taWRlLmNvbT4KClJldmlld2VkLWJ5OiBQYXZlbCBNYWNoZWsgPHBhdmVsQHVjdy5j ej4K