From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DFB01210F75D6 for ; Fri, 8 Jun 2018 10:41:15 -0700 (PDT) Date: Fri, 8 Jun 2018 11:41:14 -0600 From: Ross Zwisler Subject: Re: [Qemu-devel] [qemu PATCH 4/5] machine: fix some misspelled words Message-ID: <20180608174114.GA30678@linux.intel.com> References: <20180607223111.27792-1-ross.zwisler@linux.intel.com> <20180607223111.27792-4-ross.zwisler@linux.intel.com> <17f8856c-48d9-d112-cd7f-e1b3679d2f43@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <17f8856c-48d9-d112-cd7f-e1b3679d2f43@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Thomas Huth Cc: Eduardo Habkost , linux-nvdimm , "Michael S. Tsirkin" , Qemu Developers , Stefan Hajnoczi , Igor Mammedov List-ID: On Fri, Jun 08, 2018 at 07:38:17AM +0200, Thomas Huth wrote: > On 08.06.2018 00:31, Ross Zwisler wrote: > > Normally this might not be worth fixing, but several of these are strings > > which are displayed to users. > > > > Signed-off-by: Ross Zwisler > > --- > > hw/core/machine.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/hw/core/machine.c b/hw/core/machine.c > > index 617e5f8d75..a21269fa39 100644 > > --- a/hw/core/machine.c > > +++ b/hw/core/machine.c > > @@ -609,7 +609,7 @@ static void machine_class_init(ObjectClass *oc, void *data) > > machine_get_igd_gfx_passthru, machine_set_igd_gfx_passthru, > > &error_abort); > > object_class_property_set_description(oc, "igd-passthru", > > - "Set on/off to enable/disable igd passthrou", &error_abort); > > + "Set on/off to enable/disable igd passthru", &error_abort); > > Shouldn't that rather be "passthrough" instead? Either works, I think. "thru" and "passthru" are short informal versions of "through" and "passthrough", but both the long and short versions of both words are used all over the QEMU source. "passthrou" is clearly wrong. If the longer version is preferred in this case please feel free to fix up when you apply. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRLO6-0000qA-9t for qemu-devel@nongnu.org; Fri, 08 Jun 2018 13:41:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRLO1-0006nv-HW for qemu-devel@nongnu.org; Fri, 08 Jun 2018 13:41:22 -0400 Received: from mga02.intel.com ([134.134.136.20]:61309) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fRLO1-0006nQ-6m for qemu-devel@nongnu.org; Fri, 08 Jun 2018 13:41:17 -0400 Date: Fri, 8 Jun 2018 11:41:14 -0600 From: Ross Zwisler Message-ID: <20180608174114.GA30678@linux.intel.com> References: <20180607223111.27792-1-ross.zwisler@linux.intel.com> <20180607223111.27792-4-ross.zwisler@linux.intel.com> <17f8856c-48d9-d112-cd7f-e1b3679d2f43@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17f8856c-48d9-d112-cd7f-e1b3679d2f43@redhat.com> Subject: Re: [Qemu-devel] [qemu PATCH 4/5] machine: fix some misspelled words List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Ross Zwisler , "Michael S. Tsirkin" , Eduardo Habkost , linux-nvdimm , Qemu Developers , Stefan Hajnoczi , Igor Mammedov , Dan Williams On Fri, Jun 08, 2018 at 07:38:17AM +0200, Thomas Huth wrote: > On 08.06.2018 00:31, Ross Zwisler wrote: > > Normally this might not be worth fixing, but several of these are strings > > which are displayed to users. > > > > Signed-off-by: Ross Zwisler > > --- > > hw/core/machine.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/hw/core/machine.c b/hw/core/machine.c > > index 617e5f8d75..a21269fa39 100644 > > --- a/hw/core/machine.c > > +++ b/hw/core/machine.c > > @@ -609,7 +609,7 @@ static void machine_class_init(ObjectClass *oc, void *data) > > machine_get_igd_gfx_passthru, machine_set_igd_gfx_passthru, > > &error_abort); > > object_class_property_set_description(oc, "igd-passthru", > > - "Set on/off to enable/disable igd passthrou", &error_abort); > > + "Set on/off to enable/disable igd passthru", &error_abort); > > Shouldn't that rather be "passthrough" instead? Either works, I think. "thru" and "passthru" are short informal versions of "through" and "passthrough", but both the long and short versions of both words are used all over the QEMU source. "passthrou" is clearly wrong. If the longer version is preferred in this case please feel free to fix up when you apply.