From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 68A0E2115F52A for ; Fri, 8 Jun 2018 09:21:36 -0700 (PDT) Date: Fri, 8 Jun 2018 19:21:34 +0300 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch Message-ID: <20180608191941-mutt-send-email-mst@kernel.org> References: <20180607223111.27792-1-ross.zwisler@linux.intel.com> <20180607223111.27792-2-ross.zwisler@linux.intel.com> <20180608020724-mutt-send-email-mst@kernel.org> <5352d2fb-9244-78b0-4f4b-2818359a4425@redhat.com> <20180608153402.GA27156@linux.intel.com> <20180608185714-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Peter Maydell Cc: Thomas Huth , Eduardo Habkost , linux-nvdimm , Qemu Developers , Stefan Hajnoczi , Igor Mammedov List-ID: On Fri, Jun 08, 2018 at 05:14:09PM +0100, Peter Maydell wrote: > On 8 June 2018 at 16:59, Michael S. Tsirkin wrote: > > The expected value tests are a debugging aid. They do not catch bugs and > > aren't designed to. In particular the comparisons do not even run if > > IASL isn't installed. > > If they're not actually tests to catch bugs, maybe we shouldn't > be running them in "make check" ? > > thanks > -- PMM We are running tests to do basic things like verifying the checksum of the tables. Failure on these causes make check to fail. As long as we have the tables anyway, and assuming IASL is installed (which most people who do not work on ACPI would not have) we compare to the expected set, that is often helpful for debugging. -- MST _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRK8x-0005JR-SF for qemu-devel@nongnu.org; Fri, 08 Jun 2018 12:21:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRK8u-0002SD-Mc for qemu-devel@nongnu.org; Fri, 08 Jun 2018 12:21:39 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:57750 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fRK8u-0002S1-HE for qemu-devel@nongnu.org; Fri, 08 Jun 2018 12:21:36 -0400 Date: Fri, 8 Jun 2018 19:21:34 +0300 From: "Michael S. Tsirkin" Message-ID: <20180608191941-mutt-send-email-mst@kernel.org> References: <20180607223111.27792-1-ross.zwisler@linux.intel.com> <20180607223111.27792-2-ross.zwisler@linux.intel.com> <20180608020724-mutt-send-email-mst@kernel.org> <5352d2fb-9244-78b0-4f4b-2818359a4425@redhat.com> <20180608153402.GA27156@linux.intel.com> <20180608185714-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Ross Zwisler , Thomas Huth , Eduardo Habkost , linux-nvdimm , Qemu Developers , Stefan Hajnoczi , Igor Mammedov , Dan Williams On Fri, Jun 08, 2018 at 05:14:09PM +0100, Peter Maydell wrote: > On 8 June 2018 at 16:59, Michael S. Tsirkin wrote: > > The expected value tests are a debugging aid. They do not catch bugs and > > aren't designed to. In particular the comparisons do not even run if > > IASL isn't installed. > > If they're not actually tests to catch bugs, maybe we shouldn't > be running them in "make check" ? > > thanks > -- PMM We are running tests to do basic things like verifying the checksum of the tables. Failure on these causes make check to fail. As long as we have the tables anyway, and assuming IASL is installed (which most people who do not work on ACPI would not have) we compare to the expected set, that is often helpful for debugging. -- MST