From: Keith Busch <keith.busch@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
Oza Pawandeep <poza@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 09/13] PCI/AER: Move aer_irq() declaration to portdrv.h
Date: Fri, 8 Jun 2018 14:17:13 -0600 [thread overview]
Message-ID: <20180608201713.GA24554@localhost.localdomain> (raw)
In-Reply-To: <152848834128.11888.12263280185471104825.stgit@bhelgaas-glaptop.roam.corp.google.com>
On Fri, Jun 08, 2018 at 03:05:41PM -0500, Bjorn Helgaas wrote:
> The aer_irq() declaration is the only thing needed by aer_inject.c. Move
> it to portdrv.h so we eventually get rid of aerdrv.h completely. No
> functional change intended.
Nothing against what you're doing here, but it does seem odd that aer_irq
is required to be exported just for the error injection to directly call
it. I feel like aer-inject should route it through the irq subsystem,
like with generic_handle_irq. ?
next prev parent reply other threads:[~2018-06-08 20:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 20:04 [RFC PATCH v1 00/13] PCI/AER: Squash into one file Bjorn Helgaas
2018-06-08 20:04 ` [PATCH v1 01/13] PCI/AER: Remove forward declarations Bjorn Helgaas
2018-06-08 20:04 ` [PATCH v1 02/13] PCI/AER: Reorder code to group probe/remove stuff together Bjorn Helgaas
2018-06-08 20:05 ` [PATCH v1 03/13] PCI/AER: Squash aerdrv_core.c into aerdrv.c Bjorn Helgaas
2018-06-08 20:05 ` [PATCH v1 04/13] PCI/AER: Squash aerdrv_errprint.c " Bjorn Helgaas
2018-06-08 20:05 ` [PATCH v1 05/13] PCI/AER: Squash aerdrv_acpi.c " Bjorn Helgaas
2018-06-08 20:05 ` [PATCH v1 06/13] PCI/AER: Squash ecrc.c " Bjorn Helgaas
2018-06-08 20:05 ` [PATCH v1 07/13] PCI/AER: Remove duplicate pcie_port_bus_type declaration Bjorn Helgaas
2018-06-08 20:05 ` [PATCH v1 08/13] PCI/AER: Move pcie_aer_get_firmware_first() to portdrv.h Bjorn Helgaas
2018-06-08 20:05 ` [PATCH v1 09/13] PCI/AER: Move aer_irq() declaration " Bjorn Helgaas
2018-06-08 20:17 ` Keith Busch [this message]
2018-06-08 20:34 ` Bjorn Helgaas
2018-06-08 20:05 ` [PATCH v1 10/13] PCI/AER: Move private AER things to aerdrv.c Bjorn Helgaas
2018-06-08 20:05 ` [PATCH v1 11/13] PCI/AER: Squash Kconfig.debug into Kconfig Bjorn Helgaas
2018-06-08 20:05 ` [PATCH v1 12/13] PCI/AER: Hoist aerdrv.c, aer_inject.c up to drivers/pci/pcie/ Bjorn Helgaas
2018-06-08 20:06 ` [PATCH v1 13/13] PCI/AER: Use "PCI Express" consistently in Kconfig text Bjorn Helgaas
2018-06-08 20:23 ` [RFC PATCH v1 00/13] PCI/AER: Squash into one file Keith Busch
2018-06-11 13:26 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180608201713.GA24554@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=bp@alien8.de \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=poza@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.