From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] fs: allow extra arguments to common tarball extraction
Date: Sat, 9 Jun 2018 09:31:23 +0200 [thread overview]
Message-ID: <20180609073123.GA2535@scaer> (raw)
In-Reply-To: <216846375.2026283.1528506402383.JavaMail.zimbra@datacom.com.br>
Carlos, All,
On 2018-06-08 22:06 -0300, Carlos Santos spake thusly:
> > From: "Yann Morin" <yann.morin.1998@free.fr>
> > Why do you need to do so? You can use the 'rootfs' macro, as I already
> > explained, and for which I have already sent a patch to add it to the
> > manual:
> > https://patchwork.ozlabs.org/patch/926425/
> I've seen your patch and will review it as soon as possible.
OK, great. Thanks! :-)
[--SNIP--]
> >> I understand that this trick avoids changing fs/*/*.mk replacing each
> >> reference to TARGET_DIR by a ROOTFS_<FOO>_TARGET_DIR but it reduces
> >> the readability a lot. I'm compelled to restore it to how it was prior
> >> to commit 7e9870ce32d.
> >
> > But if you revert that, then TARGET_DIR points to the original target/
> > directory, which does *not* contain the completely-finalised content.
>
> I pass TARGET_DIR=$(ROOTFS_COMMON_TARGET_DIR) in the environment to
No, don't point to the common one, because that is not parallel-safe!
The whole change was made so that two filesystems could be build in
parallel. Ad=nd since some filesystems want to muck with the layout
(e.g. iso9660), that is not compatible with two filesystems building
simultaneously from the same directory.
At the very least, make TARGET_DIR=$(ROOTFS_$(ROOTFS)_TARGET_DIR) as
Arnout hinted previously.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-06-09 7:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-03 2:21 [Buildroot] [PATCH] fs: allow extra arguments to common tarball extraction Carlos Santos
2018-06-05 17:23 ` Yann E. MORIN
2018-06-06 12:46 ` Carlos Santos
2018-06-06 18:51 ` Yann E. MORIN
2018-06-07 21:03 ` Arnout Vandecappelle
2018-06-07 23:12 ` Carlos Santos
2018-06-08 7:48 ` Arnout Vandecappelle
2018-06-08 17:34 ` Yann E. MORIN
2018-06-08 19:58 ` Arnout Vandecappelle
2018-06-08 17:26 ` Yann E. MORIN
2018-06-09 1:06 ` Carlos Santos
2018-06-09 7:31 ` Yann E. MORIN [this message]
2018-06-08 17:19 ` Yann E. MORIN
2018-06-08 19:59 ` Arnout Vandecappelle
2018-06-08 21:06 ` Yann E. MORIN
2018-06-10 23:48 ` Carlos Santos
2018-06-09 0:58 ` Carlos Santos
2018-10-26 11:43 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180609073123.GA2535@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.