From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v4] NFC: pn533: don't send USB data off of the stack From: Greg Kroah-Hartman Message-Id: <20180609140139.GA28854@kroah.com> Date: Sat, 9 Jun 2018 16:01:39 +0200 To: Samuel Ortiz Cc: Arend van Spriel , Carlos Manuel Santos , Stephen Hemminger , linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org List-ID: T24gU2F0LCBKdW4gMDksIDIwMTggYXQgMTE6NTQ6MDFBTSArMDIwMCwgU2FtdWVsIE9ydGl6IHdy b3RlOgo+IEdyZWcsCj4gCj4gT24gU3VuLCBNYXkgMjAsIDIwMTggYXQgMDM6MTk6NDZQTSArMDIw MCwgR3JlZyBLcm9haC1IYXJ0bWFuIHdyb3RlOgo+ID4gSXQncyBhbWF6aW5nIHRoYXQgdGhpcyBk cml2ZXIgZXZlciB3b3JrZWQsIGJ1dCBub3cgdGhhdCB4ODYgZG9lc24ndAo+ID4gYWxsb3cgVVNC IGRhdGEgdG8gYmUgc2VudCBvZmYgb2YgdGhlIHN0YWNrLCBpdCByZWFsbHkgZG9lcyBub3Qgd29y ayBhdAo+ID4gYWxsLiAgRml4IHRoaXMgdXAgYnkgcHJvcGVybHkgYWxsb2NhdGluZyB0aGUgZGF0 YSBmb3IgdGhlIHNtYWxsCj4gPiAiY29tbWFuZHMiIHRoYXQgZ2V0IHNlbnQgdG8gdGhlIGRldmlj ZSBvZmYgb2YgdGhlIHN0YWNrLgo+ID4gCj4gPiBXZSBkbyB0aGlzIGZvciBvbmUgY29tbWFuZCBi eSBoYXZpbmcgYSB3aG9sZSB1cmIganVzdCBmb3IgYWNrIG1lc3NhZ2VzLAo+ID4gYXMgdGhleSBj YW4gYmUgc3VibWl0dGVkIGluIGludGVycnVwdCBjb250ZXh0LCBzbyB3ZSBjYW4gbm90IHVzZQo+ ID4gdXNiX2J1bGtfbXNnKCkuICBCdXQgdGhlIHBvd2Vyb24gY29tbWFuZCBjYW4gc2xlZXAgKGFu ZCBkb2VzKSwgc28gdXNlCj4gPiB1c2JfYnVsa19tc2coKSBmb3IgdGhhdCB0cmFuc2Zlci4KPiA+ IAo+ID4gUmVwb3J0ZWQtYnk6IENhcmxvcyBNYW51ZWwgU2FudG9zIDxjbW1wc2FudG9zQGdtYWls LmNvbT4KPiA+IENjOiBTYW11ZWwgT3J0aXogPHNhbWVvQGxpbnV4LmludGVsLmNvbT4KPiA+IENj OiBTdGVwaGVuIEhlbW1pbmdlciA8c3RlcGhlbkBuZXR3b3JrcGx1bWJlci5vcmc+Cj4gPiBDYzog c3RhYmxlIDxzdGFibGVAdmdlci5rZXJuZWwub3JnPgo+ID4gU2lnbmVkLW9mZi1ieTogR3JlZyBL cm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KPiA+IC0tLQo+ID4gdjQ6 IGRvbid0IHVzZSB1cmIgdHJhbnNmZXIgYnVmZmVyIGZsYWdzIGFzIHRoZSBtZW1vcnkgaXMgdGll ZCB0byB0aGUgdXJiCj4gPiAgICAgKHRoYW5rcyB0byBKb2hhbikgIE5vdyB3ZSBoYXZlIGEgbmV3 IHN0YXRpYyB1cmIsIGFuZCB3ZSB1c2UKPiA+ICAgICB1c2JfYnVsa19tc2coKSBmb3IgdGhlIG90 aGVyIG1lc3NhZ2UuCj4gPiB2MzogYWN0dWFsbHkgdXNlIHRoZSBjb3JyZWN0IGJ1ZmZlciAodGhh bmtzIHRvIEFyZW5kIHZhbiBTcHJpZWwpCj4gPiAgICAgdXNlIGttZW1kdXAgKHRoYW5rcyB0byBK b2hhbm5lcyBCZXJnIGFuZCBKdWxpYSBMYXdhbGwpCj4gPiB2Mjogc2V0IHRoZSB1cmIgZmxhZ3Mg Y29ycmVjdGx5Cj4gPiAKPiA+ICBkcml2ZXJzL25mYy9wbjUzMy91c2IuYyB8ICAgNDIgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQs IDMwIGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQo+IEkgY2FuIHRha2UgdGhhdCBvbmUg dGhyb3VnaCBuZmMtbmV4dCwgYW5kIHRoZSBmZXcgc3Vic2VxdWVudCBwYXRjaGVzCj4gZnJvbSBI YW5zIGFuZCBKdWxpYS4gUGxlYXNlIGxldCBtZSBrbm93IHdoYXQncyBtb3JlIGNvbnZlbmllbnQg Zm9yIHlvdS4KClRoaXMgcGF0Y2ggaXMgYWxyZWFkeSBpbiBMaW51cydzIHRyZWUsIGFsb25nIHdp dGggd2hhdGV2ZXIgYXBwbGllZCBmcm9tCkp1bGlhJ3MgcGF0Y2ggc2VyaWVzLiAgSGFucyBuZWVk cyB0byByZWJhc2UgYW5kIHJlc2VuZCBhbnl3YXksIHNvIGVpdGhlcgp0cmVlIGlzIGZpbmUgb25j ZSA0LjE4LXJjMSBpcyBvdXQuCgp0aGFua3MsCgpncmVnIGstaAotLS0KVG8gdW5zdWJzY3JpYmUg ZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4K dGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBt YWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5o dG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kernel.org ([198.145.29.99]:59220 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753062AbeFIOCD (ORCPT ); Sat, 9 Jun 2018 10:02:03 -0400 Date: Sat, 9 Jun 2018 16:01:39 +0200 From: Greg Kroah-Hartman To: Samuel Ortiz Cc: Arend van Spriel , Carlos Manuel Santos , Stephen Hemminger , linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v4] NFC: pn533: don't send USB data off of the stack Message-ID: <20180609140139.GA28854@kroah.com> (sfid-20180609_160206_985404_14B16EE2) References: <20180520131946.GA7325@kroah.com> <20180609095401.GB25115@caravaggio.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180609095401.GB25115@caravaggio.jf.intel.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, Jun 09, 2018 at 11:54:01AM +0200, Samuel Ortiz wrote: > Greg, > > On Sun, May 20, 2018 at 03:19:46PM +0200, Greg Kroah-Hartman wrote: > > It's amazing that this driver ever worked, but now that x86 doesn't > > allow USB data to be sent off of the stack, it really does not work at > > all. Fix this up by properly allocating the data for the small > > "commands" that get sent to the device off of the stack. > > > > We do this for one command by having a whole urb just for ack messages, > > as they can be submitted in interrupt context, so we can not use > > usb_bulk_msg(). But the poweron command can sleep (and does), so use > > usb_bulk_msg() for that transfer. > > > > Reported-by: Carlos Manuel Santos > > Cc: Samuel Ortiz > > Cc: Stephen Hemminger > > Cc: stable > > Signed-off-by: Greg Kroah-Hartman > > --- > > v4: don't use urb transfer buffer flags as the memory is tied to the urb > > (thanks to Johan) Now we have a new static urb, and we use > > usb_bulk_msg() for the other message. > > v3: actually use the correct buffer (thanks to Arend van Spriel) > > use kmemdup (thanks to Johannes Berg and Julia Lawall) > > v2: set the urb flags correctly > > > > drivers/nfc/pn533/usb.c | 42 ++++++++++++++++++++++++++++++------------ > > 1 file changed, 30 insertions(+), 12 deletions(-) > I can take that one through nfc-next, and the few subsequent patches > from Hans and Julia. Please let me know what's more convenient for you. This patch is already in Linus's tree, along with whatever applied from Julia's patch series. Hans needs to rebase and resend anyway, so either tree is fine once 4.18-rc1 is out. thanks, greg k-h