From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1fSCQ4-0006kV-Ht for mharc-qemu-trivial@gnu.org; Sun, 10 Jun 2018 22:18:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSCQ1-0006hf-I6 for qemu-trivial@nongnu.org; Sun, 10 Jun 2018 22:18:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSCQ0-0004NO-PA for qemu-trivial@nongnu.org; Sun, 10 Jun 2018 22:18:53 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36492 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fSCPu-0004Lf-R7; Sun, 10 Jun 2018 22:18:46 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F2BDD406E8A1; Mon, 11 Jun 2018 02:18:45 +0000 (UTC) Received: from redhat.com (ovpn-120-77.rdu2.redhat.com [10.10.120.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F88D10F1C09; Mon, 11 Jun 2018 02:18:43 +0000 (UTC) Date: Mon, 11 Jun 2018 05:18:43 +0300 From: "Michael S. Tsirkin" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: Thomas Huth , Stefan Weil , qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Igor Mammedov , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost Message-ID: <20180611051748-mutt-send-email-mst@kernel.org> References: <20180611011501.10235-1-f4bug@amsat.org> <20180611011501.10235-34-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180611011501.10235-34-f4bug@amsat.org> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Mon, 11 Jun 2018 02:18:46 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Mon, 11 Jun 2018 02:18:46 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mst@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-trivial] [PATCH v4 33/40] hw/i386: Use the IEC binary prefix definitions X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 02:18:54 -0000 On Sun, Jun 10, 2018 at 10:14:54PM -0300, Philippe Mathieu-Daud=E9 wrote: > @@ -1392,11 +1393,11 @@ void pc_memory_init(PCMachineState *pcms, > } > =20 > machine->device_memory->base =3D > - ROUND_UP(0x100000000ULL + pcms->above_4g_mem_size, 1ULL <<= 30); > + ROUND_UP(0x100000000ULL + pcms->above_4g_mem_size, GiB); > =20 For some reason, GiB got special treatment. Why not 1* GiB? From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSCPz-0006gJ-Te for qemu-devel@nongnu.org; Sun, 10 Jun 2018 22:18:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSCPu-0004Lo-Vr for qemu-devel@nongnu.org; Sun, 10 Jun 2018 22:18:51 -0400 Date: Mon, 11 Jun 2018 05:18:43 +0300 From: "Michael S. Tsirkin" Message-ID: <20180611051748-mutt-send-email-mst@kernel.org> References: <20180611011501.10235-1-f4bug@amsat.org> <20180611011501.10235-34-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180611011501.10235-34-f4bug@amsat.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 33/40] hw/i386: Use the IEC binary prefix definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: Thomas Huth , Stefan Weil , qemu-devel@nongnu.org, qemu-trivial@nongnu.org, Igor Mammedov , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost On Sun, Jun 10, 2018 at 10:14:54PM -0300, Philippe Mathieu-Daud=E9 wrote: > @@ -1392,11 +1393,11 @@ void pc_memory_init(PCMachineState *pcms, > } > =20 > machine->device_memory->base =3D > - ROUND_UP(0x100000000ULL + pcms->above_4g_mem_size, 1ULL <<= 30); > + ROUND_UP(0x100000000ULL + pcms->above_4g_mem_size, GiB); > =20 For some reason, GiB got special treatment. Why not 1* GiB?