From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1fSMLN-000068-J1 for mharc-qemu-trivial@gnu.org; Mon, 11 Jun 2018 08:54:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSCU0-0000sz-Ox for qemu-trivial@nongnu.org; Sun, 10 Jun 2018 22:23:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSCTz-0005z3-3w for qemu-trivial@nongnu.org; Sun, 10 Jun 2018 22:23:00 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35480 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fSCTV-0005hn-7V; Sun, 10 Jun 2018 22:22:29 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0631A4027CD3; Mon, 11 Jun 2018 02:22:28 +0000 (UTC) Received: from redhat.com (ovpn-120-77.rdu2.redhat.com [10.10.120.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id C21BF2166BB6; Mon, 11 Jun 2018 02:22:16 +0000 (UTC) Date: Mon, 11 Jun 2018 05:22:16 +0300 From: "Michael S. Tsirkin" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: Thomas Huth , Stefan Weil , Nikunj A Dadhania , qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, qemu-s390x@nongnu.org, qemu-trivial@nongnu.org, Fabien Chouteau , Alistair Francis , Aurelien Jarno , Anthony Perard , Christian Borntraeger , Marek Vasut , Sagar Karandikar , David Gibson , Antony Pavlov , Artyom Tarasenko , Andrzej Zaborowski , Beniamino Galvani , Peter Crosthwaite , Chris Wulff , Dmitry Fleytman , "Edgar E . Iglesias" , Igor Mitsyanko , Max Filippov , Magnus Damm , Marcel Apfelbaum , Subbaraya Sundeep , Alberto Garcia , Mark Cave-Ayland , Keith Busch , Stefano Stabellini , Peter Maydell , Stefan Berger , Bastian Koppelmann , Paul Burton , Yongbok Kim , Peter Chubb , Yuval Shaia , =?iso-8859-1?Q?Herv=E9?= Poussineau , Alex Williamson , Markus Armbruster , Cornelia Huck , David Hildenbrand , Eric Blake , Eduardo Habkost , Fam Zheng , Igor Mammedov , Jason Wang , Gerd Hoffmann , Kevin Wolf , Max Reitz , Paolo Bonzini , Michael Clark , Palmer Dabbelt , Jiri Slaby , Alexander Graf , Richard Henderson , Michael Walle , Jan Kiszka Message-ID: <20180611052040-mutt-send-email-mst@kernel.org> References: <20180611011501.10235-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180611011501.10235-1-f4bug@amsat.org> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 11 Jun 2018 02:22:28 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 11 Jun 2018 02:22:28 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mst@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 X-Mailman-Approved-At: Mon, 11 Jun 2018 08:54:43 -0400 Subject: Re: [Qemu-trivial] [PATCH v4 00/40] Use the IEC binary prefix definitions X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 02:23:02 -0000 On Sun, Jun 10, 2018 at 10:14:21PM -0300, Philippe Mathieu-Daud=E9 wrote: > Hi, >=20 > This series: >=20 > - split the byte-based definitions from "qemu/cutils.h" to "qemu/units.= h" > (this now triggers WARNING: 1 added file, does MAINTAINERS need updat= ing?) > - clean hw/ includes; > - replace different constants used for byte size with their correspondi= ng > IEC binary prefix definitions. >=20 > Since v3: > - use IEC binary prefix definitions (Stefan Weil) > - rebased > - added R-b tags It violates our coding style which requires KIB for macros. But strangely, I like how this looks anyway. So series Reviewed-by: Michael S. Tsirkin but I think you need to update the coding style explaining that there's an exception. > Since v2: > - use "qemu/units.h" instead of "qemu/cunits.h" (Daniel P. Berrang=E9) > - avoid rebuilding the world including "qemu/units.h" in "hw/hw.h" (Tho= mas Huth) > - more constant replaced >=20 > Since v1: > - corrected Xen mult -> div (Alan Robinson) > - tagged 'include "qemu/cunits.h" in "hw/hw.h" as RFC > - fixed mips_r4k 'params_size' (Thomas Huth) > - added command used to generate patch in each commit (Alistair Francis= ) > - use G_BYTE for the raspi3 machine > - added Reviewed-by tags >=20 > Regards, >=20 > Phil. >=20 > Philippe Mathieu-Daud=E9 (40): > include: Add IEC binary prefixes in "qemu/units.h" > vdi: Use definitions from "qemu/units.h" > x86/cpu: Use definitions from "qemu/units.h" > checkpatch: Recognize IEC binary prefix definitions > hw: Use IEC binary prefix definitions from "qemu/units.h" > hw: Directly use "qemu/units.h" instead of "qemu/cutils.h" > hw/ivshmem: Use the IEC binary prefix definitions > hw/ipack: Use the IEC binary prefix definitions > hw/scsi: Use the IEC binary prefix definitions > hw/smbios: Use the IEC binary prefix definitions > hw/xen: Use the IEC binary prefix definitions > hw/tpm: Use the IEC binary prefix definitions > hw/block: Use the IEC binary prefix definitions > hw/display: Use the IEC binary prefix definitions > hw/misc: Use the IEC binary prefix definitions > hw/riscv: Use the IEC binary prefix definitions > hw/m68k: Use the IEC binary prefix definitions > hw/sparc: Use the IEC binary prefix definitions > hw/s390x: Use the IEC binary prefix definitions > hw/hppa: Use the IEC binary prefix definitions > hw/xtensa: Use the IEC binary prefix definitions > hw/alpha: Use the IEC binary prefix definitions > hw/tricore: Use the IEC binary prefix definitions > hw/microblaze: Use the IEC binary prefix definitions > hw/nios2: Use the IEC binary prefix definitions > hw/cris: Use the IEC binary prefix definitions > hw/lm32: Use the IEC binary prefix definitions > hw/sh4: Use the IEC binary prefix definitions > hw/mips/r4k: Constify params_size > hw/mips: Use the IEC binary prefix definitions > hw/arm: Use the IEC binary prefix definitions > hw/ppc: Use the IEC binary prefix definitions > hw/i386: Use the IEC binary prefix definitions > hw/net: Use the IEC binary prefix definitions > hw/usb: Use the IEC binary prefix definitions > hw/sd: Use the IEC binary prefix definitions > hw/vfio: Use the IEC binary prefix definitions > hw/virtio: Use the IEC binary prefix definitions > hw/rdma: Use the IEC binary prefix definitions > cutils: Do not include "qemu/units.h" directly >=20 > hw/net/ne2000.h | 5 ++-- > hw/ppc/mac.h | 3 ++- > hw/rdma/vmw/pvrdma.h | 3 ++- > include/hw/acpi/tpm.h | 3 ++- > include/hw/arm/fsl-imx7.h | 5 ++-- > include/hw/arm/stm32f205_soc.h | 5 ++-- > include/hw/display/xlnx_dp.h | 5 ++-- > include/hw/i386/ich9.h | 3 ++- > include/hw/intc/mips_gic.h | 3 ++- > include/hw/mips/bios.h | 3 ++- > include/hw/net/allwinner_emac.h | 5 ++-- > include/hw/ppc/spapr.h | 5 ++-- > include/hw/virtio/virtio-net.h | 3 ++- > include/qemu/cutils.h | 7 ------ > include/qemu/units.h | 20 ++++++++++++++++ > block/vdi.c | 8 +++---- > hw/alpha/typhoon.c | 17 +++++++------- > hw/arm/bcm2835_peripherals.c | 3 ++- > hw/arm/boot.c | 7 +++--- > hw/arm/collie.c | 5 ++-- > hw/arm/digic_boards.c | 7 +++--- > hw/arm/exynos4_boards.c | 3 ++- > hw/arm/gumstix.c | 3 ++- > hw/arm/integratorcp.c | 3 ++- > hw/arm/mainstone.c | 3 ++- > hw/arm/msf2-soc.c | 6 ++--- > hw/arm/msf2-som.c | 8 +++---- > hw/arm/musicpal.c | 9 +++---- > hw/arm/omap_sx1.c | 11 +++++---- > hw/arm/raspi.c | 5 ++-- > hw/arm/smmu-common.c | 3 ++- > hw/arm/stellaris.c | 5 ++-- > hw/arm/versatilepb.c | 5 ++-- > hw/arm/vexpress.c | 7 +++--- > hw/arm/virt.c | 5 ++-- > hw/arm/xilinx_zynq.c | 7 +++--- > hw/block/m25p80.c | 5 ++-- > hw/block/nvme.c | 3 ++- > hw/block/tc58128.c | 3 ++- > hw/block/xen_disk.c | 5 ++-- > hw/core/loader-fit.c | 3 ++- > hw/core/machine.c | 4 ++-- > hw/cris/axis_dev88.c | 3 ++- > hw/display/bochs-display.c | 9 +++---- > hw/display/cirrus_vga.c | 10 ++++---- > hw/display/g364fb.c | 4 ++-- > hw/display/qxl.c | 28 ++++++++++------------ > hw/display/sm501.c | 16 ++++++------- > hw/display/vga-isa-mm.c | 5 ++-- > hw/display/vga.c | 5 ++-- > hw/display/virtio-gpu.c | 4 ++-- > hw/display/vmware_vga.c | 3 ++- > hw/display/xenfb.c | 3 ++- > hw/hppa/dino.c | 3 ++- > hw/hppa/machine.c | 12 +++++----- > hw/i386/acpi-build.c | 5 ++-- > hw/i386/pc.c | 19 ++++++++------- > hw/i386/pc_piix.c | 4 ++-- > hw/i386/pc_q35.c | 3 ++- > hw/i386/pc_sysfw.c | 9 +++---- > hw/i386/xen/xen-mapcache.c | 3 ++- > hw/intc/apic_common.c | 3 ++- > hw/ipack/tpci200.c | 5 ++-- > hw/lm32/lm32_boards.c | 13 +++++----- > hw/lm32/milkymist.c | 10 ++++---- > hw/m68k/mcf5208.c | 3 ++- > hw/microblaze/petalogix_ml605_mmu.c | 7 +++--- > hw/microblaze/petalogix_s3adsp1800_mmu.c | 7 +++--- > hw/mips/boston.c | 30 ++++++++++++------------ > hw/mips/mips_fulong2e.c | 7 +++--- > hw/mips/mips_malta.c | 23 ++++++++++-------- > hw/mips/mips_r4k.c | 15 ++++++------ > hw/misc/aspeed_sdmc.c | 9 +++---- > hw/misc/auxbus.c | 3 ++- > hw/misc/edu.c | 3 ++- > hw/misc/imx7_gpr.c | 3 ++- > hw/misc/ivshmem.c | 3 ++- > hw/misc/mips_itu.c | 3 ++- > hw/misc/omap_gpmc.c | 5 ++-- > hw/net/e1000e.c | 7 +++--- > hw/net/e1000x_common.c | 3 ++- > hw/net/eepro100.c | 3 +-- > hw/nios2/boot.c | 6 ++--- > hw/nvram/spapr_nvram.c | 10 ++++---- > hw/pci-host/designware.c | 3 ++- > hw/pci-host/gpex.c | 3 ++- > hw/pci-host/piix.c | 5 ++-- > hw/pci-host/prep.c | 3 ++- > hw/pci-host/q35.c | 17 +++++++------- > hw/pci-host/xilinx-pcie.c | 5 ++-- > hw/ppc/e500.c | 13 +++++----- > hw/ppc/e500plat.c | 3 ++- > hw/ppc/mac_newworld.c | 1 - > hw/ppc/mac_oldworld.c | 9 ++++--- > hw/ppc/pnv.c | 6 ++--- > hw/ppc/ppc405_boards.c | 9 +++---- > hw/ppc/ppc405_uc.c | 7 +++--- > hw/ppc/ppc440_bamboo.c | 6 +++-- > hw/ppc/ppc440_uc.c | 28 +++++++++++----------- > hw/ppc/ppc4xx_devs.c | 22 +++++++++-------- > hw/ppc/ppce500_spin.c | 3 ++- > hw/ppc/prep.c | 6 ++--- > hw/ppc/rs6000_mc.c | 13 +++++----- > hw/ppc/sam460ex.c | 20 +++++++++------- > hw/ppc/spapr.c | 12 +++++----- > hw/ppc/spapr_rtas.c | 2 +- > hw/ppc/virtex_ml507.c | 7 +++--- > hw/riscv/virt.c | 3 ++- > hw/s390x/s390-skeys.c | 3 ++- > hw/s390x/s390-stattrib.c | 3 ++- > hw/s390x/sclp.c | 4 ++-- > hw/scsi/scsi-disk.c | 9 +++---- > hw/sd/sd.c | 8 +++---- > hw/sd/sdhci.c | 6 ++--- > hw/sh4/r2d.c | 3 ++- > hw/smbios/smbios.c | 15 +++++------- > hw/sparc/leon3.c | 9 +++---- > hw/sparc/sun4m.c | 9 ++++--- > hw/sparc64/niagara.c | 3 ++- > hw/sparc64/sun4u.c | 4 ++-- > hw/ssi/aspeed_smc.c | 29 ++++++++++++----------- > hw/tricore/tricore_testboard.c | 13 +++++----- > hw/usb/ccid-card-passthru.c | 5 ++-- > hw/usb/combined-packet.c | 3 ++- > hw/usb/dev-smartcard-reader.c | 3 ++- > hw/usb/redirect.c | 3 ++- > hw/vfio/pci-quirks.c | 9 +++---- > hw/vfio/pci.c | 3 ++- > hw/xenpv/xen_domainbuild.c | 13 +++++----- > hw/xtensa/xtfpga.c | 5 ++-- > target/i386/cpu.c | 4 +--- > tests/test-cutils.c | 18 +++++++------- > tests/test-keyval.c | 6 ++--- > tests/test-qemu-opts.c | 7 +++--- > scripts/checkpatch.pl | 1 + > 135 files changed, 533 insertions(+), 431 deletions(-) > create mode 100644 include/qemu/units.h >=20 > --=20 > 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a5d:4301:0:0:0:0:0 with SMTP id h1-v6csp3515877wrq; Sun, 10 Jun 2018 19:22:46 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIWmjiWg1C+8Uo/ZZL6T064d6r8hdCC5DvGfn2cTmucBy/eYFNAm1l4c4jeT9DNsvYC6mZl X-Received: by 2002:a37:32cd:: with SMTP id y196-v6mr12928057qky.431.1528683766323; Sun, 10 Jun 2018 19:22:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528683766; cv=none; d=google.com; s=arc-20160816; b=nQ8qlS98nB8aSFOTvA7mIehh6T66y9Gxd2LENZnOJIUnmgYoUYuyL3BLQyDyZ/ksCq aST5aqOkbHh051CIOFaiVhWM+G+WOmrefZgG4Unvxtdpe3ReIj6U85EU4VTCLsELola4 bYUzH5g0XtOp4y1PVBs5ux1SVD6oXm4rdde0I1VdWoqhbJ7AzIw0ZIHMgHHB6ne/5thB piyaIEYOfezWYlNSTGwPZBlWRpsXHgSwBZKlvTomoJSBLxg62LUkZg2IxyUj7DpDQXCl 7p1ZWTuatRYuL3d7LKl2uV7WmqHMoDUyNISocOxf6Y9i7R6BnPptGOGAAl5Zog9TEYlg omMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:in-reply-to:content-disposition :mime-version:references:message-id:to:from:date :arc-authentication-results; bh=ElawmhkT+sFRxl0txMmD73UIh/CTfKYocghQji9VwTM=; b=qJvY8dD7HrhIjrfyl65i8QSEP+sJuWjWYkjdOvzpN4sXVsQWyAGps/1oWJF6xHDYPv +JnVxwShJFL64Zm4K85wWmfHUYThC1FZhLGI7rg0Yk/yg4kMzfPn4fA2qIcmLzKtcRKv 4pej5ESwku1fBBRjCBamuE/IljO1fF3do9h/jy2J93e32zth+QZRPTrY2NsHX9yPL8MQ SHmPOHpxqkER/hATefaIQdoIFua3ZeZrJ/UPxnu3irOZjMqY0PUEABctn0zPPugvxIGX UbrKDxRs7Mo+SDsmAcvTM21etYigyZ6/zMICrVtJPT/XtbkbWcoiRkth+hs/RwSXiFvp p/Wg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id i41-v6si918839qvd.67.2018.06.10.19.22.46 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 10 Jun 2018 19:22:46 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:46052 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSCTl-0000cX-Rc for alex.bennee@linaro.org; Sun, 10 Jun 2018 22:22:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSCTa-0000bJ-DT for qemu-arm@nongnu.org; Sun, 10 Jun 2018 22:22:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSCTV-0005hz-EA for qemu-arm@nongnu.org; Sun, 10 Jun 2018 22:22:34 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35480 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fSCTV-0005hn-7V; Sun, 10 Jun 2018 22:22:29 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0631A4027CD3; Mon, 11 Jun 2018 02:22:28 +0000 (UTC) Received: from redhat.com (ovpn-120-77.rdu2.redhat.com [10.10.120.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id C21BF2166BB6; Mon, 11 Jun 2018 02:22:16 +0000 (UTC) Date: Mon, 11 Jun 2018 05:22:16 +0300 From: "Michael S. Tsirkin" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Message-ID: <20180611052040-mutt-send-email-mst@kernel.org> References: <20180611011501.10235-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180611011501.10235-1-f4bug@amsat.org> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 11 Jun 2018 02:22:28 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Mon, 11 Jun 2018 02:22:28 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mst@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-arm] [PATCH v4 00/40] Use the IEC binary prefix definitions X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Dmitry Fleytman , Jan Kiszka , Sagar Karandikar , David Hildenbrand , Jason Wang , Palmer Dabbelt , Mark Cave-Ayland , qemu-devel@nongnu.org, Alexander Graf , Keith Busch , Max Filippov , Michael Clark , Gerd Hoffmann , Max Reitz , Yongbok Kim , Marek Vasut , Stefano Stabellini , Alberto Garcia , qemu-block@nongnu.org, Stefan Berger , qemu-trivial@nongnu.org, Eric Blake , Magnus Damm , Markus Armbruster , Michael Walle , Christian Borntraeger , =?iso-8859-1?Q?Herv=E9?= Poussineau , Antony Pavlov , Marcel Apfelbaum , Anthony Perard , Richard Henderson , Andrzej Zaborowski , Artyom Tarasenko , Thomas Huth , Fam Zheng , Eduardo Habkost , Nikunj A Dadhania , Stefan Weil , Alistair Francis , Fabien Chouteau , Beniamino Galvani , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Peter Chubb , Yuval Shaia , Paolo Bonzini , Jiri Slaby , David Gibson , Kevin Wolf , Igor Mitsyanko , Bastian Koppelmann , Chris Wulff , Alex Williamson , Subbaraya Sundeep , Paul Burton , qemu-ppc@nongnu.org, Cornelia Huck , Igor Mammedov , Aurelien Jarno Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: 9Jr50kWCk5i9 On Sun, Jun 10, 2018 at 10:14:21PM -0300, Philippe Mathieu-Daud=E9 wrote: > Hi, >=20 > This series: >=20 > - split the byte-based definitions from "qemu/cutils.h" to "qemu/units.= h" > (this now triggers WARNING: 1 added file, does MAINTAINERS need updat= ing?) > - clean hw/ includes; > - replace different constants used for byte size with their correspondi= ng > IEC binary prefix definitions. >=20 > Since v3: > - use IEC binary prefix definitions (Stefan Weil) > - rebased > - added R-b tags It violates our coding style which requires KIB for macros. But strangely, I like how this looks anyway. So series Reviewed-by: Michael S. Tsirkin but I think you need to update the coding style explaining that there's an exception. > Since v2: > - use "qemu/units.h" instead of "qemu/cunits.h" (Daniel P. Berrang=E9) > - avoid rebuilding the world including "qemu/units.h" in "hw/hw.h" (Tho= mas Huth) > - more constant replaced >=20 > Since v1: > - corrected Xen mult -> div (Alan Robinson) > - tagged 'include "qemu/cunits.h" in "hw/hw.h" as RFC > - fixed mips_r4k 'params_size' (Thomas Huth) > - added command used to generate patch in each commit (Alistair Francis= ) > - use G_BYTE for the raspi3 machine > - added Reviewed-by tags >=20 > Regards, >=20 > Phil. >=20 > Philippe Mathieu-Daud=E9 (40): > include: Add IEC binary prefixes in "qemu/units.h" > vdi: Use definitions from "qemu/units.h" > x86/cpu: Use definitions from "qemu/units.h" > checkpatch: Recognize IEC binary prefix definitions > hw: Use IEC binary prefix definitions from "qemu/units.h" > hw: Directly use "qemu/units.h" instead of "qemu/cutils.h" > hw/ivshmem: Use the IEC binary prefix definitions > hw/ipack: Use the IEC binary prefix definitions > hw/scsi: Use the IEC binary prefix definitions > hw/smbios: Use the IEC binary prefix definitions > hw/xen: Use the IEC binary prefix definitions > hw/tpm: Use the IEC binary prefix definitions > hw/block: Use the IEC binary prefix definitions > hw/display: Use the IEC binary prefix definitions > hw/misc: Use the IEC binary prefix definitions > hw/riscv: Use the IEC binary prefix definitions > hw/m68k: Use the IEC binary prefix definitions > hw/sparc: Use the IEC binary prefix definitions > hw/s390x: Use the IEC binary prefix definitions > hw/hppa: Use the IEC binary prefix definitions > hw/xtensa: Use the IEC binary prefix definitions > hw/alpha: Use the IEC binary prefix definitions > hw/tricore: Use the IEC binary prefix definitions > hw/microblaze: Use the IEC binary prefix definitions > hw/nios2: Use the IEC binary prefix definitions > hw/cris: Use the IEC binary prefix definitions > hw/lm32: Use the IEC binary prefix definitions > hw/sh4: Use the IEC binary prefix definitions > hw/mips/r4k: Constify params_size > hw/mips: Use the IEC binary prefix definitions > hw/arm: Use the IEC binary prefix definitions > hw/ppc: Use the IEC binary prefix definitions > hw/i386: Use the IEC binary prefix definitions > hw/net: Use the IEC binary prefix definitions > hw/usb: Use the IEC binary prefix definitions > hw/sd: Use the IEC binary prefix definitions > hw/vfio: Use the IEC binary prefix definitions > hw/virtio: Use the IEC binary prefix definitions > hw/rdma: Use the IEC binary prefix definitions > cutils: Do not include "qemu/units.h" directly >=20 > hw/net/ne2000.h | 5 ++-- > hw/ppc/mac.h | 3 ++- > hw/rdma/vmw/pvrdma.h | 3 ++- > include/hw/acpi/tpm.h | 3 ++- > include/hw/arm/fsl-imx7.h | 5 ++-- > include/hw/arm/stm32f205_soc.h | 5 ++-- > include/hw/display/xlnx_dp.h | 5 ++-- > include/hw/i386/ich9.h | 3 ++- > include/hw/intc/mips_gic.h | 3 ++- > include/hw/mips/bios.h | 3 ++- > include/hw/net/allwinner_emac.h | 5 ++-- > include/hw/ppc/spapr.h | 5 ++-- > include/hw/virtio/virtio-net.h | 3 ++- > include/qemu/cutils.h | 7 ------ > include/qemu/units.h | 20 ++++++++++++++++ > block/vdi.c | 8 +++---- > hw/alpha/typhoon.c | 17 +++++++------- > hw/arm/bcm2835_peripherals.c | 3 ++- > hw/arm/boot.c | 7 +++--- > hw/arm/collie.c | 5 ++-- > hw/arm/digic_boards.c | 7 +++--- > hw/arm/exynos4_boards.c | 3 ++- > hw/arm/gumstix.c | 3 ++- > hw/arm/integratorcp.c | 3 ++- > hw/arm/mainstone.c | 3 ++- > hw/arm/msf2-soc.c | 6 ++--- > hw/arm/msf2-som.c | 8 +++---- > hw/arm/musicpal.c | 9 +++---- > hw/arm/omap_sx1.c | 11 +++++---- > hw/arm/raspi.c | 5 ++-- > hw/arm/smmu-common.c | 3 ++- > hw/arm/stellaris.c | 5 ++-- > hw/arm/versatilepb.c | 5 ++-- > hw/arm/vexpress.c | 7 +++--- > hw/arm/virt.c | 5 ++-- > hw/arm/xilinx_zynq.c | 7 +++--- > hw/block/m25p80.c | 5 ++-- > hw/block/nvme.c | 3 ++- > hw/block/tc58128.c | 3 ++- > hw/block/xen_disk.c | 5 ++-- > hw/core/loader-fit.c | 3 ++- > hw/core/machine.c | 4 ++-- > hw/cris/axis_dev88.c | 3 ++- > hw/display/bochs-display.c | 9 +++---- > hw/display/cirrus_vga.c | 10 ++++---- > hw/display/g364fb.c | 4 ++-- > hw/display/qxl.c | 28 ++++++++++------------ > hw/display/sm501.c | 16 ++++++------- > hw/display/vga-isa-mm.c | 5 ++-- > hw/display/vga.c | 5 ++-- > hw/display/virtio-gpu.c | 4 ++-- > hw/display/vmware_vga.c | 3 ++- > hw/display/xenfb.c | 3 ++- > hw/hppa/dino.c | 3 ++- > hw/hppa/machine.c | 12 +++++----- > hw/i386/acpi-build.c | 5 ++-- > hw/i386/pc.c | 19 ++++++++------- > hw/i386/pc_piix.c | 4 ++-- > hw/i386/pc_q35.c | 3 ++- > hw/i386/pc_sysfw.c | 9 +++---- > hw/i386/xen/xen-mapcache.c | 3 ++- > hw/intc/apic_common.c | 3 ++- > hw/ipack/tpci200.c | 5 ++-- > hw/lm32/lm32_boards.c | 13 +++++----- > hw/lm32/milkymist.c | 10 ++++---- > hw/m68k/mcf5208.c | 3 ++- > hw/microblaze/petalogix_ml605_mmu.c | 7 +++--- > hw/microblaze/petalogix_s3adsp1800_mmu.c | 7 +++--- > hw/mips/boston.c | 30 ++++++++++++------------ > hw/mips/mips_fulong2e.c | 7 +++--- > hw/mips/mips_malta.c | 23 ++++++++++-------- > hw/mips/mips_r4k.c | 15 ++++++------ > hw/misc/aspeed_sdmc.c | 9 +++---- > hw/misc/auxbus.c | 3 ++- > hw/misc/edu.c | 3 ++- > hw/misc/imx7_gpr.c | 3 ++- > hw/misc/ivshmem.c | 3 ++- > hw/misc/mips_itu.c | 3 ++- > hw/misc/omap_gpmc.c | 5 ++-- > hw/net/e1000e.c | 7 +++--- > hw/net/e1000x_common.c | 3 ++- > hw/net/eepro100.c | 3 +-- > hw/nios2/boot.c | 6 ++--- > hw/nvram/spapr_nvram.c | 10 ++++---- > hw/pci-host/designware.c | 3 ++- > hw/pci-host/gpex.c | 3 ++- > hw/pci-host/piix.c | 5 ++-- > hw/pci-host/prep.c | 3 ++- > hw/pci-host/q35.c | 17 +++++++------- > hw/pci-host/xilinx-pcie.c | 5 ++-- > hw/ppc/e500.c | 13 +++++----- > hw/ppc/e500plat.c | 3 ++- > hw/ppc/mac_newworld.c | 1 - > hw/ppc/mac_oldworld.c | 9 ++++--- > hw/ppc/pnv.c | 6 ++--- > hw/ppc/ppc405_boards.c | 9 +++---- > hw/ppc/ppc405_uc.c | 7 +++--- > hw/ppc/ppc440_bamboo.c | 6 +++-- > hw/ppc/ppc440_uc.c | 28 +++++++++++----------- > hw/ppc/ppc4xx_devs.c | 22 +++++++++-------- > hw/ppc/ppce500_spin.c | 3 ++- > hw/ppc/prep.c | 6 ++--- > hw/ppc/rs6000_mc.c | 13 +++++----- > hw/ppc/sam460ex.c | 20 +++++++++------- > hw/ppc/spapr.c | 12 +++++----- > hw/ppc/spapr_rtas.c | 2 +- > hw/ppc/virtex_ml507.c | 7 +++--- > hw/riscv/virt.c | 3 ++- > hw/s390x/s390-skeys.c | 3 ++- > hw/s390x/s390-stattrib.c | 3 ++- > hw/s390x/sclp.c | 4 ++-- > hw/scsi/scsi-disk.c | 9 +++---- > hw/sd/sd.c | 8 +++---- > hw/sd/sdhci.c | 6 ++--- > hw/sh4/r2d.c | 3 ++- > hw/smbios/smbios.c | 15 +++++------- > hw/sparc/leon3.c | 9 +++---- > hw/sparc/sun4m.c | 9 ++++--- > hw/sparc64/niagara.c | 3 ++- > hw/sparc64/sun4u.c | 4 ++-- > hw/ssi/aspeed_smc.c | 29 ++++++++++++----------- > hw/tricore/tricore_testboard.c | 13 +++++----- > hw/usb/ccid-card-passthru.c | 5 ++-- > hw/usb/combined-packet.c | 3 ++- > hw/usb/dev-smartcard-reader.c | 3 ++- > hw/usb/redirect.c | 3 ++- > hw/vfio/pci-quirks.c | 9 +++---- > hw/vfio/pci.c | 3 ++- > hw/xenpv/xen_domainbuild.c | 13 +++++----- > hw/xtensa/xtfpga.c | 5 ++-- > target/i386/cpu.c | 4 +--- > tests/test-cutils.c | 18 +++++++------- > tests/test-keyval.c | 6 ++--- > tests/test-qemu-opts.c | 7 +++--- > scripts/checkpatch.pl | 1 + > 135 files changed, 533 insertions(+), 431 deletions(-) > create mode 100644 include/qemu/units.h >=20 > --=20 > 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSCTh-0000ft-AQ for qemu-devel@nongnu.org; Sun, 10 Jun 2018 22:22:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSCTf-0005qd-P8 for qemu-devel@nongnu.org; Sun, 10 Jun 2018 22:22:41 -0400 Date: Mon, 11 Jun 2018 05:22:16 +0300 From: "Michael S. Tsirkin" Message-ID: <20180611052040-mutt-send-email-mst@kernel.org> References: <20180611011501.10235-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20180611011501.10235-1-f4bug@amsat.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 00/40] Use the IEC binary prefix definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: Thomas Huth , Stefan Weil , Nikunj A Dadhania , qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, qemu-s390x@nongnu.org, qemu-trivial@nongnu.org, Fabien Chouteau , Alistair Francis , Aurelien Jarno , Anthony Perard , Christian Borntraeger , Marek Vasut , Sagar Karandikar , David Gibson , Antony Pavlov , Artyom Tarasenko , Andrzej Zaborowski , Beniamino Galvani , Peter Crosthwaite , Chris Wulff , Dmitry Fleytman , "Edgar E . Iglesias" , Igor Mitsyanko , Max Filippov , Magnus Damm , Marcel Apfelbaum , Subbaraya Sundeep , Alberto Garcia , Mark Cave-Ayland , Keith Busch , Stefano Stabellini , Peter Maydell , Stefan Berger , Bastian Koppelmann , Paul Burton , Yongbok Kim , Peter Chubb , Yuval Shaia , =?iso-8859-1?Q?Herv=E9?= Poussineau , Alex Williamson , Markus Armbruster , Cornelia Huck , David Hildenbrand , Eric Blake , Eduardo Habkost , Fam Zheng , Igor Mammedov , Jason Wang , Gerd Hoffmann , Kevin Wolf , Max Reitz , Paolo Bonzini , Michael Clark , Palmer Dabbelt , Jiri Slaby , Alexander Graf , Richard Henderson , Michael Walle , Jan Kiszka On Sun, Jun 10, 2018 at 10:14:21PM -0300, Philippe Mathieu-Daud=E9 wrote: > Hi, >=20 > This series: >=20 > - split the byte-based definitions from "qemu/cutils.h" to "qemu/units.= h" > (this now triggers WARNING: 1 added file, does MAINTAINERS need updat= ing?) > - clean hw/ includes; > - replace different constants used for byte size with their correspondi= ng > IEC binary prefix definitions. >=20 > Since v3: > - use IEC binary prefix definitions (Stefan Weil) > - rebased > - added R-b tags It violates our coding style which requires KIB for macros. But strangely, I like how this looks anyway. So series Reviewed-by: Michael S. Tsirkin but I think you need to update the coding style explaining that there's an exception. > Since v2: > - use "qemu/units.h" instead of "qemu/cunits.h" (Daniel P. Berrang=E9) > - avoid rebuilding the world including "qemu/units.h" in "hw/hw.h" (Tho= mas Huth) > - more constant replaced >=20 > Since v1: > - corrected Xen mult -> div (Alan Robinson) > - tagged 'include "qemu/cunits.h" in "hw/hw.h" as RFC > - fixed mips_r4k 'params_size' (Thomas Huth) > - added command used to generate patch in each commit (Alistair Francis= ) > - use G_BYTE for the raspi3 machine > - added Reviewed-by tags >=20 > Regards, >=20 > Phil. >=20 > Philippe Mathieu-Daud=E9 (40): > include: Add IEC binary prefixes in "qemu/units.h" > vdi: Use definitions from "qemu/units.h" > x86/cpu: Use definitions from "qemu/units.h" > checkpatch: Recognize IEC binary prefix definitions > hw: Use IEC binary prefix definitions from "qemu/units.h" > hw: Directly use "qemu/units.h" instead of "qemu/cutils.h" > hw/ivshmem: Use the IEC binary prefix definitions > hw/ipack: Use the IEC binary prefix definitions > hw/scsi: Use the IEC binary prefix definitions > hw/smbios: Use the IEC binary prefix definitions > hw/xen: Use the IEC binary prefix definitions > hw/tpm: Use the IEC binary prefix definitions > hw/block: Use the IEC binary prefix definitions > hw/display: Use the IEC binary prefix definitions > hw/misc: Use the IEC binary prefix definitions > hw/riscv: Use the IEC binary prefix definitions > hw/m68k: Use the IEC binary prefix definitions > hw/sparc: Use the IEC binary prefix definitions > hw/s390x: Use the IEC binary prefix definitions > hw/hppa: Use the IEC binary prefix definitions > hw/xtensa: Use the IEC binary prefix definitions > hw/alpha: Use the IEC binary prefix definitions > hw/tricore: Use the IEC binary prefix definitions > hw/microblaze: Use the IEC binary prefix definitions > hw/nios2: Use the IEC binary prefix definitions > hw/cris: Use the IEC binary prefix definitions > hw/lm32: Use the IEC binary prefix definitions > hw/sh4: Use the IEC binary prefix definitions > hw/mips/r4k: Constify params_size > hw/mips: Use the IEC binary prefix definitions > hw/arm: Use the IEC binary prefix definitions > hw/ppc: Use the IEC binary prefix definitions > hw/i386: Use the IEC binary prefix definitions > hw/net: Use the IEC binary prefix definitions > hw/usb: Use the IEC binary prefix definitions > hw/sd: Use the IEC binary prefix definitions > hw/vfio: Use the IEC binary prefix definitions > hw/virtio: Use the IEC binary prefix definitions > hw/rdma: Use the IEC binary prefix definitions > cutils: Do not include "qemu/units.h" directly >=20 > hw/net/ne2000.h | 5 ++-- > hw/ppc/mac.h | 3 ++- > hw/rdma/vmw/pvrdma.h | 3 ++- > include/hw/acpi/tpm.h | 3 ++- > include/hw/arm/fsl-imx7.h | 5 ++-- > include/hw/arm/stm32f205_soc.h | 5 ++-- > include/hw/display/xlnx_dp.h | 5 ++-- > include/hw/i386/ich9.h | 3 ++- > include/hw/intc/mips_gic.h | 3 ++- > include/hw/mips/bios.h | 3 ++- > include/hw/net/allwinner_emac.h | 5 ++-- > include/hw/ppc/spapr.h | 5 ++-- > include/hw/virtio/virtio-net.h | 3 ++- > include/qemu/cutils.h | 7 ------ > include/qemu/units.h | 20 ++++++++++++++++ > block/vdi.c | 8 +++---- > hw/alpha/typhoon.c | 17 +++++++------- > hw/arm/bcm2835_peripherals.c | 3 ++- > hw/arm/boot.c | 7 +++--- > hw/arm/collie.c | 5 ++-- > hw/arm/digic_boards.c | 7 +++--- > hw/arm/exynos4_boards.c | 3 ++- > hw/arm/gumstix.c | 3 ++- > hw/arm/integratorcp.c | 3 ++- > hw/arm/mainstone.c | 3 ++- > hw/arm/msf2-soc.c | 6 ++--- > hw/arm/msf2-som.c | 8 +++---- > hw/arm/musicpal.c | 9 +++---- > hw/arm/omap_sx1.c | 11 +++++---- > hw/arm/raspi.c | 5 ++-- > hw/arm/smmu-common.c | 3 ++- > hw/arm/stellaris.c | 5 ++-- > hw/arm/versatilepb.c | 5 ++-- > hw/arm/vexpress.c | 7 +++--- > hw/arm/virt.c | 5 ++-- > hw/arm/xilinx_zynq.c | 7 +++--- > hw/block/m25p80.c | 5 ++-- > hw/block/nvme.c | 3 ++- > hw/block/tc58128.c | 3 ++- > hw/block/xen_disk.c | 5 ++-- > hw/core/loader-fit.c | 3 ++- > hw/core/machine.c | 4 ++-- > hw/cris/axis_dev88.c | 3 ++- > hw/display/bochs-display.c | 9 +++---- > hw/display/cirrus_vga.c | 10 ++++---- > hw/display/g364fb.c | 4 ++-- > hw/display/qxl.c | 28 ++++++++++------------ > hw/display/sm501.c | 16 ++++++------- > hw/display/vga-isa-mm.c | 5 ++-- > hw/display/vga.c | 5 ++-- > hw/display/virtio-gpu.c | 4 ++-- > hw/display/vmware_vga.c | 3 ++- > hw/display/xenfb.c | 3 ++- > hw/hppa/dino.c | 3 ++- > hw/hppa/machine.c | 12 +++++----- > hw/i386/acpi-build.c | 5 ++-- > hw/i386/pc.c | 19 ++++++++------- > hw/i386/pc_piix.c | 4 ++-- > hw/i386/pc_q35.c | 3 ++- > hw/i386/pc_sysfw.c | 9 +++---- > hw/i386/xen/xen-mapcache.c | 3 ++- > hw/intc/apic_common.c | 3 ++- > hw/ipack/tpci200.c | 5 ++-- > hw/lm32/lm32_boards.c | 13 +++++----- > hw/lm32/milkymist.c | 10 ++++---- > hw/m68k/mcf5208.c | 3 ++- > hw/microblaze/petalogix_ml605_mmu.c | 7 +++--- > hw/microblaze/petalogix_s3adsp1800_mmu.c | 7 +++--- > hw/mips/boston.c | 30 ++++++++++++------------ > hw/mips/mips_fulong2e.c | 7 +++--- > hw/mips/mips_malta.c | 23 ++++++++++-------- > hw/mips/mips_r4k.c | 15 ++++++------ > hw/misc/aspeed_sdmc.c | 9 +++---- > hw/misc/auxbus.c | 3 ++- > hw/misc/edu.c | 3 ++- > hw/misc/imx7_gpr.c | 3 ++- > hw/misc/ivshmem.c | 3 ++- > hw/misc/mips_itu.c | 3 ++- > hw/misc/omap_gpmc.c | 5 ++-- > hw/net/e1000e.c | 7 +++--- > hw/net/e1000x_common.c | 3 ++- > hw/net/eepro100.c | 3 +-- > hw/nios2/boot.c | 6 ++--- > hw/nvram/spapr_nvram.c | 10 ++++---- > hw/pci-host/designware.c | 3 ++- > hw/pci-host/gpex.c | 3 ++- > hw/pci-host/piix.c | 5 ++-- > hw/pci-host/prep.c | 3 ++- > hw/pci-host/q35.c | 17 +++++++------- > hw/pci-host/xilinx-pcie.c | 5 ++-- > hw/ppc/e500.c | 13 +++++----- > hw/ppc/e500plat.c | 3 ++- > hw/ppc/mac_newworld.c | 1 - > hw/ppc/mac_oldworld.c | 9 ++++--- > hw/ppc/pnv.c | 6 ++--- > hw/ppc/ppc405_boards.c | 9 +++---- > hw/ppc/ppc405_uc.c | 7 +++--- > hw/ppc/ppc440_bamboo.c | 6 +++-- > hw/ppc/ppc440_uc.c | 28 +++++++++++----------- > hw/ppc/ppc4xx_devs.c | 22 +++++++++-------- > hw/ppc/ppce500_spin.c | 3 ++- > hw/ppc/prep.c | 6 ++--- > hw/ppc/rs6000_mc.c | 13 +++++----- > hw/ppc/sam460ex.c | 20 +++++++++------- > hw/ppc/spapr.c | 12 +++++----- > hw/ppc/spapr_rtas.c | 2 +- > hw/ppc/virtex_ml507.c | 7 +++--- > hw/riscv/virt.c | 3 ++- > hw/s390x/s390-skeys.c | 3 ++- > hw/s390x/s390-stattrib.c | 3 ++- > hw/s390x/sclp.c | 4 ++-- > hw/scsi/scsi-disk.c | 9 +++---- > hw/sd/sd.c | 8 +++---- > hw/sd/sdhci.c | 6 ++--- > hw/sh4/r2d.c | 3 ++- > hw/smbios/smbios.c | 15 +++++------- > hw/sparc/leon3.c | 9 +++---- > hw/sparc/sun4m.c | 9 ++++--- > hw/sparc64/niagara.c | 3 ++- > hw/sparc64/sun4u.c | 4 ++-- > hw/ssi/aspeed_smc.c | 29 ++++++++++++----------- > hw/tricore/tricore_testboard.c | 13 +++++----- > hw/usb/ccid-card-passthru.c | 5 ++-- > hw/usb/combined-packet.c | 3 ++- > hw/usb/dev-smartcard-reader.c | 3 ++- > hw/usb/redirect.c | 3 ++- > hw/vfio/pci-quirks.c | 9 +++---- > hw/vfio/pci.c | 3 ++- > hw/xenpv/xen_domainbuild.c | 13 +++++----- > hw/xtensa/xtfpga.c | 5 ++-- > target/i386/cpu.c | 4 +--- > tests/test-cutils.c | 18 +++++++------- > tests/test-keyval.c | 6 ++--- > tests/test-qemu-opts.c | 7 +++--- > scripts/checkpatch.pl | 1 + > 135 files changed, 533 insertions(+), 431 deletions(-) > create mode 100644 include/qemu/units.h >=20 > --=20 > 2.17.1