From: Christoph Hellwig <hch@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Miklos Szeredi <miklos@szeredi.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-unionfs@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [GIT PULL] overlayfs update for 4.18
Date: Sun, 10 Jun 2018 23:09:50 -0700 [thread overview]
Message-ID: <20180611060950.GA8048@infradead.org> (raw)
In-Reply-To: <CA+55aFxkUYXHNT+GtUFMSSdnNgYBoQu1tvxiWYNrwTJCLbi_rw@mail.gmail.com>
On Sat, Jun 09, 2018 at 02:42:20PM -0700, Linus Torvalds wrote:
> And Christoph's copmmentary isn't really helping the situation.
> Christoph, I haven't seen the NAK history, can you elaborate?
Most of the bits just need a bit of refinement I think, instead of
being forced through the overlayfs tree and are generally fine.
The pre_mmap hook I think is a clear no-go. We've had this tried
multiple times and always rejected it. Unlike previous uses the
overlayfs use isn't outright broken, but still questionalable
as it will still lead to a copyup that "leaks" if the actual mmap
wasn't successfull. The whole discussion of how mmap happens,
how we deal with mmap_sem and failures needs a broader discussion
with all MM and VFS folks first.
next prev parent reply other threads:[~2018-06-11 6:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 12:13 [GIT PULL] overlayfs update for 4.18 Miklos Szeredi
2018-06-09 6:52 ` Christoph Hellwig
2018-06-09 21:42 ` Linus Torvalds
2018-06-09 23:55 ` Al Viro
2018-06-11 6:09 ` Christoph Hellwig [this message]
2018-06-10 5:54 ` Al Viro
2018-06-11 6:10 ` Christoph Hellwig
2018-06-11 8:41 ` Miklos Szeredi
2018-06-11 16:27 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2018-05-29 13:21 Miklos Szeredi
2018-05-29 13:59 ` Christoph Hellwig
2018-05-29 14:12 ` Miklos Szeredi
2018-05-30 8:36 ` Miklos Szeredi
2018-05-30 22:27 ` Dave Chinner
2018-06-01 15:26 ` Miklos Szeredi
2018-06-01 16:18 ` Randy Dunlap
2018-06-01 17:03 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611060950.GA8048@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.