* Re: [PATCH] ARM: dts: imx6q: Use correct SDMA script for SPI5 core
[not found] <20180522174509.18154-1-sean.nyekjaer@prevas.dk>
@ 2018-05-22 17:49 ` Fabio Estevam
2018-06-11 6:41 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2018-05-22 17:49 UTC (permalink / raw)
To: Sean Nyekjaer
Cc: Sascha Hauer, linux-spi, Anton Bondarenko, Mark Brown, stable,
Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
On Tue, May 22, 2018 at 2:45 PM, Sean Nyekjaer <sean.nyekjaer@prevas.dk> wrote:
> According to the reference manual the shp_2_mcu / mcu_2_shp
> scripts must be used for devices connected through the SPBA.
>
> This fixes an issue we saw with DMA transfers.
> Sometimes the SPI controller RX FIFO was not empty after a DMA
> transfer and the driver got stuck in the next PIO transfer when
> it read one word more than expected.
>
> commit dd4b487b32a35 ("ARM: dts: imx6: Use correct SDMA script
> for SPI cores") is fixing the same issue but only for SPI1 - 4.
>
> Fixes: 677940258dd8e ("ARM: dts: imx6q: enable dma for ecspi5")
> Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: imx6q: Use correct SDMA script for SPI5 core
@ 2018-05-22 17:49 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2018-05-22 17:49 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 22, 2018 at 2:45 PM, Sean Nyekjaer <sean.nyekjaer@prevas.dk> wrote:
> According to the reference manual the shp_2_mcu / mcu_2_shp
> scripts must be used for devices connected through the SPBA.
>
> This fixes an issue we saw with DMA transfers.
> Sometimes the SPI controller RX FIFO was not empty after a DMA
> transfer and the driver got stuck in the next PIO transfer when
> it read one word more than expected.
>
> commit dd4b487b32a35 ("ARM: dts: imx6: Use correct SDMA script
> for SPI cores") is fixing the same issue but only for SPI1 - 4.
>
> Fixes: 677940258dd8e ("ARM: dts: imx6q: enable dma for ecspi5")
> Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx6q: Use correct SDMA script for SPI5 core
[not found] <20180522174509.18154-1-sean.nyekjaer@prevas.dk>
@ 2018-06-11 6:41 ` Shawn Guo
2018-06-11 6:41 ` Shawn Guo
1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2018-06-11 6:41 UTC (permalink / raw)
To: Sean Nyekjaer
Cc: s.hauer, linux-spi, anton.bondarenko.sama, broonie, stable,
linux-arm-kernel
On Tue, May 22, 2018 at 07:45:09PM +0200, Sean Nyekjaer wrote:
> According to the reference manual the shp_2_mcu / mcu_2_shp
> scripts must be used for devices connected through the SPBA.
>
> This fixes an issue we saw with DMA transfers.
> Sometimes the SPI controller RX FIFO was not empty after a DMA
> transfer and the driver got stuck in the next PIO transfer when
> it read one word more than expected.
>
> commit dd4b487b32a35 ("ARM: dts: imx6: Use correct SDMA script
> for SPI cores") is fixing the same issue but only for SPI1 - 4.
>
> Fixes: 677940258dd8e ("ARM: dts: imx6q: enable dma for ecspi5")
> Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: imx6q: Use correct SDMA script for SPI5 core
@ 2018-06-11 6:41 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2018-06-11 6:41 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 22, 2018 at 07:45:09PM +0200, Sean Nyekjaer wrote:
> According to the reference manual the shp_2_mcu / mcu_2_shp
> scripts must be used for devices connected through the SPBA.
>
> This fixes an issue we saw with DMA transfers.
> Sometimes the SPI controller RX FIFO was not empty after a DMA
> transfer and the driver got stuck in the next PIO transfer when
> it read one word more than expected.
>
> commit dd4b487b32a35 ("ARM: dts: imx6: Use correct SDMA script
> for SPI cores") is fixing the same issue but only for SPI1 - 4.
>
> Fixes: 677940258dd8e ("ARM: dts: imx6q: enable dma for ecspi5")
> Signed-off-by: Sean Nyekjaer <sean.nyekjaer@prevas.dk>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread