From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-4331-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id CAA3A1CB80ED for ; Mon, 11 Jun 2018 01:44:10 -0700 (PDT) Date: Mon, 11 Jun 2018 10:43:48 +0200 From: Cornelia Huck Message-ID: <20180611104348.3a4c4652.cohuck@redhat.com> In-Reply-To: <20180611075640.19751-1-tiwei.bie@intel.com> References: <20180611075640.19751-1-tiwei.bie@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: [virtio-dev] Re: [PATCH v3] content: enhance device requirements for feature bits To: Tiwei Bie Cc: mst@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, virtio-dev@lists.oasis-open.org, dan.daly@intel.com, cunming.liang@intel.com, zhihong.wang@intel.com List-ID: On Mon, 11 Jun 2018 15:56:40 +0800 Tiwei Bie wrote: > Suggested-by: Michael S. Tsirkin > Signed-off-by: Tiwei Bie > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14 > --- > v2: > - Refine the wording (Cornelia); > > v3: > - Refine the wording (MST); > > content.tex | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/content.tex b/content.tex > index f996fad..3c7d67d 100644 > --- a/content.tex > +++ b/content.tex > @@ -125,6 +125,13 @@ which was not offered. The device SHOULD accept any valid subset > of features the driver accepts, otherwise it MUST fail to set the > FEATURES_OK \field{device status} bit when the driver writes it. > > +If a device has successfully negotiated a set of features > +at least once (by accepting the FEATURES_OK \field{device > +status} bit during device initialization), then it SHOULD > +NOT fail re-negotiation of the same set of features after > +a device or system reset. Failure to do so would interfere > +with resuming from suspend and error recovery. > + > \subsection{Legacy Interface: A Note on Feature > Bits}\label{sec:Basic Facilities of a Virtio Device / Feature > Bits / Legacy Interface: A Note on Feature Bits} Reviewed-by: Cornelia Huck --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org