From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-4335-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id 6295658191C3 for ; Mon, 11 Jun 2018 06:44:21 -0700 (PDT) Date: Mon, 11 Jun 2018 16:44:09 +0300 From: "Michael S. Tsirkin" Message-ID: <20180611164143-mutt-send-email-mst@kernel.org> References: <20180611075640.19751-1-tiwei.bie@intel.com> <20180611162354-mutt-send-email-mst@kernel.org> <20180611152933.36b3d735.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180611152933.36b3d735.cohuck@redhat.com> Subject: [virtio-dev] Re: [PATCH v3] content: enhance device requirements for feature bits To: Cornelia Huck Cc: Tiwei Bie , stefanha@redhat.com, pbonzini@redhat.com, virtio-dev@lists.oasis-open.org, dan.daly@intel.com, cunming.liang@intel.com, zhihong.wang@intel.com List-ID: On Mon, Jun 11, 2018 at 03:29:33PM +0200, Cornelia Huck wrote: > On Mon, 11 Jun 2018 16:24:51 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Jun 11, 2018 at 03:56:40PM +0800, Tiwei Bie wrote: > > > Suggested-by: Michael S. Tsirkin > > > Signed-off-by: Tiwei Bie > > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14 > > > --- > > > v2: > > > - Refine the wording (Cornelia); > > > > > > v3: > > > - Refine the wording (MST); > > > > > > content.tex | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/content.tex b/content.tex > > > index f996fad..3c7d67d 100644 > > > --- a/content.tex > > > +++ b/content.tex > > > @@ -125,6 +125,13 @@ which was not offered. The device SHOULD accept any valid subset > > > of features the driver accepts, otherwise it MUST fail to set the > > > FEATURES_OK \field{device status} bit when the driver writes it. > > > > > > +If a device has successfully negotiated a set of features > > > +at least once (by accepting the FEATURES_OK \field{device > > > +status} bit during device initialization), then it SHOULD > > > +NOT fail re-negotiation of the same set of features after > > > +a device or system reset. Failure to do so would interfere > > > +with resuming from suspend and error recovery. > > > + > > > \subsection{Legacy Interface: A Note on Feature > > > Bits}\label{sec:Basic Facilities of a Virtio Device / Feature > > > Bits / Legacy Interface: A Note on Feature Bits} > > > > OK but there's no \field{device status} anywhere > > else I think. > > We only have \field{status} in spec. > > Should probably be "device \field{status} bit", then? I'm actually wrong, it is called device status in "Basic Facilities of a Virtio Device". We probably should fix the places that call it \field{status}. --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org