From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1fSOGl-0003pq-O8 for mharc-qemu-trivial@gnu.org; Mon, 11 Jun 2018 10:58:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSOGj-0003mI-Uq for qemu-trivial@nongnu.org; Mon, 11 Jun 2018 10:58:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSOGj-0000hL-7J for qemu-trivial@nongnu.org; Mon, 11 Jun 2018 10:58:06 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36944 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fSOGe-0000fC-QA; Mon, 11 Jun 2018 10:58:00 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2C243BD9E; Mon, 11 Jun 2018 14:58:00 +0000 (UTC) Received: from gondolin (ovpn-117-32.ams2.redhat.com [10.36.117.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id 22C382024CA1; Mon, 11 Jun 2018 14:57:57 +0000 (UTC) Date: Mon, 11 Jun 2018 16:57:55 +0200 From: Cornelia Huck To: Peter Maydell Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, patches@linaro.org, Richard Henderson , John Snow , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Alex Williamson , Thomas Huth , Markus Armbruster , Stefan Hajnoczi , Kevin Wolf Message-ID: <20180611165755.64b684c8.cohuck@redhat.com> In-Reply-To: <20180611141716.3813-1-peter.maydell@linaro.org> References: <20180611141716.3813-1-peter.maydell@linaro.org> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 11 Jun 2018 14:58:00 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 11 Jun 2018 14:58:00 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'cohuck@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-trivial] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 14:58:07 -0000 On Mon, 11 Jun 2018 15:17:16 +0100 Peter Maydell wrote: > The codebase has a bit of a mix of different multiline > comment styles. State a preference for the Linux kernel > style: > /* > * Star on the left for each line. > * Leading slash-star and trailing star-slash > * each go on a line of their own. > */ > > Signed-off-by: Peter Maydell > --- > This is not my personal favourite, but seemed to be the > closest we had to consensus in the mail thread for v1; > I can live with it in order to avoid getting patches which > use the styles I like even less :-) > --- > CODING_STYLE | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) Reviewed-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSOGi-0003km-22 for qemu-devel@nongnu.org; Mon, 11 Jun 2018 10:58:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSOGe-0000fV-Vn for qemu-devel@nongnu.org; Mon, 11 Jun 2018 10:58:04 -0400 Date: Mon, 11 Jun 2018 16:57:55 +0200 From: Cornelia Huck Message-ID: <20180611165755.64b684c8.cohuck@redhat.com> In-Reply-To: <20180611141716.3813-1-peter.maydell@linaro.org> References: <20180611141716.3813-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] CODING_STYLE: Define our preferred form for multiline comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org, patches@linaro.org, Richard Henderson , John Snow , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Alex Williamson , Thomas Huth , Markus Armbruster , Stefan Hajnoczi , Kevin Wolf On Mon, 11 Jun 2018 15:17:16 +0100 Peter Maydell wrote: > The codebase has a bit of a mix of different multiline > comment styles. State a preference for the Linux kernel > style: > /* > * Star on the left for each line. > * Leading slash-star and trailing star-slash > * each go on a line of their own. > */ > > Signed-off-by: Peter Maydell > --- > This is not my personal favourite, but seemed to be the > closest we had to consensus in the mail thread for v1; > I can live with it in order to avoid getting patches which > use the styles I like even less :-) > --- > CODING_STYLE | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) Reviewed-by: Cornelia Huck