From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1fSPg7-00078T-0c for mharc-qemu-trivial@gnu.org; Mon, 11 Jun 2018 12:28:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSPg5-000772-Bd for qemu-trivial@nongnu.org; Mon, 11 Jun 2018 12:28:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSPg4-0001UD-DV for qemu-trivial@nongnu.org; Mon, 11 Jun 2018 12:28:21 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59722 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fSPfo-0001GS-8l; Mon, 11 Jun 2018 12:28:04 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1872D406E8A1; Mon, 11 Jun 2018 16:28:03 +0000 (UTC) Received: from redhat.com (ovpn-122-170.rdu2.redhat.com [10.10.122.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 56E8C2024CA2; Mon, 11 Jun 2018 16:27:57 +0000 (UTC) Date: Mon, 11 Jun 2018 19:27:57 +0300 From: "Michael S. Tsirkin" To: Eric Blake Cc: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Thomas Huth , Stefan Weil , Nikunj A Dadhania , qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, qemu-s390x@nongnu.org, qemu-trivial@nongnu.org, Fabien Chouteau , Alistair Francis , Aurelien Jarno , Anthony Perard , Christian Borntraeger , Marek Vasut , Sagar Karandikar , David Gibson , Antony Pavlov , Artyom Tarasenko , Andrzej Zaborowski , Beniamino Galvani , Peter Crosthwaite , Chris Wulff , Dmitry Fleytman , "Edgar E . Iglesias" , Igor Mitsyanko , Max Filippov , Magnus Damm , Marcel Apfelbaum , Subbaraya Sundeep , Alberto Garcia , Mark Cave-Ayland , Keith Busch , Stefano Stabellini , Peter Maydell , Stefan Berger , Bastian Koppelmann , Paul Burton , Yongbok Kim , Peter Chubb , Yuval Shaia , =?iso-8859-1?Q?Herv=E9?= Poussineau , Alex Williamson , Markus Armbruster , Cornelia Huck , David Hildenbrand , Eduardo Habkost , Fam Zheng , Igor Mammedov , Jason Wang , Gerd Hoffmann , Kevin Wolf , Max Reitz , Paolo Bonzini , Michael Clark , Palmer Dabbelt , Jiri Slaby , Alexander Graf , Richard Henderson , Michael Walle , Jan Kiszka Message-ID: <20180611192510-mutt-send-email-mst@kernel.org> References: <20180611011501.10235-1-f4bug@amsat.org> <54eb6ae9-d7e0-8a4d-6bd4-f8f1d0f00b92@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <54eb6ae9-d7e0-8a4d-6bd4-f8f1d0f00b92@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Mon, 11 Jun 2018 16:28:03 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Mon, 11 Jun 2018 16:28:03 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mst@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-trivial] [PATCH v4 00/40] Use the IEC binary prefix definitions X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 16:28:22 -0000 On Mon, Jun 11, 2018 at 10:55:17AM -0500, Eric Blake wrote: > On 06/10/2018 08:14 PM, Philippe Mathieu-Daud=E9 wrote: > > Hi, > >=20 > > This series: > >=20 > > - split the byte-based definitions from "qemu/cutils.h" to "qemu/unit= s.h" > > (this now triggers WARNING: 1 added file, does MAINTAINERS need up= dating?) > > - clean hw/ includes; > > - replace different constants used for byte size with their correspon= ding > > IEC binary prefix definitions. > >=20 > > Since v3: > > - use IEC binary prefix definitions (Stefan Weil) > > - rebased > > - added R-b tags > >=20 >=20 > > hw/net/ne2000.h | 5 ++-- > ... > > tests/test-qemu-opts.c | 7 +++--- > > scripts/checkpatch.pl | 1 + > > 135 files changed, 533 insertions(+), 431 deletions(-) > > create mode 100644 include/qemu/units.h > >=20 >=20 > At least monitor.c and vl.c are missing from this list; a more general = grep > shows that the following are all potential candidates for this cleanup: >=20 > $ git grep -n '[<>][<>]=3D [1-5]0' > disas/m68k.c:787: val >>=3D 10; > hw/mips/mips_malta.c:194: ram_size >>=3D 20; > hw/ppc/sam460ex.c:129: ram_size >>=3D 20; > hw/timer/sh_timer.c:112: case 4: freq >>=3D 10; break; Most likely not 4 kilobyte. > linux-user/mips/cpu_loop.c:641: code >>=3D= 10; > linux-user/mips/cpu_loop.c:664: code >>=3D 10; Seems to do with decoding machine code. Also unlikely to be in bytes. > monitor.c:3198: val <<=3D 20; > target/m68k/helper.c:386: size >>=3D 10; > target/m68k/helper.c:390: size >>=3D 10; > target/m68k/helper.c:394: size >>=3D 10; > target/xtensa/helper.c:729: sz >>=3D 20; > target/xtensa/helper.c:732: sz >>=3D 10; > vl.c:2793: sz <<=3D 20; > --=20 > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a5d:4301:0:0:0:0:0 with SMTP id h1-v6csp4243687wrq; Mon, 11 Jun 2018 09:28:19 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJuviqcCFaAcBYa/dEor9P2eJRYZsQloiZqaqL6FhODHOPs06OWWh+MCNyUIvmQ9NYRXzCC X-Received: by 2002:ae9:dd06:: with SMTP id r6-v6mr7632450qkf.417.1528734499326; Mon, 11 Jun 2018 09:28:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528734499; cv=none; d=google.com; s=arc-20160816; b=ziZlGOXwzHzBpADQrhkURNV2hPbfJX6ZsG2Rb2u7SiGAa5WlWO/HKe0DBRxn2IPJmN 7rqJVyfQFY59tNa7zurV9j07twND4CyVN7wgoI/mc1BopgJuC3UoUnhjzIZheQdm9IGw x4HSqVQuPfiuz1T7Oqy1P6wtnncuZthR58gS1kt1vkvEHm4h1FSWO2SNzzcTzLjqJeGS PC9fSuokEp1KrRFTSyequJ9hez8dogdgRNXkRXktGYflPfTW6CL27DKFukdmzLJDl0Nn J6LVkeHINBc2jMWbJd5vD+2Yyw+aSVt7f0EHdYzs+pAdAhnUvgQJ4c8/wIBxSngiZcGK sARw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:in-reply-to:content-disposition :mime-version:references:message-id:to:from:date :arc-authentication-results; bh=605JhgJ3ORk1gPuSgkCNfM/j5xzdTQ9i0BIyhHbE5zs=; b=Z9nRtDvQjBKKUcNT7/e7GH0/T/2p02tSwjYwuyrnMa1NoPt2iy1j3Q2stK69ENVOB8 8sVj3bXFy8RQekmP9vwyx7BG0m+20uL9aWlt9a+fqoNZdIzRuoBos0TNfXUp76dHigjp iMudPAs05kEMWJWJmybgSK4/2FR5iEyznN/AH/gMqklzcHZ9DsFu5FajAXWzSnUmuZrI KUZGwEdOqPQ4XqwGfP61gOL0PNw+koWF/I+4x2l07ZnxrygwoTo6S8euvRLznSC2drn8 RnMpqy4kKoMt6cNkz7gYyCmzuonF0PobvTKy24JqpI6gkcOz2AGFQsElHiSs8LKTUi05 202w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id m44-v6si17720150qta.390.2018.06.11.09.28.19 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 11 Jun 2018 09:28:19 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:50100 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSPg2-0006w9-T1 for alex.bennee@linaro.org; Mon, 11 Jun 2018 12:28:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSPfr-0006uR-LK for qemu-arm@nongnu.org; Mon, 11 Jun 2018 12:28:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSPfo-0001H6-Ei for qemu-arm@nongnu.org; Mon, 11 Jun 2018 12:28:07 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59722 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fSPfo-0001GS-8l; Mon, 11 Jun 2018 12:28:04 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1872D406E8A1; Mon, 11 Jun 2018 16:28:03 +0000 (UTC) Received: from redhat.com (ovpn-122-170.rdu2.redhat.com [10.10.122.170]) by smtp.corp.redhat.com (Postfix) with ESMTP id 56E8C2024CA2; Mon, 11 Jun 2018 16:27:57 +0000 (UTC) Date: Mon, 11 Jun 2018 19:27:57 +0300 From: "Michael S. Tsirkin" To: Eric Blake Message-ID: <20180611192510-mutt-send-email-mst@kernel.org> References: <20180611011501.10235-1-f4bug@amsat.org> <54eb6ae9-d7e0-8a4d-6bd4-f8f1d0f00b92@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <54eb6ae9-d7e0-8a4d-6bd4-f8f1d0f00b92@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Mon, 11 Jun 2018 16:28:03 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Mon, 11 Jun 2018 16:28:03 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mst@redhat.com' RCPT:'' Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: Re: [Qemu-arm] [PATCH v4 00/40] Use the IEC binary prefix definitions X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Dmitry Fleytman , Jan Kiszka , Sagar Karandikar , David Hildenbrand , Jason Wang , Palmer Dabbelt , Mark Cave-Ayland , qemu-devel@nongnu.org, Markus Armbruster , Keith Busch , Max Filippov , Michael Clark , Gerd Hoffmann , Max Reitz , Yongbok Kim , Marek Vasut , Stefano Stabellini , Alberto Garcia , qemu-block@nongnu.org, Stefan Berger , qemu-trivial@nongnu.org, Jiri Slaby , Magnus Damm , Alex Williamson , Michael Walle , Christian Borntraeger , =?iso-8859-1?Q?Herv=E9?= Poussineau , Antony Pavlov , Marcel Apfelbaum , Anthony Perard , Richard Henderson , Andrzej Zaborowski , Artyom Tarasenko , Thomas Huth , Fam Zheng , Eduardo Habkost , Nikunj A Dadhania , Stefan Weil , Alistair Francis , Fabien Chouteau , Beniamino Galvani , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Peter Chubb , Yuval Shaia , Paolo Bonzini , David Gibson , Kevin Wolf , Alexander Graf , Igor Mitsyanko , Bastian Koppelmann , Chris Wulff , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Subbaraya Sundeep , Paul Burton , qemu-ppc@nongnu.org, Cornelia Huck , Igor Mammedov , Aurelien Jarno Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: dnvw/3BLV7tF On Mon, Jun 11, 2018 at 10:55:17AM -0500, Eric Blake wrote: > On 06/10/2018 08:14 PM, Philippe Mathieu-Daud=E9 wrote: > > Hi, > >=20 > > This series: > >=20 > > - split the byte-based definitions from "qemu/cutils.h" to "qemu/unit= s.h" > > (this now triggers WARNING: 1 added file, does MAINTAINERS need up= dating?) > > - clean hw/ includes; > > - replace different constants used for byte size with their correspon= ding > > IEC binary prefix definitions. > >=20 > > Since v3: > > - use IEC binary prefix definitions (Stefan Weil) > > - rebased > > - added R-b tags > >=20 >=20 > > hw/net/ne2000.h | 5 ++-- > ... > > tests/test-qemu-opts.c | 7 +++--- > > scripts/checkpatch.pl | 1 + > > 135 files changed, 533 insertions(+), 431 deletions(-) > > create mode 100644 include/qemu/units.h > >=20 >=20 > At least monitor.c and vl.c are missing from this list; a more general = grep > shows that the following are all potential candidates for this cleanup: >=20 > $ git grep -n '[<>][<>]=3D [1-5]0' > disas/m68k.c:787: val >>=3D 10; > hw/mips/mips_malta.c:194: ram_size >>=3D 20; > hw/ppc/sam460ex.c:129: ram_size >>=3D 20; > hw/timer/sh_timer.c:112: case 4: freq >>=3D 10; break; Most likely not 4 kilobyte. > linux-user/mips/cpu_loop.c:641: code >>=3D= 10; > linux-user/mips/cpu_loop.c:664: code >>=3D 10; Seems to do with decoding machine code. Also unlikely to be in bytes. > monitor.c:3198: val <<=3D 20; > target/m68k/helper.c:386: size >>=3D 10; > target/m68k/helper.c:390: size >>=3D 10; > target/m68k/helper.c:394: size >>=3D 10; > target/xtensa/helper.c:729: sz >>=3D 20; > target/xtensa/helper.c:732: sz >>=3D 10; > vl.c:2793: sz <<=3D 20; > --=20 > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39990) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSPfw-0006yZ-Aj for qemu-devel@nongnu.org; Mon, 11 Jun 2018 12:28:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSPfv-0001Ns-8j for qemu-devel@nongnu.org; Mon, 11 Jun 2018 12:28:12 -0400 Date: Mon, 11 Jun 2018 19:27:57 +0300 From: "Michael S. Tsirkin" Message-ID: <20180611192510-mutt-send-email-mst@kernel.org> References: <20180611011501.10235-1-f4bug@amsat.org> <54eb6ae9-d7e0-8a4d-6bd4-f8f1d0f00b92@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <54eb6ae9-d7e0-8a4d-6bd4-f8f1d0f00b92@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 00/40] Use the IEC binary prefix definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Thomas Huth , Stefan Weil , Nikunj A Dadhania , qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, qemu-s390x@nongnu.org, qemu-trivial@nongnu.org, Fabien Chouteau , Alistair Francis , Aurelien Jarno , Anthony Perard , Christian Borntraeger , Marek Vasut , Sagar Karandikar , David Gibson , Antony Pavlov , Artyom Tarasenko , Andrzej Zaborowski , Beniamino Galvani , Peter Crosthwaite , Chris Wulff , Dmitry Fleytman , "Edgar E . Iglesias" , Igor Mitsyanko , Max Filippov , Magnus Damm , Marcel Apfelbaum , Subbaraya Sundeep , Alberto Garcia , Mark Cave-Ayland , Keith Busch , Stefano Stabellini , Peter Maydell , Stefan Berger , Bastian Koppelmann , Paul Burton , Yongbok Kim , Peter Chubb , Yuval Shaia , =?iso-8859-1?Q?Herv=E9?= Poussineau , Alex Williamson , Markus Armbruster , Cornelia Huck , David Hildenbrand , Eduardo Habkost , Fam Zheng , Igor Mammedov , Jason Wang , Gerd Hoffmann , Kevin Wolf , Max Reitz , Paolo Bonzini , Michael Clark , Palmer Dabbelt , Jiri Slaby , Alexander Graf , Richard Henderson , Michael Walle , Jan Kiszka On Mon, Jun 11, 2018 at 10:55:17AM -0500, Eric Blake wrote: > On 06/10/2018 08:14 PM, Philippe Mathieu-Daud=E9 wrote: > > Hi, > >=20 > > This series: > >=20 > > - split the byte-based definitions from "qemu/cutils.h" to "qemu/unit= s.h" > > (this now triggers WARNING: 1 added file, does MAINTAINERS need up= dating?) > > - clean hw/ includes; > > - replace different constants used for byte size with their correspon= ding > > IEC binary prefix definitions. > >=20 > > Since v3: > > - use IEC binary prefix definitions (Stefan Weil) > > - rebased > > - added R-b tags > >=20 >=20 > > hw/net/ne2000.h | 5 ++-- > ... > > tests/test-qemu-opts.c | 7 +++--- > > scripts/checkpatch.pl | 1 + > > 135 files changed, 533 insertions(+), 431 deletions(-) > > create mode 100644 include/qemu/units.h > >=20 >=20 > At least monitor.c and vl.c are missing from this list; a more general = grep > shows that the following are all potential candidates for this cleanup: >=20 > $ git grep -n '[<>][<>]=3D [1-5]0' > disas/m68k.c:787: val >>=3D 10; > hw/mips/mips_malta.c:194: ram_size >>=3D 20; > hw/ppc/sam460ex.c:129: ram_size >>=3D 20; > hw/timer/sh_timer.c:112: case 4: freq >>=3D 10; break; Most likely not 4 kilobyte. > linux-user/mips/cpu_loop.c:641: code >>=3D= 10; > linux-user/mips/cpu_loop.c:664: code >>=3D 10; Seems to do with decoding machine code. Also unlikely to be in bytes. > monitor.c:3198: val <<=3D 20; > target/m68k/helper.c:386: size >>=3D 10; > target/m68k/helper.c:390: size >>=3D 10; > target/m68k/helper.c:394: size >>=3D 10; > target/xtensa/helper.c:729: sz >>=3D 20; > target/xtensa/helper.c:732: sz >>=3D 10; > vl.c:2793: sz <<=3D 20; > --=20 > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org