From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v5,2/6] dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs From: Vinod Koul Message-Id: <20180612040031.GI2452@vkoul-mobl> Date: Tue, 12 Jun 2018 09:30:31 +0530 To: Li Yang Cc: Wen He , "dmaengine@vger.kernel.org" , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jiafei Pan , Jiaheng Fan List-ID: T24gMDUtMDYtMTgsIDEyOjI0LCBMaSBZYW5nIHdyb3RlOgo+IE9uIFR1ZSwgSnVuIDUsIDIwMTgg YXQgMTE6MzAgQU0sIFZpbm9kIDx2a291bEBrZXJuZWwub3JnPiB3cm90ZToKPiA+IE9uIDA0LTA2 LTE4LCAwOTo1MywgV2VuIEhlIHdyb3RlOgo+ID4KPiA+Pgo+ID4+ID4gPiArLy8gU1BEWC1MaWNl bnNlLUlkZW50aWZpZXI6IEdQTC0yLjAKPiA+PiA+ID4gKy8vIENvcHlyaWdodCAyMDE4IE5YUAo+ ID4+ID4KPiA+PiA+IEkga25vdyB0aGUgU1BEWCB0YWcgaXMgcmVjb21tZW5kZWQgdG8gYmUgdGhl IDFzdCBsaW5lLCBidXQgY29weXJpZ2h0IG5vcm1hbGx5Cj4gPj4gPiBnb2VzIGJlbG93IHRoZSBm aWxlIGRlc2NyaXB0aW9uIG5vdCBhYm92ZS4KPiA+Cj4gPiBJIGRvIG5vdCB0aGluayB0aGF0IGlz IHNwZWNpZmllZCBhbnl3aGVyZS4uIGNhbiB5b3UgcG9pbnQgaXQ/Cj4gCj4gTm8uICBJdCBpcyBu b3QgZG9jdW1lbnRlZC4gIEJ1dCB0aGUgbWFqb3JpdHkgb2YgdGhlIHNvdXJjZSBmaWxlcyBpbgo+ IExpbnV4IGFyZSB1c2luZyB0aGlzIGhlYWRlciBmb3JtYXQgbGlrZSBiZWxvdywgc28gSSBhc3N1 bWUgaXQgaXMKPiBzb21ldGhpbmcgbGlrZSBhIGNvbnZlbnRpb24uCj4gCj4gLyoKPiAgKiB7Zmls ZW5hbWUgLS19IGZpbGUgZGVzY3JpcHRpb24KPiAgKgo+ICAqIENvcHlyaWdodCAuLi4KPiAgKgo+ ICAqIExpY2Vuc2UgLi4uCj4gICovCj4gCj4gVGhlIERvY3VtZW50YXRpb24vcHJvY2Vzcy9saWNl bnNlLXJ1bGVzLnJzdCBvbmx5IG1lbnRpb25lZCBhYm91dCB0aGUKPiByZXF1aXJlbWVudCBmb3Ig U1BEWCB0YWdzLiAgU28gSSB0aGluayB3ZSBzaG91bGQga2VlcCB0aGUgZm9ybWF0IGZvcgo+IG90 aGVyIHBhcnQgb2YgdGhlIGhlYWRlci4KCkFuZCBMaW51cyBzYWlkIHRoaXMgaHR0cHM6Ly9sa21s Lm9yZy9sa21sLzIwMTcvMTEvMjUvMTMzCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 12 Jun 2018 09:30:31 +0530 From: Vinod Subject: Re: [v5 2/6] dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs Message-ID: <20180612040031.GI2452@vkoul-mobl> References: <20180525111920.24498-1-wen.he_1@nxp.com> <20180525111920.24498-2-wen.he_1@nxp.com> <20180605163043.GX16230@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Li Yang Cc: Wen He , "dmaengine@vger.kernel.org" , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jiafei Pan , Jiaheng Fan List-ID: On 05-06-18, 12:24, Li Yang wrote: > On Tue, Jun 5, 2018 at 11:30 AM, Vinod wrote: > > On 04-06-18, 09:53, Wen He wrote: > > > >> > >> > > +// SPDX-License-Identifier: GPL-2.0 > >> > > +// Copyright 2018 NXP > >> > > >> > I know the SPDX tag is recommended to be the 1st line, but copyright normally > >> > goes below the file description not above. > > > > I do not think that is specified anywhere.. can you point it? > > No. It is not documented. But the majority of the source files in > Linux are using this header format like below, so I assume it is > something like a convention. > > /* > * {filename --} file description > * > * Copyright ... > * > * License ... > */ > > The Documentation/process/license-rules.rst only mentioned about the > requirement for SPDX tags. So I think we should keep the format for > other part of the header. And Linus said this https://lkml.org/lkml/2017/11/25/133 -- ~Vinod