From: Tiwei Bie <tiwei.bie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: zhihong.wang@intel.com, dev@dpdk.org
Subject: Re: [PATCH v3 2/5] net/virtio: use simple path for Tx even if Rx mergeable
Date: Tue, 12 Jun 2018 14:18:39 +0800 [thread overview]
Message-ID: <20180612061839.GA14136@debian> (raw)
In-Reply-To: <20180607092616.27720-3-maxime.coquelin@redhat.com>
On Thu, Jun 07, 2018 at 11:26:13AM +0200, Maxime Coquelin wrote:
> Having Rx mergeable buffers feature enabled should not be
> a reason to not use Tx simple path.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> drivers/net/virtio/virtio_ethdev.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index 052dd056a..c6087d9b1 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1948,10 +1948,8 @@ virtio_dev_configure(struct rte_eth_dev *dev)
> hw->use_simple_tx = 0;
> }
> #endif
> - if (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) {
> + if (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF))
> hw->use_simple_rx = 0;
> - hw->use_simple_tx = 0;
> - }
>
> if (rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM |
> DEV_RX_OFFLOAD_TCP_CKSUM))
> --
> 2.14.3
>
next prev parent reply other threads:[~2018-06-12 6:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 9:26 [PATCH v3 0/5] net/virtio: Tx path selection and offload improvements Maxime Coquelin
2018-06-07 9:26 ` [PATCH v3 1/5] net/virtio: forbid simple Tx path by default Maxime Coquelin
2018-06-12 6:35 ` Tiwei Bie
2018-06-12 11:52 ` Maxime Coquelin
2018-06-07 9:26 ` [PATCH v3 2/5] net/virtio: use simple path for Tx even if Rx mergeable Maxime Coquelin
2018-06-12 6:18 ` Tiwei Bie [this message]
2018-06-07 9:26 ` [PATCH v3 3/5] net/vhost: improve Tx path selection Maxime Coquelin
2018-06-07 9:26 ` [PATCH v3 4/5] net/virtio: don't use simple Rx if TCP LRO or VLAN strip requested Maxime Coquelin
2018-06-07 9:26 ` [PATCH v3 5/5] net/virtio: improve offload check performance Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612061839.GA14136@debian \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.