From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSkqi-0002DS-Tj for qemu-devel@nongnu.org; Tue, 12 Jun 2018 11:04:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSkqf-0002uS-SB for qemu-devel@nongnu.org; Tue, 12 Jun 2018 11:04:44 -0400 Date: Tue, 12 Jun 2018 17:04:34 +0200 From: Kevin Wolf Message-ID: <20180612150434.GF4355@localhost.localdomain> References: <20180612125821.4229-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180612125821.4229-1-armbru@redhat.com> Subject: Re: [Qemu-devel] [PATCH 00/18] block: Configuration fixes and rbd authentication List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com, jcody@redhat.com, eblake@redhat.com Am 12.06.2018 um 14:58 hat Markus Armbruster geschrieben: > PATCH 01-17 are configuration fixes and cleanup, in particular > -blockdev driver=nfs,... and -drive driver=(nbd|sheepdog|ssh),... with > non-string scalars. > > PATCH 18-19 provide support for configuring rbd authentication. > > I'm happy to split the series if that helps. > > Since the RFC post, I amended the documentation of the rbd > authentication parameters, and squashed PATCH 04 into 03. I was still reviewing the RFC while you sent this, so I posted two comments that are still relevant for this version in the RFC thread. Please read them there, I'm not going to duplicate them here. Will continue with the review on this one now. Kevin